Hi, I read about an spec file option "stage4/users" in a spec from kyron's SoC SSI project, but when I try to use it, I get: !!! catalyst: Argument "stage4/users" not recognized. My apologies if this isn't supposed to be a supported option, but if it's simple to make it work again, that'd be awesome. Reproducible: Always
Well, this option is in the example stage4 spec, and there's no reason it shouldn't be supported. However, the option isn't in the list of valid options in stage4, and the code to handle it is in livecdfs-udpate.sh.
Created attachment 373660 [details, diff] enable 'stage4/users' feature This patch would enable 'stage4/users' feature while building stage4 archive.
FYI: The patch I have attached before would work only with [3.0] branch. Not supported with version <3.0
Created attachment 374208 [details, diff] enable 'stage4/users' feature
Hello, In the (stable) version on my system (dev-util/catalyst-3.0.5) the "stage4/users" is still not recognized: ERROR : CatalystError: Argument "stage4/users" not recognized. Is there an important reason why the patch is not yet, after 5 years, in catalyst? Best
I tried this patch (after a bit of work to port it to newest codebase) and it didn't work as-is. So that's why I personally haven't done anything with it. Can you test & confirm that it works for you?
Hi, After looking at the code, I don't see why this patch should work in the current codebase... I'll try to implement it. What testing strategy is followed in the development of Catalyst? I don't find much info...
Created attachment 597844 [details, diff] bug fix At least it works for me. I think there must be 100 things to improve though.
There is at least one issue: the docs (man catalyst-spec, section miscellaneous) claims that <target>/users creates users belonging "to the following groups: users, wheel, audio, games, cdrom, and usb" This patch does not do that because the group "games" does not exist. Should I create the group "games" too, to comply with the docs, or should the man page be modified?
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=a6522008e915abbbf7cddc057c9f7951e7d667a6 commit a6522008e915abbbf7cddc057c9f7951e7d667a6 Author: Patrice Clement <monsieurp@gentoo.org> AuthorDate: 2022-03-08 21:11:13 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2022-04-02 23:50:27 +0000 example: document new options Closes: https://bugs.gentoo.org/236905 Signed-off-by: Patrice Clement <monsieurp@gentoo.org> Signed-off-by: Matt Turner <mattst88@gentoo.org> examples/stage4_template.spec | 34 ++++++++++++++++++++++++++++------ 1 file changed, 28 insertions(+), 6 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=5be6069bcbd5a7fa3f114f28366597bc5ddbb891 commit 5be6069bcbd5a7fa3f114f28366597bc5ddbb891 Author: Patrice Clement <monsieurp@gentoo.org> AuthorDate: 2022-03-08 21:02:55 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2022-04-02 23:50:16 +0000 catalyst: support 3 new options * stage4/groups: create a a list of groups. * stage4/users: create a list of users. users can also be added to groups using the "foo.bar=wheel,audio,baz" format. * stage4/ssh_public_keys: copy an SSH public key into the stage4 user's home (.ssh/authorized_keys) and set the file permission to 0644. Bug: https://bugs.gentoo.org/236905 Signed-off-by: Patrice Clement <monsieurp@gentoo.org> Signed-off-by: Matt Turner <mattst88@gentoo.org> catalyst/base/stagebase.py | 70 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+)
