nothing in the tree refers to EXEDESTTREE or DOCSDESTTREE anymore and ive changed portage so it doesnt respect these variables, so those can go now i'm working on pruning INSDESTTREE and DESTTREE
r142 removes EXE and DOCS. The rest have to stay unless the tree is fixed before PMS is finalised.
*** Bug 566178 has been marked as a duplicate of this bug. ***
List of variables: DESTTREE, INSDESTTREE INSOPTIONS, DIROPTIONS, EXEOPTIONS, LIBOPTIONS Eclasses still using these variables (some of them added by a certain mgorny :) distutils-r1.eclass java-utils-2.eclass python-utils-r1.eclass These should probably be cleaned up first.
Some of them cleaned up on a certain EAPI 6 branch.
Thinking about it, issues are different enough to deserve two bugs. Using this bug for DESTTREE and INSDESTTREE. Using bug 566178 for INSOPTIONS, DIROPTIONS, EXEOPTIONS, and LIBOPTIONS.
Are we waiting with this for next EAPI, or doing it retroactively?
(In reply to Michał Górny from comment #6) > Are we waiting with this for next EAPI, or doing it retroactively? Since these variables are (as of today) used in eclasses, I would say next EAPI.
Well, I was asking since you added the feasible tag. Since new EAPI is not anywhere in sight, I'll look into cleaning up the repository.
$ git grep DESTTREE | wc -l 0 Can we kill it now, please? ;-)
(In reply to Michał Górny from comment #9) > $ git grep DESTTREE | wc -l > 0 Nice. > Can we kill it now, please? ;-) For PMS, I'd still use regular procedure (i.e., EAPI 7) because these two are in the big list of PM defined variables. Also removals aren't urgent, usually. Maybe we could make it tree policy, i.e. add a repoman check?
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=a5d0111d0bdaa7ee9e5c68e22b4a97ce415e119b commit a5d0111d0bdaa7ee9e5c68e22b4a97ce415e119b Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2018-03-04 09:49:35 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-03-04 21:03:56 +0000 Ban DESTTREE/INSDESTTREE in EAPI 7 Ban the direct use of DESTTREE/INSDESTTREE in EAPI 7. Use new _E_* helper variables for into/insinto. Bug: https://bugs.gentoo.org/173630 Closes: https://github.com/gentoo/portage/pull/261 Series-Reviewed-by: Zac Medico <zmedico@gentoo.org> bin/eapi.sh | 4 ++++ bin/ebuild-helpers/dobin | 16 ++++++++++++---- bin/ebuild-helpers/doconfd | 4 ++-- bin/ebuild-helpers/doenvd | 4 ++-- bin/ebuild-helpers/doheader | 4 ++-- bin/ebuild-helpers/doins | 18 +++++++++++++----- bin/ebuild-helpers/dolib | 10 +++++++++- bin/ebuild-helpers/domo | 16 ++++++++++++---- bin/ebuild-helpers/dosbin | 16 ++++++++++++---- bin/phase-functions.sh | 11 ++++++++--- bin/phase-helpers.sh | 33 +++++++++++++++++++++++---------- bin/save-ebuild-env.sh | 4 ++-- 12 files changed, 101 insertions(+), 39 deletions(-)}
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/pms.git/commit/?id=1d6bf595e8f17414b3d02956d87ce1a3636bf460 commit 1d6bf595e8f17414b3d02956d87ce1a3636bf460 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2017-09-29 03:13:57 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2018-03-30 16:35:43 +0000 EAPI 7 removes DESTTREE and INSDESTTREE. Bug: https://bugs.gentoo.org/173630 eapi-differences.tex | 8 ++++++++ ebuild-env-vars.tex | 19 ++++++++++++------- 2 files changed, 20 insertions(+), 7 deletions(-)}
