opensp-1.5.2 has been in the tree since May 2006 and there have been no issues reported with it except on alpha (bug #140017). However, the current stable version (1.5.1) has a patch for gcc-4.1 that was added after stabilizing and there was no revbump with it. This means that people who have emerged a stable opensp before november 2005 have a broken include file with gcc-4 (see bug #152357). Rather than producing a revbump for 1.5.1 with this patch, I think it would be better to stabilize 1.5.2, where the issue is fixed too.
I forgot to add that opensp-1.5.* are known not to pass some tests (see bug #85277). This didn't stop 1.5.1 from being stabilized, I hope it won't be an issue here either.
1. emerges on x86 2. passes collision test 3. fails make test PASS: af-19 /var/tmp/portage/opensp-1.5.2/work/OpenSP-1.5.2/nsgmls/.libs/lt-onsgmls:E: error reading "./cat-2/" (Is a directory) FAIL: catalog-2 /var/tmp/portage/opensp-1.5.2/work/OpenSP-1.5.2/nsgmls/.libs/lt-onsgmls:af-7.sgml:3:1:E: value of attribute "TYPE" cannot be "A"; must be one of "ZZZ", "YYY" 2c2 < ATYPE TOKEN YYY --- > ATYPE TOKEN A FAIL: af-7 /var/tmp/portage/opensp-1.5.2/work/OpenSP-1.5.2/nsgmls/.libs/lt-onsgmls:af-8.sgml:3:1:E: value of attribute "ROLE" cannot be "A"; must be one of "ZZZ", "YYY" 2c2 < AROLE TOKEN YYY --- > AROLE TOKEN A FAIL: af-8 3c3 < AN CDATA verse 1 --- > AN CDATA 1 7c7 < AN CDATA verse 2 --- > AN CDATA 2 FAIL: af-9 4c4 < ATEXT CDATA verse 1 --- > ATEXT IMPLIED 8c8 < ATEXT CDATA verse 2 --- > ATEXT IMPLIED FAIL: af-10 3c3 < ATEXT CDATA verse 1 --- > ATEXT IMPLIED 5c5 < -1 --- > -verse 1 7c7 < ATEXT CDATA verse 2 --- > ATEXT IMPLIED 9c9 < -2 --- > -verse 2 FAIL: af-11 PASS: catalog-1 ==================== 6 of 23 tests failed ==================== 4. seems to work, as www-client/epiphany-extensions emerges and works fine. app-text/opensp-1.5.2 USE="nls -doc" Portage 2.1.1 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.4-r3, 2.6.18.1 i686) ================================================================= System uname: 2.6.18.1 i686 Genuine Intel(R) CPU T2300 @ 1.66GHz Gentoo Base System version 1.12.5 Last Sync: Sun, 22 Oct 2006 09:50:01 +0000 ccache version 2.3 [disabled] app-admin/eselect-compiler: [Not Present] dev-java/java-config: 1.3.7, 2.0.30 dev-lang/python: 2.3.5-r3, 2.4.3-r4 dev-python/pycrypto: 2.0.1-r5 dev-util/ccache: 2.3 dev-util/confcache: [Not Present] sys-apps/sandbox: 1.2.17 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2 sys-devel/binutils: 2.16.1-r3 sys-devel/gcc-config: 1.3.13-r4 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.17-r1 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/" CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo" CXXFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--nospinner" FEATURES="autoconfig collision-protect distlocks metadata-transfer parallel-fetch sandbox sfperms strict test userfetch userpriv usersandbox" GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo" LINGUAS="en de en_GB de_CH" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" USE="x86 X a52 aac acpi alsa apache2 asf berkdb bitmap-fonts cairo cdr cdrom cli cracklib crypt cups dbus divx dlloader dri dts dvd dvdr dvdread eds elibc_glibc emboss encode fam ffmpeg firefox flac fortran gdbm gif gnome gpm gstreamer gtk hal input_devices_keyboard input_devices_mouse ipv6 isdnlog java jpeg kde kernel_linux ldap libg++ linguas_de linguas_de_CH linguas_en linguas_en_GB mad mikmod mmx mono mp3 mpeg ncurses nls nptl nptlonly ogg opengl oss pam pcre perl png ppds pppd python qt3 qt4 quicktime readline reflection rtsp samba sdl session smp spell spl sse sse2 sse3 ssl svg tcpd test tetex theora threads truetype truetype-fonts type1-fonts udev unicode userland_GNU vcd video_cards_fbdev video_cards_i810 video_cards_vesa vorbis win32codecs wxwindows x264 xine xml xorg xprint xv xvid zlib" Unset: CTARGET, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
(In reply to comment #1) > I forgot to add that opensp-1.5.* are known not to pass some tests (see bug > #85277). This didn't stop 1.5.1 from being stabilized, I hope it won't be an > issue here either. Can anything be done about that? [ebuild U ] app-text/opensp-1.5.2 [1.5.1] USE="nls -doc%" 1) emerges fine 2) passes collision test 3) fails test suite /var/tmp/portage/opensp-1.5.2/work/OpenSP-1.5.2/nsgmls/.libs/lt-onsgmls:E: error reading "./cat-2/" (Is a directory) FAIL: catalog-2 /var/tmp/portage/opensp-1.5.2/work/OpenSP-1.5.2/nsgmls/.libs/lt-onsgmls:af-7.sgml:3:1:E: value of attribute "TYPE" cannot be "A"; must be one of "ZZZ", "YYY" 2c2 < ATYPE TOKEN YYY --- > ATYPE TOKEN A FAIL: af-7 /var/tmp/portage/opensp-1.5.2/work/OpenSP-1.5.2/nsgmls/.libs/lt-onsgmls:af-8.sgml:3:1:E: value of attribute "ROLE" cannot be "A"; must be one of "ZZZ", "YYY" 2c2 < AROLE TOKEN YYY --- > AROLE TOKEN A FAIL: af-8 3c3 < AN CDATA verse 1 --- > AN CDATA 1 7c7 < AN CDATA verse 2 --- > AN CDATA 2 FAIL: af-9 4c4 < ATEXT CDATA verse 1 --- > ATEXT IMPLIED 8c8 < ATEXT CDATA verse 2 --- > ATEXT IMPLIED FAIL: af-10 3c3 < ATEXT CDATA verse 1 --- > ATEXT IMPLIED 5c5 < -1 --- > -verse 1 7c7 < ATEXT CDATA verse 2 --- > ATEXT IMPLIED 9c9 < -2 --- > -verse 2 FAIL: af-11 4) revdep-rebuild done as suggested, app-text/openjade emerges fine on it Portage 2.1.1 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.4-r3, 2.6.17-gentoo-r8 i686) ================================================================= System uname: 2.6.17-gentoo-r8 i686 AMD Athlon(tm) XP 2500+ Gentoo Base System version 1.12.5 Last Sync: Sun, 22 Oct 2006 05:50:01 +0000 app-admin/eselect-compiler: [Not Present] dev-java/java-config: 1.3.7, 2.0.30 dev-lang/python: 2.4.3-r4 dev-python/pycrypto: 2.0.1-r5 dev-util/ccache: [Not Present] dev-util/confcache: [Not Present] sys-apps/sandbox: 1.2.17 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2 sys-devel/binutils: 2.16.1-r3 sys-devel/gcc-config: 1.3.13-r4 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.17-r1 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-O2" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/" CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo" CXXFLAGS="-O2" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig ccache collision-protect distlocks metadata-transfer parallel-fetch sandbox sfperms strict test" GENTOO_MIRRORS="ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo/" LANG="de_DE@euro" LC_ALL="de_DE@euro" LINGUAS="de" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.informatik.rwth-aachen.de/gentoo-portage" USE="x86 3dnow 3dnowext X Xaw3d a52 aiglx alsa artworkextra asf audiofile bash-completion beagle berkdb bidi bitmap-fonts bootsplash branding bzip2 cairo cdda cddb cdparanoia cdr cli cracklib crypt css cups curl custom-cflags dbus dga directfb divx4linux dlloader dri dts dvd dvdr dvdread dvi eds elibc_glibc emacs emboss encode esd evo exif expat fam fat fbcon ffmpeg firefox fortran ftp gb gcj gdbm gif gnome gpm gstreamer gtk gtk2 gtkhtml hal icq idn imagemagick imap input_devices_keyboard input_devices_mouse ipv6 isdnlog java javascript jikes jpeg jpeg2k kde kernel_linux ldap leim libg++ linguas_de lm_sensors mad maildir matroska mbox mhash mikmod mime mmx mmxext mng mono mp3 mpeg mpeg2 mule mysql nautilus ncurses nforce2 nls nocardbus nptl nptlonly nsplugin nvidia objc ogg opengl pam pcre pdf perl plotutils pmu png ppds pppd preview-latex print python qt3 qt4 quicktime readline reflection reiserfs samba sdk session slang spell spl sse ssl svg svga t1lib tcltk tcpd tetex theora thunderbird tiff truetype truetype-fonts type1-fonts udev usb userland_GNU vcd video_cards_fbdev video_cards_radeon video_cards_vesa videos vorbis win32codecs wmf wxwindows xine xml xorg xosd xv xvid zlib" Unset: CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS
(In reply to comment #1) > I forgot to add that opensp-1.5.* are known not to pass some tests (see bug > #85277). This didn't stop 1.5.1 from being stabilized, I hope it won't be an > issue here either. Ideally you'd provide a custom src_test that only runs the tests that're expected to work (and then contact upstream about it). It makes things very tricky for arch teams when src_test isn't reliable.
ppc64 stable
Upstream provides a way to disable the failing tests, blame me for not reading bug #85277 correctly :s I commited opensp-1.5.2-r1 with this fix, do you want to wait a full month before stabilization or can we proceed right ahead (assuming tests are now successfully passed everywhere)?
(In reply to comment #6) > Upstream provides a way to disable the failing tests, blame me for not reading > bug #85277 correctly :s > I commited opensp-1.5.2-r1 with this fix, do you want to wait a full month > before stabilization or can we proceed right ahead (assuming tests are now > successfully passed everywhere)? I would say, we must not wait...if the test fix is the only change. All tests succeed, so should ppc64 readded?
Probably so. @ppc64: please accept my apologies and consider stabling 1.5.2-r1 so we can punt 1.5.2 (otherwise we can also keep both versions in the tree).
- emerges fine on amd64 - passes collision-test - passes multilib-strict - works Portage 2.1.1-r1 (default-linux/amd64/2006.1/desktop, gcc-4.1.1, glibc-2.5-r0, 2.6.18-ck1-r1 x86_64) ================================================================= System uname: 2.6.18-ck1-r1 x86_64 AMD Athlon(tm) 64 Processor 3000+ Gentoo Base System version 1.12.5 Last Sync: Mon, 23 Oct 2006 23:50:01 +0000 ccache version 2.3 [enabled] app-admin/eselect-compiler: [Not Present] dev-java/java-config: 1.3.7, 2.0.30 dev-lang/python: 2.4.3-r4 dev-python/pycrypto: 2.0.1-r5 dev-util/ccache: 2.3 dev-util/confcache: [Not Present] sys-apps/sandbox: 1.2.17 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2 sys-devel/binutils: 2.16.1-r3 sys-devel/gcc-config: 1.3.13-r4 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="amd64" AUTOCLEAN="yes" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=k8 -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/X11/xkb" CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo" CXXFLAGS="-march=k8 -O2 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig buildsyspkg ccache collision-protect distlocks metadata-transfer multilib-strict parallel-fetch sandbox sfperms strict test" GENTOO_MIRRORS="ftp://linux.rz.ruhr-uni-bochum.de/gentoo-mirror/ ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo ftp://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ ftp://ftp.gentoo.mesh-solutions.com/gentoo/ ftp://pandemonium.tiscali.de/pub/gentoo/ " LANG="en_US.ISO-8859-15" LC_ALL="en_US.ISO-8859-15" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_EXTRA_OPTS="--exclude-from=/etc/portage/rsync_excludes" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage/overlay" SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" USE="amd64 X a52 aac acpi alsa amr berkdb bitmap-fonts branding bzip2 cairo cdinstall cdr cli cracklib crypt cups dbus divx dlloader dri dvd dvdr dvdread eds elibc_glibc emboss encode fam ffmpeg firefox fortran gdbm gif glut gpm gstreamer gtk gtk2 hal imagemagick input_devices_evdev input_devices_keyboard ipod isdnlog jpeg kernel_linux ldap libg++ lirc lirc_devices_inputlirc logrotate mad mikmod mng mp3 mpeg ncurses nls nptl nptlonly offensive ogg opengl pam pcre php png ppds pppd quicktime readline reflection rtc sdl session socks5 spl ssl svg symlink tcpd test tiff truetype truetype-fonts type1-fonts udev unicode userland_GNU userlocales v4l v4l2 video_cards_fglrx video_cards_radeon vim-with-x vorbis wmp xinerama xml xorg xv xvid zlib" Unset: CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS, LINGUAS
amd64 done.
-r1 stable on ppc64
SPARC stable
Stable on ppc.
x86 stable
Stable on hppa.
Created attachment 108113 [details] ebuild opensp-1.5.2-r1.ebuild test I encountered these errors during the test part of this ebuild. I tried to emerge app-text/docbook-sgml-dtd as it looked like the test misses some files related to this package. When I emerged version 4.4 of it there was no change in the error log. After emerging 4.1, the error message for the 4.1 file was not present. Emerging 4.0 took off the 4.0 messages as well (even after I unmerged it). # emerge --info Portage 2.1.1-r2 (default-linux/amd64/2006.1/desktop, gcc-4.1.1, glibc-2.4-r4, 2.6.18-gentoo-r4 x86_64) ================================================================= System uname: 2.6.18-gentoo-r4 x86_64 AMD Athlon(tm) 64 Processor 3000+ Gentoo Base System version 1.12.6 Last Sync: Thu, 25 Jan 2007 02:20:01 +0000 ccache version 2.3 [enabled] app-admin/eselect-compiler: [Not Present] dev-java/java-config: 1.3.7, 2.0.30 dev-lang/python: 2.3.5-r2, 2.4.3-r4 dev-python/pycrypto: 2.0.1-r5 dev-util/ccache: 2.3 dev-util/confcache: [Not Present] sys-apps/sandbox: 1.2.17 sys-devel/autoconf: 2.13, 2.61 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10 sys-devel/binutils: 2.16.1-r3 sys-devel/gcc-config: 1.3.14 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="amd64" AUTOCLEAN="yes" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=k8 -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config" CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c" CXXFLAGS="-march=k8 -O2 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig ccache distlocks metadata-transfer parallel-fetch sandbox sfperms strict test userfetch userpriv usersandbox" GENTOO_MIRRORS="http://mirror.hamakor.org.il/pub/mirrors/gentoo http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo" LANG="he_IL.UTF-8" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage /usr/portage/local/layman/xeffects" SYNC="rsync://mirror.hamakor.org.il/gentoo-portage" USE="amd64 X aac alsa alsa_cards_intel8x0,usb-audio alsa_pcm_plugins_adpcm alsa_pcm_plugins_alaw alsa_pcm_plugins_asym alsa_pcm_plugins_copy alsa_pcm_plugins_dmix alsa_pcm_plugins_dshare alsa_pcm_plugins_dsnoop alsa_pcm_plugins_empty alsa_pcm_plugins_extplug alsa_pcm_plugins_file alsa_pcm_plugins_hooks alsa_pcm_plugins_iec958 alsa_pcm_plugins_ioplug alsa_pcm_plugins_ladspa alsa_pcm_plugins_lfloat alsa_pcm_plugins_linear alsa_pcm_plugins_meter alsa_pcm_plugins_mulaw alsa_pcm_plugins_multi alsa_pcm_plugins_null alsa_pcm_plugins_plug alsa_pcm_plugins_rate alsa_pcm_plugins_route alsa_pcm_plugins_share alsa_pcm_plugins_shm alsa_pcm_plugins_softvol apache2 avi bash-completion berkdb bidi bitmap-fonts cairo cdda cddb cdio cdr cli cpudetection cracklib crypt crypto cups dbus directfb dlloader dri dts dvd dvdr elibc_glibc emboss encode fam ffmpeg firefox font-server fortran gdbm gif gpm gstreamer gtk gtk2 hal iconv input_devices_evdev input_devices_keyboard input_devices_mouse ipod isdnlog jack jpeg kde kernel_linux lcd_devices_bayrad lcd_devices_cfontz lcd_devices_cfontz633 lcd_devices_glk lcd_devices_hd44780 lcd_devices_lb216 lcd_devices_lcdm001 lcd_devices_mtxorb lcd_devices_ncurses lcd_devices_text libg++ mad mbrola mikmod mmext mp3 mpeg ncurses network nls nptl nptlonly nsplugin nvidia ogg oggvorbis opengl pam pcre perl png ppds pppd python qt qt3 qt4 quicktime readline reflection rss sdl session spell spl ssl stream tcpd threads truetype truetype-fonts type1-fonts udev unicode userland_GNU v4l video_cards_fbdev video_cards_nvidia video_cards_vesa vorbis wxwindows xml xorg xv xvid zlib" Unset: CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, LINGUAS, PORTAGE_RSYNC_EXTRA_OPTS
(In reply to comment #16) > Created an attachment (id=108113) [edit] > ebuild opensp-1.5.2-r1.ebuild test > > I encountered these errors during the test part of this ebuild. Those seem to be related to a local problem in your machine, and not really caused by the tests themselves. Maybe you had some of the docbook-sgml-dtd slots installed (3.0, 3.1 and 4.0) and at some point they got removed (e.g. by using emerge --depclean). To fix it, you could manually remove the stale entries from /etc/sgml/catalog, or simply install again those that are missing: emerge ~docbook-sgml-dtd-3.0 ~docbook-sgml-dtd-3.1 ~docbook-sgml-dtd-4.0
This was assigned to mips but instead there are both alpha and mips left.
alpha stable
No activity here, CANTFIX.
