Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 96330 - SiS760 chipset not supported for AMD64 agpgart
Summary: SiS760 chipset not supported for AMD64 agpgart
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
Keywords: Inclusion
Depends on:
Reported: 2005-06-16 18:42 UTC by Scott Fudally
Modified: 2005-06-29 03:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Patch to add PCI ID for SiS760 (amd64-agp.c_SiS760.patch,503 bytes, patch)
2005-06-16 18:42 UTC, Scott Fudally
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Fudally 2005-06-16 18:42:16 UTC
The PCI ID is not listed in amd64-agp.c so it is not recognized

Reproducible: Always
Steps to Reproduce:
1. Compile in agpgart support
2. Boot on SiS760 chips
3. agpgart does not find a supported chipset

Actual Results:  
No agpgart support

Expected Results:  
Agpgart support

The below patch fixes the issue (just adds the 760 PCI ID)
to kernel linux-2.6.11-gentoo-r11

--- linux/drivers/char/agp/amd64-agp.c.orig     2005-04-22 22:21:36.000000000 +0000
+++ linux/drivers/char/agp/amd64-agp.c  2005-04-22 21:35:08.000000000 +0000
@@ -685,6 +685,15 @@ static struct pci_device_id agp_amd64_pc
        .subvendor      = PCI_ANY_ID,
        .subdevice      = PCI_ANY_ID,
+       /* SIS 760 */
+       {
+       .class          = (PCI_CLASS_BRIDGE_HOST << 8),
+       .class_mask     = ~0,
+       .vendor         = PCI_VENDOR_ID_SI,
+       .device         = PCI_DEVICE_ID_SI_760,
+       .subvendor      = PCI_ANY_ID,
+       .subdevice      = PCI_ANY_ID,
+       },
        { }
Comment 1 Scott Fudally 2005-06-16 18:42:49 UTC
Created attachment 61364 [details, diff]
Patch to add PCI ID for SiS760
Comment 2 Mike Doty (RETIRED) gentoo-dev 2005-06-16 19:05:39 UTC
kernel team:  Can we add this to the gentoo patchset?  It seems trivial.
Comment 3 Daniel Drake (RETIRED) gentoo-dev 2005-06-17 01:20:15 UTC
This device is supported by the sis-agp driver
Comment 4 Scott Fudally 2005-06-17 17:46:41 UTC
You cannot select the sis-agp driver on amd64 - you have to use the amd64-agp
driver.  The kconfig parameters prevent it.
Comment 5 Daniel Drake (RETIRED) gentoo-dev 2005-06-19 03:43:12 UTC
Ok, where has the patch come from? Has it been submitted upstream?
Comment 6 Scott Fudally 2005-06-20 17:35:14 UTC
I sent the patch to the the two maintainers listed in the amd64-agp.c file but I
did get a reply.
Comment 7 Daniel Drake (RETIRED) gentoo-dev 2005-06-22 05:35:08 UTC
I suggest you read Documentation/SubmittingPatches and re-submit if you did not
do it exactly as described there.
Comment 8 Daniel Drake (RETIRED) gentoo-dev 2005-06-22 05:42:25 UTC
(In reply to comment #6)
> I sent the patch to the the two maintainers listed in the amd64-agp.c file but I
> did get a reply.

Sorry, I misread this comment. If you did get a reply, what did they say?
Comment 9 Scott Fudally 2005-06-22 16:55:29 UTC
I have not received a reply from either maintainer.

I wanted to get the patch at least into the Gentoo kernel so I do not have to
manually re-patch my kernel.

Any recommendations on another place to submit the patch?
Comment 10 Daniel Drake (RETIRED) gentoo-dev 2005-06-23 02:36:11 UTC
Have you read Documentation/SubmittingPatches?

(Feel free to confirm the details here before you send it...)
Comment 11 Daniel Drake (RETIRED) gentoo-dev 2005-06-28 11:57:25 UTC
Bump.. Any progress on this? Would you like me to submit the patch for you?
Comment 12 Scott Fudally 2005-06-28 16:35:37 UTC
Yes, if you would not mind.  I did not get any replies to my original submission
and I do not have time right now to persue it further.
Comment 13 Daniel Drake (RETIRED) gentoo-dev 2005-06-28 17:02:17 UTC
Done, awaiting response
Comment 14 Daniel Drake (RETIRED) gentoo-dev 2005-06-29 03:58:55 UTC
Ok, its accepted into 2.6.13-rc1. I'm not going to include this in
gentoo-sources, because its non-critical and you can work around it quite easily:

If you have built agpgart into the kernel, boot with agp=try_unsupported
If its built as module, load it with parameter agp_try_unsupported=1

Thanks for the report.