Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 953887 - games-board/gnome-chess-46.0 fails to build with old version of libadwaita
Summary: games-board/gnome-chess-46.0 fails to build with old version of libadwaita
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-15 16:36 UTC by Ben
Modified: 2025-04-16 11:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben 2025-04-15 16:36:39 UTC
I have an old system with libadwaita-1.2 installed.  It appears to satisfy gnome-chess's libadwaita requirements in the ebuild, but appears an api change occurred and no longer satisfies the requirement.  I think gnome-chess-46 needs libadwaita-1.5 or newer.

usr/sbin/valac-0.56 -C --vapidir /var/tmp/portage/games-board/gnome-chess-46.0/work/gnome-chess-46.0/src --pkg config --pkg posix --pkg pangocairo --pkg librsvg-2.0 --pkg libadwaita-1 --pkg gtk4 --pkg gmodule-2.0 --target-glib 2.44.0 --pkg glib-2.0 --color=always --directory src/gnome-chess.p --basedir ../gnome-chess-46.0/src --gresources=../gnome-chess-46.0/data/chess.gresource.xml --gresourcesdir=data/../gnome-chess-46.0/data --target-glib=2.44.0 --gresources ../gnome-chess-46.0/data/chess.gresource.xml ../gnome-chess-46.0/src/chess-scene.vala ../gnome-chess-46.0/src/chess-view.vala ../gnome-chess-46.0/src/chess-window.vala ../gnome-chess-46.0/src/gnome-chess.vala ../gnome-chess-46.0/src/new-game-window.vala ../gnome-chess-46.0/src/preferences-window.vala ../gnome-chess-46.0/src/preferences.vala ../gnome-chess-46.0/src/promotion-type-selector-dialog.vala lib/libchess.vapi engine/libengine.vapi
../gnome-chess-46.0/src/gnome-chess.vala:972.13-972.49: error: The name `add_responses' does not exist in the context of `Adw.MessageDialog' (libadwaita-1)
  972 |             prompt_save_game_dialog.add_responses ("no", _("_Abandon Game"),
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                           
../gnome-chess-46.0/src/gnome-chess.vala:964.13-964.35: note: `prompt_save_game_dialog' was declared here
  964 |         var prompt_save_game_dialog = new Adw.MessageDialog (window,
      |             ^~~~~~~~~~~~~~~~~~~~~~~                                 

I think https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/migrating-to-adaptive-dialogs.html hints at the change, just need the rest of the system to catch up.

As far as I know right now, just an ebuild change needed - make gnome-chess's ebuild to require >=libadwaita-1.5

Will update when my machine finishes building libadwaita-1.6 as the dependency list forbids me from short circuiting the rebuild of libadwaita first to test my hypothesis.

Reproducible: Always

Steps to Reproduce:
1. have old libadwaita on system such as libadwaita-1.2
2. build gnome-chess-46
3.
Actual Results:  
build fails indicating error: The name `add_responses' does not exist

Expected Results:  
should build...
Comment 1 Mike Gilbert gentoo-dev 2025-04-15 19:31:31 UTC
Always attach the full build log and provide emerge --info when reporting build failures.

You can reopen this bug once that has been provided.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-04-16 11:09:13 UTC
It was changed upstream in https://gitlab.gnome.org/GNOME/gnome-chess/-/commit/a5ba7a2171e6e1132ccbd7fbbb24ce8e2e6d5b24 which is in 47 (and reflected in the ebuild) but I guess 46 needs that too.

In future, please always include the full build.log.
Comment 3 Larry the Git Cow gentoo-dev 2025-04-16 11:22:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cef0a0bfa942ef28c28c6c63456082325912f311

commit cef0a0bfa942ef28c28c6c63456082325912f311
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-04-16 11:10:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-04-16 11:22:17 +0000

    games-board/gnome-chess: depend on >=libadwaita-1.5 in 46.0
    
    Upstream commit 0378f849a5b23e6875a9aadbc403b32ddb4e9df9 started to use
    add_responses, then a5ba7a2171e6e1132ccbd7fbbb24ce8e2e6d5b24 raised
    the Meson requirement in 47.0, but the former change was in 46.0.
    
    Closes: https://bugs.gentoo.org/953887
    Signed-off-by: Sam James <sam@gentoo.org>

 games-board/gnome-chess/gnome-chess-46.0.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)