Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 952112 - media-libs/libyuv keywording
Summary: media-libs/libyuv keywording
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: NRK
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2025-03-26 20:14 UTC by Jakov Smolić
Modified: 2025-03-29 23:03 UTC (History)
4 users (show)

See Also:
Package list:
media-libs/libyuv alpha arm arm64 hppa loong mips ppc64 riscv sparc x86
Runtime testing required: ---
nattka: sanity-check+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakov Smolić archtester gentoo-dev 2025-03-26 20:14:57 UTC 
Any objections on keywording libyuv to match media-libs/libavif keywords and being able to drop arch-specific masks?
Comment 1 NRK 2025-03-26 20:25:47 UTC 
libyuv has a bunch of arch specific code, which can be a bit flaky. libavif has an internal patch for libyuv, debian also has some neon related patch:

https://github.com/AOMediaCodec/libavif/blob/main/ext/libyuv.patch
https://salsa.debian.org/debian/libyuv/-/blob/master/debian/patches/0004-CMakeLists.txt-Do-not-enable-NEON-for-armel-armhf.patch


And ATM the ebuild doesn't enable tests. For keywording, I think the following steps would be needed:

* Enable tests (shouldn't be hard, I hope)
* Run the tests on the specific arches
* Patch if needed (?)
Comment 2 Larry the Git Cow gentoo-dev 2025-03-27 17:11:37 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1b7bd031cd3da894c3adf5bf70536383fd08439

commit c1b7bd031cd3da894c3adf5bf70536383fd08439
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2025-03-26 21:22:51 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2025-03-27 17:10:28 +0000

    media-libs/libyuv: Enable tests
    
    Bug: https://bugs.gentoo.org/952112
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 media-libs/libyuv/libyuv-1904.ebuild | 15 ++++++++++-----
 media-libs/libyuv/libyuv-9999.ebuild | 15 ++++++++++-----
 2 files changed, 20 insertions(+), 10 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8af09c6a9ef722c17956ac428392170f205bff3c

commit 8af09c6a9ef722c17956ac428392170f205bff3c
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2025-03-27 16:53:21 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2025-03-27 17:10:27 +0000

    media-libs/libyuv: Update static lib patch
    
    The build system tries to link the test executable to the static library
    by default, but since we're not building, modify the patch to link it
    against the in-tree shared library
    
    Bug: https://bugs.gentoo.org/952112
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 .../libyuv/files/0002-disable-static-library.patch    | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)
Comment 3 Jakov Smolić archtester gentoo-dev 2025-03-29 17:44:39 UTC 
> 
> * Enable tests (shouldn't be hard, I hope)
> * Run the tests on the specific arches
> * Patch if needed (?)

Are we ok to proceed with testing?
Comment 4 NRK 2025-03-29 23:03:20 UTC 
> Are we ok to proceed with testing?

Yes, I think we can proceed.