Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 950252 - dev-libs/check-0.15.2-r1: removes static library breaking cmake config package file
Summary: dev-libs/check-0.15.2-r1: removes static library breaking cmake config packag...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Joonas Niilola
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 950956
  Show dependency tree
 
Reported: 2025-02-24 21:36 UTC by Alfred Wingate
Modified: 2025-03-09 08:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alfred Wingate 2025-02-24 21:36:11 UTC
The ebuild removes the static library after the fact breaking the generated cmake target Check::check.

https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/check/check-0.15.2-r1.ebuild?id=ad806778f682f6cd766327c653c460dc4534bf4e#n58

Output from a build system that tried to invoke `find_package ( CHECK 0.11.0 QUIET )`

CMake Error at /usr/lib64/cmake/check/check-targets.cmake:101 (message):
  The imported target "Check::check" references the file

     "/usr/lib64/libcheck.a"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "/usr/lib64/cmake/check/check-targets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  /usr/lib64/cmake/check/check-config.cmake:36 (include)
  tests/CMakeLists.txt:2 (find_package)


-- Configuring incomplete, errors occurred!

$ cat /usr/lib64/cmake/check/check-targets-gentoo.cmake 
#----------------------------------------------------------------
# Generated CMake target import file for configuration "Gentoo".
#----------------------------------------------------------------

# Commands may need to know the format version.
set(CMAKE_IMPORT_FILE_VERSION 1)

# Import target "Check::check" for configuration "Gentoo"
set_property(TARGET Check::check APPEND PROPERTY IMPORTED_CONFIGURATIONS GENTOO)
set_target_properties(Check::check PROPERTIES
  IMPORTED_LINK_INTERFACE_LANGUAGES_GENTOO "C"
  IMPORTED_LOCATION_GENTOO "${_IMPORT_PREFIX}/lib64/libcheck.a"
  )

list(APPEND _cmake_import_check_targets Check::check )
list(APPEND _cmake_import_check_files_for_Check::check "${_IMPORT_PREFIX}/lib64/libcheck.a" )

# Import target "Check::checkShared" for configuration "Gentoo"
set_property(TARGET Check::checkShared APPEND PROPERTY IMPORTED_CONFIGURATIONS GENTOO)
set_target_properties(Check::checkShared PROPERTIES
  IMPORTED_LOCATION_GENTOO "${_IMPORT_PREFIX}/lib64/libcheck.so.0.15.2"
  IMPORTED_SONAME_GENTOO "libcheck.so.0"
  )

list(APPEND _cmake_import_check_targets Check::checkShared )
list(APPEND _cmake_import_check_files_for_Check::checkShared "${_IMPORT_PREFIX}/lib64/libcheck.so.0.15.2" )

# Commands beyond this point should not need to know the version.
set(CMAKE_IMPORT_FILE_VERSION)
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-02-24 21:42:17 UTC
commit 6c5026b88f869f521d85d6a130982c2e92f63e75
Author: Joonas Niilola <juippis@gentoo.org>
Date:   Sat Mar 21 10:52:58 2020 +0200

    dev-libs/check: migrate to CMake, "fix" tests, revbump 0.14.0

    Bug: https://bugs.gentoo.org/711390
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Comment 2 Joonas Niilola gentoo-dev 2025-02-25 16:27:28 UTC
So uhh, check needs 'static-libs' use flag then?
Comment 3 Alfred Wingate 2025-02-25 16:30:00 UTC
Or they just get installed unconditionally without any use flags. Use flags should have a rhyme and reason and here the avoidance of static libs is causing more harm than good.
Comment 4 Larry the Git Cow gentoo-dev 2025-02-26 07:18:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6466f4c98c38a9ba61d857450068f6215e08c50

commit e6466f4c98c38a9ba61d857450068f6215e08c50
Author:     Alfred Wingate <parona@protonmail.com>
AuthorDate: 2025-02-25 17:14:02 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2025-02-26 07:14:47 +0000

    dev-libs/check: fix cmake package config files
    
    Stop removing require static libs.
    In the meanwhile bump eapi and remove other cruft.
    
    Bug: https://bugs.gentoo.org/950252
    Signed-off-by: Alfred Wingate <parona@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/40754
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/check/check-0.15.2-r2.ebuild | 53 +++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)
Comment 5 Andreas Sturmlechner gentoo-dev 2025-03-08 19:40:50 UTC
so, this is fixed?
Comment 6 Andreas Sturmlechner gentoo-dev 2025-03-09 08:54:42 UTC
... assuming so.