Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 949691 - dev-python/icalendar-6.1.1 fails tests with >=sys-libs/timezone-data-2024b
Summary: dev-python/icalendar-6.1.1 fails tests with >=sys-libs/timezone-data-2024b
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-13 04:18 UTC by Jonathan Lovelace
Modified: 2025-02-13 05:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-python:icalendar-6.1.1:20250213-040522.log.gz (dev-python:icalendar-6.1.1:20250213-040522.log.gz,93.43 KB, application/gzip)
2025-02-13 04:19 UTC, Jonathan Lovelace
Details
emerge-info.txt (emerge-info.txt,9.15 KB, text/plain)
2025-02-13 04:19 UTC, Jonathan Lovelace
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Lovelace 2025-02-13 04:18:18 UTC
=dev-python/icalendar-6.1.1 fails several tests for me; all the tests seem to be asserting that one time-zone name or another is in the list of names associated with a particular time-zone. I tried using https://github.com/collective/icalendar/pull/775 as a patch in /etc/portage/patches, and with it all but one or two of the tests passed, but I wasn't able to figure out how to get the remaining test or tests to pass---and its author describes it in https://github.com/collective/icalendar/issues/776 as a "PR to put a plaster over it without healing the root cause" anyway.
Comment 1 Jonathan Lovelace 2025-02-13 04:19:08 UTC
Created attachment 918865 [details]
dev-python:icalendar-6.1.1:20250213-040522.log.gz
Comment 2 Jonathan Lovelace 2025-02-13 04:19:31 UTC
Created attachment 918866 [details]
emerge-info.txt
Comment 3 Alfred Wingate 2025-02-13 05:52:48 UTC
Had a little bit of look around.

sys-libs/timezone-2024a-r1 no test failures
sys-libs/timezone-2024b test failures but addressed by upstream PR 775
sys-libs/timezone-2025a new test failures related to seemingly unrelated Asia/Manila historical timezone changes (this should get reported to upstream separately).


https://github.com/eggert/tz/commit/d4c65d53b9ff878291a0b103e0069f24628f6487 ???

Before:
>>> tzids_from_tzinfo(gettz("Asia/Manila"))
('Asia/Manila',)
After:
>>> tzids_from_tzinfo(gettz("Asia/Manila"))
('Antarctica/Casey', 'Asia/Brunei', 'Asia/Kuching', 'Asia/Makassar', 'Asia/Ujung_Pandang', 'Etc/GMT-8')


FAILED src/icalendar/tests/test_issue_722_generate_vtimezone.py::test_we_can_identify_dateutil_timezones[Asia/Manila] - AssertionError: assert 'Asia/Manila' in ('Asia/Brunei', 'Asia/Kuching', 'Asia/Makassar', 'Asia/Ujung_Pandang', 'Etc/GMT-8')
 +  where ('Asia/Brunei', 'Asia/Kuching', 'Asia/Makassar', 'Asia/Ujung_Pandang', 'Etc/GMT-8') = tzids_from_tzinfo(tzfile('/usr/share/zoneinfo/Asia/Manila'))
FAILED src/icalendar/tests/test_timezone_identification.py::test_can_identify_dateutil[Asia/Manila] - AssertionError: assert 'Asia/Manila' in ('Asia/Brunei', 'Asia/Kuching', 'Asia/Makassar', 'Asia/Ujung_Pandang', 'Etc/GMT-8')
 +  where ('Asia/Brunei', 'Asia/Kuching', 'Asia/Makassar', 'Asia/Ujung_Pandang', 'Etc/GMT-8') = tzids_from_tzinfo(tzfile('/usr/share/zoneinfo/Asia/Manila'))
 +    where tzfile('/usr/share/zoneinfo/Asia/Manila') = <dateutil.tz.tz.__get_gettz.<locals>.GettzFunc object at 0x7f8a0334cad0>('Asia/Manila')