Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 947019 - media-sound/gogglesmm: multiple dangling IUSE not wired up with any build system switches: aac, flac, mad, ogg, opus, pulseaudio, vorbis
Summary: media-sound/gogglesmm: multiple dangling IUSE not wired up with any build sys...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jason A. Donenfeld
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 890369 949038
  Show dependency tree
 
Reported: 2024-12-27 12:04 UTC by Andreas Sturmlechner
Modified: 2025-02-26 23:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2024-12-27 12:04:49 UTC
Jason, as the main contributor to that package, how are these supposed to work?
Comment 1 Andreas Sturmlechner gentoo-dev 2024-12-27 13:00:49 UTC
Traced back to 

commit be33c20e098539ecc50584787180db7c4ffc4045
Author: Jason A. Donenfeld <zx2c4@gentoo.org>
Date:   Wed Sep 21 02:59:10 2016 +0200

    media-sound/gogglesmm: initial commit
    
    Package-Manager: portage-2.3.1
Comment 2 Andreas Sturmlechner gentoo-dev 2024-12-27 13:09:22 UTC
src_configure() only contains:

> local mycmakeargs=(
> 	-DWITH_DBUS="$(usex dbus)"
> 	-DWITH_NLS="$(usex nls)"
> 	-DWITH_OPENGL="$(usex opengl)"
> 	-DWITH_CFOX=OFF
> )
Comment 3 Matt Turner gentoo-dev 2025-02-11 17:03:55 UTC
Looks totally broken to me, but there are CMake options for each in gap/CMakeLists.txt. Looks like they just need to be wired up in src_configure().

Other options I noticed:

- wav, default on, doesn't add any dependencies.
- matroska, default on, doesn't add any dependencies
- mp4, default on, doesn't add any dependencies
- tremor, default off, depends on media-libs/tremor
- alac, default on, doesn't add any dependencies
- a52, default off, depends on media-libs/a52dec
- dca, default off, depends on media-libs/libdca
Comment 4 Larry the Git Cow gentoo-dev 2025-02-26 23:46:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a34c0ed229fe93737f53da210d43cbdf4c306c4

commit 0a34c0ed229fe93737f53da210d43cbdf4c306c4
Author:     Nicolas PARLANT <nicolas.parlant@parhuet.fr>
AuthorDate: 2025-02-26 09:40:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-02-26 23:46:00 +0000

    media-sound/gogglesmm: add 1.2.5, update useflags/deps
    
    update HOMEPAGE
    
    useflags/deps:
    * add a52, media-libs/a52dec
    * add alsa, media-libs/alsa-lib
    * add dca, media-libs/libdca
    * add jack, virtual/jack
    * add libsamplerate, media-libs/libsamplerate. Detection with patch
    * add sndio, media-sound/sndio
    * add stream, sys-libs/zlib
                  dev-libs/libgcrypt (forced instead of openssl or gnutls)
    * add tremor, media-libs/tremor
    * rm ogg, definition forced (depless) and add libogg for opus, tremor, vorbis
    * nls, add dep virtual/libintl
    
    other deps:
    * >=x11-libs/fox-1.7.80
      Too much patches are needed to preserve compat with stable 1.7.67.
      Replacing in src/CMakeLists.txt is not enough (and requires also fullpath).
    * virtual/pkgconfig bdep
    * x11-base/xorg-proto dep
    * x11-libs/X11 rdep
    
    Closes: https://bugs.gentoo.org/890369
    Closes: https://bugs.gentoo.org/947019
    Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
    Closes: https://github.com/gentoo/gentoo/pull/40770
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-sound/gogglesmm/Manifest                     |   1 +
 .../files/gogglesmm-1.2.5-libsamplerate.patch      |  64 +++++++++++++
 media-sound/gogglesmm/gogglesmm-1.2.5.ebuild       | 102 +++++++++++++++++++++
 media-sound/gogglesmm/metadata.xml                 |   6 ++
 4 files changed, 173 insertions(+)