Bug 946652 – x11-base/xorg-server Xorg -configure segfaults when using the nvidia proprietary driver

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description stefan11111 2024-12-18 23:40:23 UTC]

Xorg -configure segfaults when the nvidia proprietary driver is installed.

here's the backtrace (patch are truncated a bit):

Program received signal SIGSEGV, Segmentation fault.                                                                                            
0x000055a27be87940 in xf86MatchDevice (drivername=0x7f3af3afa467 "NVIDIA", sectlist=0x7ffe7ae44a68) at ../xorg-server-21.1.14/hw/xfree86/common/??????????????????                                                          
warning: 1316   ../xorg-server-21.1.14/hw/xfree86/common/xf86Helper.c: No such file or directory                                                                                                        
(gdb) bt                                                                                                                                        
#0  0x000055a27be87940 in xf86MatchDevice (drivername=0x7f3af3afa467 "NVIDIA", sectlist=0x7ffe7ae44a68) at ../xorg-server-21.1.14/hw/xfree86/com??????????                                                          
#1  0x000055a27be996a6 in xf86PciProbeDev (drvp=0x55a2b5f35420) at ../xorg-server-21.1.14/hw/xfree86/common/xf86pciBus.c:489                    ??????????                                                          
#2  0x000055a27be71d32 in xf86CallDriverProbe (drv=0x55a2b5f35420, detect_only=detect_only@entry=0) at ../xorg-server-21.1.14/hw/xfree86/common/??????????                                                              
#3  0x000055a27be72425 in DoConfigure () at ../xorg-server-21.1.14/hw/xfree86/common/xf86Configure.c:721                                        ??????????                                                
#4  0x000055a27be7f4de in InitOutput (pScreenInfo=0x55a27bf54ee0 <screenInfo>, argc=2, argv=0x7ffe7ae45ce8) at ../xorg-server-21.1.14/hw/xfree86??????????                                                          
#5  0x000055a27bd81f4f in dix_main (argc=2, argv=0x7ffe7ae45ce8, envp=<optimized out>) at ../xorg-server-21.1.14/dix/main.c:190                 ??????????                                                  
#6  0x000055a27bed03c9 in main (argc=<optimized out>, argv=<optimized out>, envp=<optimized out>) at ../xorg-server-21.1.14/dix/stubmain.c:34 


Here's a patch that fixes it:

diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
index 0389945..98dc372 100644
--- a/hw/xfree86/common/xf86Helper.c
+++ b/hw/xfree86/common/xf86Helper.c
@@ -1313,7 +1313,8 @@ xf86MatchDevice(const char *drivername, GDevPtr ** sectlist)
      */
     for (j = 0; xf86ConfigLayout.screens[j].screen != NULL; j++) {
         screensecptr = xf86ConfigLayout.screens[j].screen;
-        if ((screensecptr->device->driver != NULL)
+        if ((screensecptr->device != NULL)
+            && (screensecptr->device->driver != NULL)
             && (xf86NameCmp(screensecptr->device->driver, drivername) == 0)
             && (!screensecptr->device->claimed)) {
             /*

[Comment 1 stefan11111 2024-12-18 23:40:38 UTC]

See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1767