Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 945979 - >=net-misc/sslh-2.1.0 Don't add -std=gnu99 to CFLAGS
Summary: >=net-misc/sslh-2.1.0 Don't add -std=gnu99 to CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-06 19:02 UTC by gen2dev
Modified: 2024-12-06 19:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gen2dev 2024-12-06 19:02:11 UTC
"-std=gnu99" was added to CFLAGS in the sslh-1.18 ebuild to fix bug 595426 and has been carried forward since.

That should be deleted for sslh >=2.1.0, because with 2.1.0 upstream moved to autoconf and the configure script checks for and requires at least C11.

I verified that the existing ebuilds sslh-2.1.1 and sslh-2.1.2 compile without errors or new warnings using gcc-14.2.1 and no "-std" flag or even with "-std=gnu23".


Reproducible: Always
Comment 1 Craig Andrews gentoo-dev 2024-12-06 19:12:23 UTC
Thank you!
Comment 2 Larry the Git Cow gentoo-dev 2024-12-06 19:14:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c99f8fc0fe8eb2bd38f949910252ddef0375af3c

commit c99f8fc0fe8eb2bd38f949910252ddef0375af3c
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2024-12-06 19:11:26 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2024-12-06 19:14:44 +0000

    net-misc/sslh: Don't add -std=gnu99 to CFLAGS
    
    Closes: https://bugs.gentoo.org/945979
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 net-misc/sslh/sslh-2.1.2-r1.ebuild | 76 ++++++++++++++++++++++++++++++++++++++
 net-misc/sslh/sslh-9999.ebuild     |  7 ----
 2 files changed, 76 insertions(+), 7 deletions(-)