Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 941499 - sys-kernel/linux-firmware-99999999: fails to merge when flag "deduplicate" is disabled
Summary: sys-kernel/linux-firmware-99999999: fails to merge when flag "deduplicate" is...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Chí-Thanh Christopher Nguyễn
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-14 03:04 UTC by Jerome C
Modified: 2024-10-17 10:27 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge info (log_emerge_info.txt,8.38 KB, text/plain)
2024-10-14 11:22 UTC, Jerome C
Details
emerge pqv (log_emerge_pqv.txt,418 bytes, text/plain)
2024-10-14 11:23 UTC, Jerome C
Details
cat /var/tmp/portage/sys-kernel/linux-firmware-99999999/temp/environment (log_environment.txt,155.81 KB, text/plain)
2024-10-14 11:24 UTC, Jerome C
Details
cat /var/tmp/portage/sys-kernel/linux-firmware-99999999/temp/build.log (log_build.log.txt,255.94 KB, text/plain)
2024-10-14 11:24 UTC, Jerome C
Details
build.log (build.log.txt,263.56 KB, text/plain)
2024-10-15 21:35 UTC, Jerome C
Details
emerge --info (emerge_info.txt,8.40 KB, text/plain)
2024-10-15 21:36 UTC, Jerome C
Details
emerge -pqv (emerge_pqv.txt,417 bytes, text/plain)
2024-10-15 21:36 UTC, Jerome C
Details
environment (environment.txt,155.95 KB, text/plain)
2024-10-15 21:37 UTC, Jerome C
Details
build log (build.log.txt,6.38 KB, text/plain)
2024-10-16 16:18 UTC, Jerome C
Details
emerge --info (emerge_info.txt,8.40 KB, text/plain)
2024-10-16 16:18 UTC, Jerome C
Details
emerge -pqv (emerge_pqv.txt,172 bytes, text/plain)
2024-10-16 16:18 UTC, Jerome C
Details
environment (environment.txt,155.97 KB, text/plain)
2024-10-16 16:19 UTC, Jerome C
Details
cat /etc/portage/savedconfig/sys-kernel/linux-firmware (linux-firmware,696 bytes, text/plain)
2024-10-16 16:46 UTC, Jerome C
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome C 2024-10-14 03:04:12 UTC
since commits

sys-kernel/linux-firmware: add python to makedeps, add separate dedup stage
https://gitweb.gentoo.org/repo/gentoo.git/commit/sys-kernel/linux-firmware?id=e67951813207a516a6f87a30d8fe631760fca592

sys-kernel/linux-firmware: Support python as build dep, include PR
https://gitweb.gentoo.org/repo/gentoo.git/commit/sys-kernel/linux-firmware?id=0f2e56e6dd7fbf07dadf78f9856e21d78bb05c69

this package fails to merge when "deduplicate" flag is enabled

emerge --info '=sys-kernel/linux-firmware-99999999::gentoo'
https://pastebin.com/DvEbSKye

emerge -pqv '=sys-kernel/linux-firmware-99999999::gentoo'
https://pastebin.com/rU3ukQCu

/var/tmp/portage/sys-kernel/linux-firmware-99999999/temp/environment
https://pastebin.com/cFagzjcD

/var/tmp/portage/sys-kernel/linux-firmware-99999999/temp/build.log
https://pastebin.com/KZGifN2k

with "deduplicate" flag disabled, merge is successful
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-14 03:09:16 UTC
Please always attach logs as pastebins expire and aren't always accessible behind firewalls.
Comment 2 Jerome C 2024-10-14 11:22:43 UTC
Created attachment 905785 [details]
emerge info

emerge --info '=sys-kernel/linux-firmware-99999999::gentoo'
Comment 3 Jerome C 2024-10-14 11:23:41 UTC
Created attachment 905786 [details]
emerge pqv

emerge -pqv '=sys-kernel/linux-firmware-99999999::gentoo'
Comment 4 Jerome C 2024-10-14 11:24:20 UTC
Created attachment 905787 [details]
cat /var/tmp/portage/sys-kernel/linux-firmware-99999999/temp/environment

cat /var/tmp/portage/sys-kernel/linux-firmware-99999999/temp/environment
Comment 5 Jerome C 2024-10-14 11:24:46 UTC
Created attachment 905788 [details]
cat /var/tmp/portage/sys-kernel/linux-firmware-99999999/temp/build.log

cat /var/tmp/portage/sys-kernel/linux-firmware-99999999/temp/build.log
Comment 6 Mike Pagano gentoo-dev 2024-10-14 21:57:21 UTC
Please test again
Comment 7 Jerome C 2024-10-15 21:35:23 UTC
It succeeds with "deduplicate" enabled but fails with it disabled
Comment 8 Jerome C 2024-10-15 21:35:58 UTC
Created attachment 905988 [details]
build.log

build.log
Comment 9 Jerome C 2024-10-15 21:36:22 UTC
Created attachment 905989 [details]
emerge --info

emerge --info
Comment 10 Jerome C 2024-10-15 21:36:51 UTC
Created attachment 905990 [details]
emerge -pqv

emerge -pqv
Comment 11 Jerome C 2024-10-15 21:37:18 UTC
Created attachment 905991 [details]
environment

environment
Comment 12 Jerome C 2024-10-16 08:49:43 UTC
After looking at both errors, I think I'm seeing a conflict with what I've reported.

I was meant to always say that when the "deduplicate" flag DISABLED that merge fails and when enabled it succeeds.

I just tried this with and without this commit

https://gitweb.gentoo.org/repo/gentoo.git/commit/sys-kernel/linux-firmware/linux-firmware-99999999.ebuild?id=fbe3f27fab932a93ac8b008ddb3648b0bde5258b

sorry
Comment 13 Larry the Git Cow gentoo-dev 2024-10-16 11:10:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f491c0b76355267c66954b1bdd5029903e68798

commit 2f491c0b76355267c66954b1bdd5029903e68798
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2024-10-16 11:10:27 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2024-10-16 11:10:27 +0000

    sys-kernel/linux-firmware: Update handling of deduplicate flaG
    
    Bug: https://bugs.gentoo.org/941499
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 sys-kernel/linux-firmware/linux-firmware-99999999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 14 Mike Pagano gentoo-dev 2024-10-16 11:11:22 UTC
(In reply to Larry the Git Cow from comment #13)
> The bug has been referenced in the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=2f491c0b76355267c66954b1bdd5029903e68798
> 
> commit 2f491c0b76355267c66954b1bdd5029903e68798
> Author:     Mike Pagano <mpagano@gentoo.org>
> AuthorDate: 2024-10-16 11:10:27 +0000
> Commit:     Mike Pagano <mpagano@gentoo.org>
> CommitDate: 2024-10-16 11:10:27 +0000
> 
>     sys-kernel/linux-firmware: Update handling of deduplicate flaG
>     
>     Bug: https://bugs.gentoo.org/941499
>     
>     Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> 
>  sys-kernel/linux-firmware/linux-firmware-99999999.ebuild | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please test once you sync.
Comment 15 Jerome C 2024-10-16 15:51:07 UTC
All good now

thanks
Comment 16 Jerome C 2024-10-16 16:05:48 UTC
sorry, no I take that back, there another issue now. Something about a file missing.

not sure why it worked after sync but then I disabled deduplicate, enabled savedconfig and that's when another error came, disabled savedconfig and the same error. I'll post logs soon
Comment 17 Jerome C 2024-10-16 16:18:05 UTC
Created attachment 906095 [details]
build log

build log
Comment 18 Jerome C 2024-10-16 16:18:22 UTC
Created attachment 906096 [details]
emerge --info

emerge --info
Comment 19 Jerome C 2024-10-16 16:18:45 UTC
Created attachment 906097 [details]
emerge -pqv

emerge -pqv
Comment 20 Jerome C 2024-10-16 16:19:17 UTC
Created attachment 906098 [details]
environment

environment
Comment 21 Jerome C 2024-10-16 16:46:20 UTC
Created attachment 906109 [details]
cat /etc/portage/savedconfig/sys-kernel/linux-firmware

cat /etc/portage/savedconfig/sys-kernel/linux-firmware

but this is only for when "savedconfig" flag is enabled
Comment 22 Larry the Git Cow gentoo-dev 2024-10-16 19:37:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6539d6f605eefeb29f37ff03ff31802645aefaf3

commit 6539d6f605eefeb29f37ff03ff31802645aefaf3
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2024-10-16 19:36:18 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2024-10-16 19:36:18 +0000

    sys-kernel/linux-firmware: changes due to new upstream script additions
    
    check_whence.py requires files to be there or it will die.
    Remove blobs with 'unknown' licenses after that script runs
    
    Bug: https://bugs.gentoo.org/941499
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 .../linux-firmware/linux-firmware-99999999.ebuild  | 79 +++++++++++-----------
 1 file changed, 41 insertions(+), 38 deletions(-)
Comment 23 Mike Pagano gentoo-dev 2024-10-16 19:38:33 UTC
(In reply to Jerome C from comment #21)
> Created attachment 906109 [details]
> cat /etc/portage/savedconfig/sys-kernel/linux-firmware
> 
> cat /etc/portage/savedconfig/sys-kernel/linux-firmware
> 
> but this is only for when "savedconfig" flag is enabled

Jerome,

You are a great example of bug writing, description, all errors and attached info.

Thanks for being an open source partner on this.

Can you re-sync and test, please ?
Comment 24 Jerome C 2024-10-17 02:25:42 UTC
I've tested it with the following use flags

"initramfs deduplicate -savedconfig"

"initramfs -deduplicate savedconfig"

and

"initramfs -deduplicate -savedconfig"

and also tested it again with a custom script and all is good

all 3 were successful

all is good I believe and good to hear I'm of help to open source

thanks Mike
Comment 25 Mike Pagano gentoo-dev 2024-10-17 10:27:09 UTC
Thanks for testing, closing this bug.