Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 940745 - gnome-base/gnome-control-center-46.4 fails to build
Summary: gnome-base/gnome-control-center-46.4 fails to build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2024-10-04 07:54 UTC by Özgür
Modified: 2024-10-17 12:37 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,564.50 KB, text/x-log)
2024-10-04 07:54 UTC, Özgür
Details
emerge --info output (emerge-info.txt,8.71 KB, text/plain)
2024-10-04 07:55 UTC, Özgür
Details
environment (environment,140.44 KB, text/plain)
2024-10-04 07:56 UTC, Özgür
Details
Re-add krb_dep only if kerberos is enabled and found (krb.patch,905 bytes, patch)
2024-10-10 08:51 UTC, Bernd Feige
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Özgür 2024-10-04 07:54:32 UTC
Created attachment 904894 [details]
build log

gnome-control center fails to build during the upgrade 
ebuild     U ] gnome-base/gnome-control-center-46.4 [46.2] USE="bluetooth cups geolocation gnome-online-accounts ibus kerberos networkmanager systemd wayland -debug (-elogind) -test" INPUT_DEVICES="-wacom"
Comment 1 Özgür 2024-10-04 07:55:38 UTC
Created attachment 904895 [details]
emerge --info output
Comment 2 Özgür 2024-10-04 07:56:08 UTC
Created attachment 904896 [details]
environment
Comment 3 Leonid Kopylov 2024-10-04 14:04:59 UTC
have same error
Comment 4 Lionel MANNONE 2024-10-05 15:41:16 UTC
Same here, it compiles fine without the kerberos USE flag, it's a problem within the library /usr/lib64/libkrb5.so.3.
no time to fix it for the moment.
Comment 5 Hanspeter Spalinger 2024-10-06 17:10:13 UTC
(In reply to Lionel MANNONE from comment #4)
> Same here, it compiles fine without the kerberos USE flag, it's a problem
> within the library /usr/lib64/libkrb5.so.3.
> no time to fix it for the moment.

No, its a problem with the patch in 0002-build-Make-kerberos-optional.patch which remove kerberos library from the control center build.
Comment 6 Hanspeter Spalinger 2024-10-06 17:28:45 UTC
(In reply to Hanspeter Spalinger from comment #5)
> (In reply to Lionel MANNONE from comment #4)
> > Same here, it compiles fine without the kerberos USE flag, it's a problem
> > within the library /usr/lib64/libkrb5.so.3.
> > no time to fix it for the moment.
> 
> No, its a problem with the patch in 0002-build-Make-kerberos-optional.patch
> which remove kerberos library from the control center build.

I think the patch should look like this (relevant part only):
@@ -104,7 +104,6 @@

 # Kerberos support
 krb_dep = dependency('krb5', required: false)
-assert(krb_dep.found(), 'kerberos libraries not found in your path')

 deps = common_deps + [
   accounts_dep,

which still checks for the kerberos library, but does not fail if its not found.

The above is untested on systems without kerberos; i checked it on my system with kerberos where it works.
Comment 7 Bernd Feige 2024-10-10 08:50:29 UTC
(In reply to Hanspeter Spalinger from comment #6)
> (In reply to Hanspeter Spalinger from comment #5)

> I think the patch should look like this (relevant part only):
> @@ -104,7 +104,6 @@

Thanks for the suggestion! I see two removed assert() calls however (in panels/system/users/meson.build and panels/system/meson.build), and actually the krb_dep definition was moved up into meson.build and made "required" if the "kerberos" option is given, so this seems fine.

Here, gnome-control-center +kerberos compiles if only krb_dep is re-added to deps in panels/system/meson.build where it was (I think erroneously) removed.

I attach a patch which adds it conditionally, defining enable_kerberos in meson.build for that.
Comment 8 Bernd Feige 2024-10-10 08:51:35 UTC
Created attachment 905146 [details, diff]
Re-add krb_dep only if kerberos is enabled and found
Comment 9 Hanspeter Spalinger 2024-10-12 18:04:14 UTC
(In reply to Bernd Feige from comment #8)
> Created attachment 905146 [details, diff] [details, diff]
> Re-add krb_dep only if kerberos is enabled and found

works on my kerberized system.
Comment 10 Larry the Git Cow gentoo-dev 2024-10-17 12:37:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7ac89d5f624dc8b13553b4e323c2972cc063a10

commit d7ac89d5f624dc8b13553b4e323c2972cc063a10
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2024-10-17 12:29:46 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2024-10-17 12:29:49 +0000

    gnome-base/gnome-control-center: fix kerberos patch
    
    Thanks-to: Özgür
    Thanks-to: Hanspeter Spalinger
    Thanks-to: Bernd Feige
    Closes: https://bugs.gentoo.org/940745
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 gnome-base/gnome-control-center/Manifest                         | 2 +-
 gnome-base/gnome-control-center/gnome-control-center-46.4.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)