Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 940445 - sys-boot/woeusb-ng require dev-python/wxpython dep
Summary: sys-boot/woeusb-ng require dev-python/wxpython dep
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: GURU project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-28 16:07 UTC by coruja56
Modified: 2024-10-01 17:27 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description coruja56 2024-09-28 16:07:22 UTC
sys-boot/woeusb-ng GUI does not work after emerge. 
ERROR = "ModuleNotFoundError: No module named 'wx'". 
Only work after emerge dev-python/wxpython.
Comment 1 Takuya Wakazono 2024-09-29 09:14:03 UTC
That's already described as an optfeature. You should see a message telling you to install dev-python/wxpython:4.0 if you want GUI support.

 * Install additional packages for optional runtime features:
 *   dev-python/wxpython:4.0 for GUI support
 *   sys-boot/grub[grub_platforms_pc] for Legacy PC bootmode support
Comment 2 Jack 2024-09-30 17:17:21 UTC
Would it make sense to add a "gui" USE flag to optionally require wxpython?
Comment 3 Takuya Wakazono 2024-10-01 00:25:46 UTC
I don't think so. We generally don't use USE flags to control optional runtime dependencies.
Either add it as an optfeature or make it a mandatory dependency for everyone (and the committer chose the former).

We can make it a non-optional dependency if users prefer.
Comment 4 Jack 2024-10-01 00:45:28 UTC
Perhaps it's just terminology, but yes, I would prefet it be called an optfeature controlled by a USE flag.  For me, that better tracks why it's installed, so if I uninstall woeusb then wxpython can get depcleaned.  I would guess then it would be an RDEPEND, as I understand things.

Perhaps this bug can be changed to a wishlist to do that?  I guess that is up to the OP and whoever is supporting the package.
Comment 5 Larry the Git Cow gentoo-dev 2024-10-01 14:58:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=02d263c79f5993d0be50f3fb14c705ccc66cf372

commit 02d263c79f5993d0be50f3fb14c705ccc66cf372
Author:     Takuya Wakazono <pastalian46@gmail.com>
AuthorDate: 2024-10-01 11:18:00 +0000
Commit:     Takuya Wakazono <pastalian46@gmail.com>
CommitDate: 2024-10-01 11:18:00 +0000

    sys-boot/woeusb-ng: add USE=gui
    
    Add a gui USE flag instead of using optfeature for two reasons:
    
    - Broken PYTHON_COMPAT (no maintainer, optfeature is easy to miss)
    - Some desktop profile users consider gui a core feature, and they don't
      expect the woeusbgui script to be non-functional
    
    Closes: https://bugs.gentoo.org/940445
    Signed-off-by: Takuya Wakazono <pastalian46@gmail.com>

 sys-boot/woeusb-ng/woeusb-ng-0.2.12.ebuild | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)
Comment 6 Jack 2024-10-01 17:27:14 UTC
Thank you.