Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 93815 - /etc/init.d/xdm - cosmetic changes in stop() section
Summary: /etc/init.d/xdm - cosmetic changes in stop() section
Status: RESOLVED DUPLICATE of bug 24399
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-24 09:08 UTC by ishino
Modified: 2005-05-24 11:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ishino 2005-05-24 09:08:04 UTC
There is a minor bug in the stop()-section of the xdm init script, that produces
an error message when rebooting the system complaining about not being able to
stop the gdm service (maybe xdm/kdm/others too, but I haven't checked). In my
case  gdm apparently is already gone when the script checks for the process and
thus passes 1 to eend, which results in the error message described above. The
whole purpose of the stop()-section is to kill the gdm process. Therefore I
think it's safe to assume that the service has been stopped if the process
doesn't even exist (this does not affect the behaviour of the script if it
encounters any problems stopping an existing gdm process). The trivial patch to
fix this issue:

--- /etc/init.d/xdm.old 2005-05-24 17:46:22.000000000 +0200
+++ /etc/init.d/xdm     2005-05-24 17:30:20.000000000 +0200
@@ -106,7 +106,7 @@
                
                retval=$?
        else
-               retval=1
+               retval=0
        fi
        
        #switch back to original vt



Reproducible: Always
Steps to Reproduce:
1. Reboot/Shutdown


Actual Results:  
The xdm-script complains about not being able to stop gdm (although it is
already gone, hence stopped).

Expected Results:  
No error messages.
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2005-05-24 10:18:20 UTC
Remember to search for duplicates.

*** This bug has been marked as a duplicate of 24399 ***
Comment 2 ishino 2005-05-24 11:50:07 UTC
(In reply to comment #1)
> Remember to search for duplicates.

I did, but apparently with wrong keywords. Sorry about that.