Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935806 - net-libs/nodejs-22.4.1: does not respect --load-average
Summary: net-libs/nodejs-22.4.1: does not respect --load-average
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: makeopts-ignored
  Show dependency tree
 
Reported: 2024-07-10 04:24 UTC by Michał Górny
Modified: 2024-07-18 16:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-07-10 04:24:47 UTC 
From the process tree:

make -j12 -l13 -Onone
-> ninja -C out/Release -j12 -v


i.e. upstream's build system is apparently passing -j through but ignoring -l, effectively causing major contention on a busy system.
Comment 1 Larry the Git Cow gentoo-dev 2024-07-18 16:38:32 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=305e66472660ee50117267b499f23d3883340deb

commit 305e66472660ee50117267b499f23d3883340deb
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2024-07-18 16:35:52 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2024-07-18 16:38:22 +0000

    net-libs/nodejs: use get_NINJAOPTS
    
    Before this change, -l or --load-average was not respected by the
    upstream build system.
    
    Closes: https://bugs.gentoo.org/935806
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 net-libs/nodejs/nodejs-20.15.1.ebuild | 3 ++-
 net-libs/nodejs/nodejs-22.4.1.ebuild  | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)