Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 93546 - mplayerplug-in crashes firefox
Summary: mplayerplug-in crashes firefox
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High critical (vote)
Assignee: Mozilla Gentoo Team
URL: http://www.flamingmailbox.com/maccome...
Whiteboard:
Keywords:
Depends on: 100809
Blocks:
  Show dependency tree
 
Reported: 2005-05-22 06:23 UTC by Federico Ferri (RETIRED)
Modified: 2005-09-29 00:10 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for mplayerplug-in 3.05 (mplayerplug-in-3.05.ebuild,2.24 KB, text/plain)
2005-08-11 18:24 UTC, Manuel McLure
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Federico Ferri (RETIRED) gentoo-dev 2005-05-22 06:23:04 UTC
i'm using:
net-www/mplayerplug-in-2.66
www-client/mozilla-firefox-1.0.4

when watching embedded movies in webpages, playback is quite fine.
but when you leave the page (by clicking back, or clicking another link) firefox
crashes. (try the attached url)

Reproducible: Always
Steps to Reproduce:
1.start firefox
2.open the url
3.watch the movie (or at least let the movie begin)
4.leave the page (click on another link)
Actual Results:  
firefox crashes

Expected Results:  
forefox that doesn't crashes :|
Comment 1 Federico Ferri (RETIRED) gentoo-dev 2005-05-22 06:23:34 UTC
this bug is similar, but NOT THE SAME as bug 93272
Comment 2 Jory A. Pratt 2005-05-22 07:33:04 UTC
if you would please test latest version of mplayerplug-in. I am working to get
it marked stable sometime today. This is version 2.80 that I am suggesting you test.
Comment 3 Federico Ferri (RETIRED) gentoo-dev 2005-05-22 08:42:24 UTC
sorry, even with mplayerplug-in-2.80, firefox crashes, in the same way (as soon
as you leave the page with mplayer....)

i suspect that this is a firefox bug, because (if i don't remember bad) with
earlier version of firefox this didn't happen ("only" lockups were the usual habit)

HTH
Comment 4 Dan 2005-05-23 16:01:59 UTC
I can confirm this behavior.  Here's my info:

Portage 2.0.51.22-r1 (default-linux/x86/2005.0, gcc-3.3.1,
glibc-2.3.4.20041102-r0, 2.6.9-gentoo-r9 i686)
=================================================================
System uname: 2.6.9-gentoo-r9 i686 Intel(R) Pentium(R) 4 CPU 2.80GHz
Gentoo Base System version 1.5.3
dev-lang/python:     2.2.3-r1, 2.3.4
sys-apps/sandbox:    1.2.1-r1
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.8.5-r1, 1.9.4
sys-devel/binutils:  2.14.90.0.8-r1
sys-devel/libtool:   1.5.10-r4
virtual/os-headers:  2.6.8.1
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium3 -O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=pentium3 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sfperms strict"
GENTOO_MIRRORS="ftp://mirrors.tds.net/gentoo
ftp://ftp.ussg.iu.edu/pub/linux/gentoo http://mirrors.tds.net/gentoo
ftp://gentoo.netnitco.net/pub/mirrors/gentoo/source/"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="x86 X aalib acpi alsa apm avi berkdb bitmap-fonts bonobo cdr clamav crypt
cups curl directfb dvd dvdr dvdread eds emboss encode esd fam fbcon flac
foomaticdb fortran gdbm gif gimpprint gmp gnome gphoto2 gpm gstreamer gtk gtk2
gtkhtml guile imagemagick imlib ipv6 java jpeg junit kdeenablefinal kqemu ldap
libg++ libwww mad mikmod motif mozilla mp3 mpeg mysql ncurses network nls nptl
oav ogg oggvorbis openal opengl oss pam pdflib perl png ppds python qt quicktime
readline samba scanner sdl slang softmmu speex spell ssl svga tcltk tcpd tiff
truetype truetype-fonts type1-fonts usb vorbis xine xml xml2 xmms xv xvid zlib
userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, MAKEOPTS
Comment 5 Federico Ferri (RETIRED) gentoo-dev 2005-05-25 09:53:28 UTC
today i discovered this:

if you leave one instance of mplayerplug-in running, you can view other clips
normally, and you can close and open others, without crashing firefox.
firefox only crashes when you close the last instance of mplayerplug-in.

reproducibility:
1.open firefox
2.find some funny clips :)
3.watch one of them, but don't leave the page when playback finishes
4.open a new tab (or a new window)
5.find more funny clips
6.watch them
7.you can close these new tabs/windows or leave the page: no crash happens
8.close the last instance of mplayerplug-in
9.crash!

please could someone confirm this behavior?
Comment 6 Dan 2005-05-25 20:06:47 UTC
That is exactly what I get here.  I am using mplayerplug-in 2.80.

Comment 7 Robert Swift 2005-05-29 07:01:36 UTC
I was having a very similar problem. Actually it was just like bug 93272, but I
already had mplayerplug-in 2.80 installed.  

Re-emerging mplayerplug-in did nothing, but when I removed it and then
reinstalled it, the error was fixed and the mplayerplug-in background came up
with a new logo.  

The strange thing is, while mplayerplug-in was uninstalled, I tried playing a
movie in firefox (v. 1.0.4), and it brought up the old mplayerplug-in logo and
locked up.

xaero, before uninstalling I tried your trick of leaving a tab with
mplayerplug-in open.  It didn't work for me.  Still locked up.
Comment 8 Federico Ferri (RETIRED) gentoo-dev 2005-05-29 08:22:31 UTC
i suspect this is (also) a bug in firefox's handling of plugins.
try this sequence:

1.start firefox
2.open a page with a movie (w/ mplayerplug-in)
3.when the movie finishes, open a new tab
4.open a page with flashplayer-plugin
5.you can close the previous tab with the only one instance of mplayerplug-in,
and no crash occours.
6.now close the tab with flashplayer-plugin: CRASH!
Comment 9 Luca Barbato gentoo-dev 2005-05-29 10:54:32 UTC
I can't reproduce the issue with mplayerplug-in, I do have more issues with the
flash plugin on x86
Comment 10 Rich 2005-06-01 22:03:43 UTC
Duplicated here, Firefox 1.0.4, mplayerplug-in 2.80.

I had that problem in 2.66...I opened a page, the plugin loaded and played the
file, then Firefox closed when I closed the tab.

Now, I upgraded to 2.80, on the advice of this thread. NOTHING plays in
mplayerplug-in (just a blank grey area where the box would normally be), and
Firefox closes when I close the tab.
Comment 11 Rich 2005-06-01 22:10:57 UTC
Interesting.

Building mplayerplug-in-2.80 with -gtk2 yields a nonfunctional plugin, for me.
It does nothing except embed a grey window in the page (and not play anything
within it), and then closes Firefox when I close the tab.

+gtk2 fixes the nonfunctionality, but Firefox still closes when I close the tab
it's in.

Nobody has any ideas?
Comment 12 Rich 2005-06-01 22:18:44 UTC
I found a solution!

1) CLOSE ALL FIREFOX OR MOZILLA OR NETSCAPE OR WHATEVER WINDOWS. I don't care
what it is, if it uses Firefox to render HTML, close it.
2) emerge -C mplayerplug-in
3) Open a Firefox/Mozilla/whatever window.
4) Close that window.
5) emerge mplayerplug-in
6) See if it works now.

It worked for me.
Comment 13 Luca Barbato gentoo-dev 2005-06-02 00:47:15 UTC
Looks like that is a mozilla issue afterall (probably upstream)

If you have a browser instance open and you update that could lead to
corruption/missing update in the xpi files.

Comment 14 Robert Swift 2005-06-11 05:18:25 UTC
Rich, that worked for me too _until_ I restarted KDE.  

I finally got it fixed by running "emerge -C mplayerplug-in" and then doing a
"grep -Ir mplayerplug-in" from my home directory.  I deleted 2 files, sorry I
didn't write down the details before I did, but 1 was in .mozilla/plugins and
the other was in .kde3.3/share/applnk/.hidden.  Both started with
"mplayerplug-in."  

I _suspect_ the file in the .kde3.3 directory because the problem only came back
after restarting KDE.  I also deleted some mplayerplug-in files under /var and
/usr, but I don't think they were responsible.  Again, I'm sorry I didn't record
everything I did.

One side note is that before I deleted these files, mplayerplug-in still played
in firefox even when it was uninstalled.  I'm guessing that a cached copy of
version 2.66 was still hanging around.  After I deleted the files, firefox no
longer tried to play videos.
Comment 15 Robert Swift 2005-06-11 05:23:36 UTC
Oops!  It wasn't "grep -Ir mplayerplug-in," it was "find -name 'mplayerplug-in*'
... don't know what I was thinking.  /blush
Comment 16 Kevin DeKorte 2005-06-15 10:26:19 UTC
mplayerplug-in 2.85 is out. Does the same problem happen with it?
Comment 17 Fabio Rossi 2005-06-21 03:42:18 UTC
No problem here, firefox-1.0.4 and mplayerplug-in-2.85

Portage 2.0.51.19 (default-linux/x86/2005.0, gcc-3.3.5-20050130,
glibc-2.3.4.20041102-r1, 2.6.11-gentoo-r11 i686)
=================================================================
System uname: 2.6.11-gentoo-r11 i686 AMD Athlon(tm) Processor
Gentoo Base System version 1.6.12
Python:              dev-lang/python-2.3.5 [2.3.5 (#1, Jun  9 2005, 16:49:56)]
dev-lang/python:     2.3.5
sys-apps/sandbox:    [Not Present]
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.5
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.16
virtual/os-headers:  2.6.8.1-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=athlon-tbird -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/OpenOffice.org/share/dict/ooo /usr/kde/2/share/config
/usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown
/usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=athlon-tbird -fomit-frame-pointer -pipe"
DISTDIR="/mnt/lfs/distfiles/"
FEATURES="autoaddcvs autoconfig ccache distlocks keeptemp keepwork sandbox
sfperms strict"
GENTOO_MIRRORS="                
http://www.die.unipd.it/pub/Linux/distributions/gentoo-sources/                
http://ftp.students.cs.unibo.it/gentoo/  "
LANG="it_IT"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/portage-mydev"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 3dnow 3dnowext X aac acl alsa apache2 arts audiofile avi
bash-completion berkdb bitmap-fonts blas boehm-gc bonobo bzip2 cddb cdparanoia
cdr chroot cmucl crypt cups curl directfb divx4linux doc dv dvb emboss encode
ethereal examples faac faad fam fbcon ffmpeg fftw flac foomaticdb fortran fpx
gcj gd gdbm gif gimpprint gmp gnutls gphoto2 gpm graphviz gtk gtk2 gtkhtml guile
imagemagick imlib innodb java jbig jpeg jpeg2k kde kdeenablefinal lcms libg++
libwww live lzo mad mikmod mime mjpeg mmx mmxext motif mozdevelop mozsvg
mozxmlterm mp3 mpeg mysql ncurses network nls nntp nptl ogg oggvorbis opengl oss
pam pdflib perl plotutils png postgres ppds python qt quicktime readline real
samba sdk sdl skey smime speex spell ssl stats tcltk tcpd tetex theora threads
tiff truetype truetype-fonts type1 type1-fonts unicode userlocales vorbis wifi
win32codecs wmf wxgtk1 wxwindows xanim xine xml xml2 xmms xv xvid yv12 zlib
video_cards_radeon userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CBUILD, CTARGET, LC_ALL, LDFLAGS, LINGUAS
Comment 18 Manuel McLure 2005-07-10 19:27:17 UTC
Still happens for me on Firefox 1.0.4 & mplayerplug-in 2.85.
Comment 19 Joe Jezak (RETIRED) gentoo-dev 2005-07-12 13:02:27 UTC
The next version of mplayerplug-in, due out soon, should fix some more firefox
crashes.
Comment 20 Kevin DeKorte 2005-07-21 14:10:50 UTC
mplayerplug-in 3.01 is out now. Can you please try that.

http://prdownloads.sourceforge.net/mplayerplug-in/mplayerplug-in-3.01.tar.gz?download

It should fix the crashes.
Comment 21 Rick Harris 2005-07-22 20:50:12 UTC
mozilla-firefox-1.0.4 is no longer in portage 
 
No such issues with mplayerplug-in-2.80 or mplayerplug-in-2.85 & 
mozilla-firefox-1.0.5-r1 or mozilla-firefox-1.0.6-r1 
 
 
 
 
Comment 22 Manuel McLure 2005-07-22 21:19:10 UTC
I tried 3.01 (with a custom ebuild) against Firefox
1.0.5-r1/gecko-sdk-1.7.8/mplayer-1.0_pre7 (by making a custom ebuild) and it has
the exact same problem. Tested with a video from www.cobaltflux.com - select the
video, it comes up and plays completely, then hit Back on the browser and it
will shortly die.
Comment 23 Kevin DeKorte 2005-07-23 06:12:11 UTC
Apply a patch like this to plugin.cpp in mplayerplug-in 3.01

I'm working on another feature and I am not ready to commit it to CVS yet.

diff -u -r1.207 plugin.cpp
--- Source/plugin.cpp   22 Jul 2005 17:34:21 -0000      1.207
+++ Source/plugin.cpp   23 Jul 2005 13:08:27 -0000
@@ -366,91 +366,22 @@

 #ifdef GTK2_ENABLED            // When disabled probably causes a GTK memory
leak, but stops weird crash and warnings
     if (controlwindow == 0) {
-       if (panel_drawn == 1) {
-           if (GTK_IS_WIDGET(play_event_box))
-               if (GTK_IS_WIDGET(play_event_box))
-                   gtk_widget_destroy(play_event_box);
-           if (GTK_IS_WIDGET(pause_event_box))
-               gtk_widget_destroy(pause_event_box);
-           if (GTK_IS_WIDGET(stop_event_box))
-               gtk_widget_destroy(stop_event_box);
-           if (mmsstream == 0) {
-               if (GTK_IS_WIDGET(ff_event_box))
-                   gtk_widget_destroy(ff_event_box);
-               if (GTK_IS_WIDGET(rew_event_box))
-                   gtk_widget_destroy(rew_event_box);
-           }
-           if (GTK_IS_WIDGET(mediaprogress_bar))
-               gtk_widget_destroy(GTK_WIDGET(mediaprogress_bar));
-           if (GTK_IS_WIDGET(progress_bar))
-               gtk_widget_destroy(GTK_WIDGET(progress_bar));
-           mediaprogress_bar = NULL;
-           progress_bar = NULL;
-           panel_drawn = 0;
-       }
-       if (mode == NP_EMBED) {
-           if (player_window != 0 && noembed == 0) {
-               if (GTK_IS_WIDGET(drawing_area))
-                   gtk_widget_destroy(drawing_area);
-               player_window = 0;
-           }
-       }
-       if (embed_height > 125)
-           if (GTK_IS_WIDGET(image))
-               gtk_widget_destroy(image);
-
-       if (GTK_IS_WIDGET(fs_event_box))
-           gtk_widget_destroy(fs_event_box);
-
-       if (GTK_IS_WIDGET(popup_menu)) {
-           gtk_widget_destroy(GTK_WIDGET(menuitem_play));
-           gtk_widget_destroy(GTK_WIDGET(menuitem_pause));
-           gtk_widget_destroy(GTK_WIDGET(menuitem_stop));
-           gtk_widget_destroy(GTK_WIDGET(menuitem_sep1));
-           gtk_widget_destroy(GTK_WIDGET(menuitem_sep2));
-           gtk_widget_destroy(GTK_WIDGET(menuitem_showcontrols));
-           gtk_widget_destroy(GTK_WIDGET(menuitem_fullscreen));
-           gtk_widget_destroy(GTK_WIDGET(menuitem_copy));
-           gtk_widget_destroy(GTK_WIDGET(menuitem_save));
-           gtk_widget_destroy(GTK_WIDGET(popup_menu));
-       }

        if (GTK_IS_WIDGET(gtkwidget))
            gtk_widget_destroy(gtkwidget);
     }
 #endif
Comment 24 Sebastian Krämer 2005-07-25 04:47:38 UTC
I just installed mplayerplug-in-2.8.5 (which compiled gecko-sdk too) after I
emerged mozilla-firefox-bin-1.0.6-r1 earlier today. Two tests did work just fine
(tv news on http://www.zdf.de and http://www.tagesschau.de with wmv codec).
In particular, closing tabs were no problem! Also, fullscreen worked and the
buttons worked, so overall performance was quite good (much better from what I
was used to when I last used the plugin months ago).
The only thing I noticed 'til now is that in the latter case (tagesschau.de),
the size of the plugin region didn't fit the video size (it was cut at the right
so that the seekbar was partly hidden, as well as the fullscreen button).
Maybe it's of interest that I'm using mplayer from cvs; I prevented emerge to
install mplayer by creating a package.provided file, so maybe these issues have
something to do with a particular mplayer version?
My system is x86 and I used gcc-3.3.5-20050130 and glibc-2.3.5 (if you want any
more info, just ask; I just thought a complete `emerge info` would spam the
bugtracker db unnecessarily ;) )
Comment 25 Sebastian Krämer 2005-07-25 05:04:57 UTC
Although version 2.85 fixes the issues for me so far, I gave Kevin's suggestion
(to try version 3.01) a shot. I dumped the ebuild for mplayerplug-in-2.85 to
portage overlay and mplayerplug-in-3.01 compiled fine. However, the tests I
tried before didn't work. I'm only getting a grey area and no stream is loaded
(it's not hidden, there really is no traffic).

Since the INSTALL seemed to be the same file in both versions, I didn't expect
any problems. However, since it doesn't seem to work right out of the box, I
downgraded to 2.85.
Comment 26 Kevin DeKorte 2005-07-25 06:57:42 UTC
Sebastian,

Sounds like you have a widget set mismatch. If you firefox is compiled with
GTK1, you need to compile mplayerplug-in with GTK1. To do that use the
'--enable-gtk1' switch with the ./configure command. This is equivalent to
having the 'use gtk2' flag not set.
Comment 27 Manuel McLure 2005-07-25 10:20:53 UTC
Kevin, was that patch supposed to stop the crashing? I tried adding it to my
custom ebuild and it seems to have had absolutely no effect. My browser still
crashes when I do a Back after watching a video.
Comment 28 Kevin DeKorte 2005-07-25 10:44:06 UTC
Manual,

Can you grab the mplayerplug-in CVS and see if that does not crash? Also, do you
know if you are using GTK1 or GTK2 widgets?
Comment 29 Sebastian Krämer 2005-07-26 06:32:57 UTC
(In reply to comment #26)
> Sebastian,
> 
> Sounds like you have a widget set mismatch. If you firefox is compiled with
> GTK1, you need to compile mplayerplug-in with GTK1. To do that use the
> '--enable-gtk1' switch with the ./configure command. This is equivalent to
> having the 'use gtk2' flag not set.

Hm, I used the binary package for firefox and didn't find any info on if it was
compiled with gtk1 or gtk2 (I assumed that gtk2 was used). mplayerplug-in was
compiled with gtk2 (from my USE).

I removed the binary package and installed firefox-1.0.6-r2 from source
(certainly with gtk2), re-emerged mplayerplug-in-2.85. It doesn't seem to make
any difference, sorry :(
But I'm mostly fine with it. I'm glad that it's working at all, and for most
purposes, I use fullscreen which doesn't have that issue.

Comment 30 Manuel McLure 2005-07-26 09:52:43 UTC
Kevin, I tried CVS, same problem. mplayerplug-in is built with GTK+ 2, I'm
pretty sure that firefox is built with it as well since the mozconfig eclass
depends on gtk+-2.2.0 or higher (there seems to be no way to turn off gtk2 in
the firefox ebuild.)

Anything I can run to help debug this?

The video I'm testing with is

    http://www.cobaltflux.com/media/CF-SuperStar.mov
Comment 31 Sebastian Krämer 2005-07-26 11:04:25 UTC
(In reply to comment #30)

> The video I'm testing with is
> 
>     http://www.cobaltflux.com/media/CF-SuperStar.mov

Just a notice, it's working fine for me (letting play completely, then press
'Back' to return to this bug page). Are you still trying with firefox-1.0.4? As
I noted before, I'm using the 1.0.6-r2 source.

Comment 32 Manuel McLure 2005-07-26 14:01:11 UTC
I'm using mozilla-firefox-1.0.6-r2 and gecko-sdk-1.7.8, both built from source
ebuilds.
Comment 33 Kevin DeKorte 2005-08-06 06:33:02 UTC
mplayerplug-in 3.05 has been released. Can you please test that.
Comment 34 Manuel McLure 2005-08-11 18:23:30 UTC
3.05 seems to work! Yay! I have attached my 3.05 ebuild for people to test.
Comment 35 Manuel McLure 2005-08-11 18:24:45 UTC
Created attachment 65713 [details]
Ebuild for mplayerplug-in 3.05
Comment 36 Nir Dremer 2005-08-15 09:56:03 UTC
3.05 (ebuild + patch taken from bug #100809) works good for me.
Comment 37 Joe Jezak (RETIRED) gentoo-dev 2005-09-25 18:38:31 UTC
Should be fixed with 3.11, so depends on bug #100809
Comment 38 Joe Jezak (RETIRED) gentoo-dev 2005-09-29 00:10:47 UTC
3.11 has been added to portage, feel free to reopen if you're still having a
problem.