Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935012 - dev-libs/kdsingleapplication[qt6] should be able to build without qt5
Summary: dev-libs/kdsingleapplication[qt6] should be able to build without qt5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 935416 933172
  Show dependency tree
 
Reported: 2024-06-27 10:57 UTC by Radu Benea
Modified: 2024-07-26 13:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Radu Benea 2024-06-27 10:57:06 UTC
I suggest adding a qt5 flag to the ebuild and putting the dependencies behind the flag, you can default it to on to keep backwards compatibility.

I hard masked qt5 on my system and was not able to build this project until I manually nuked all the qt5 references from it. It seems to build just fine with only qt6 enabled

Reproducible: Always
Comment 1 Andreas Sturmlechner gentoo-dev 2024-06-27 17:00:06 UTC
It should not have any Qt choice at all, should be qt6 only.
Comment 2 Bernard Cafarelli gentoo-dev 2024-06-27 19:34:01 UTC
Indeed, we discussed that topic asturm weeks ago. Steps to do here:
* drop qt5 part and make it qt6-only
* bump the rev deps after qt5 is removed
* pkgmove to dev-libs - I added it in dev-qt to go alongside qtsingleapplication but it is not a project from Qt framework directly
Comment 3 Larry the Git Cow gentoo-dev 2024-07-25 20:05:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d2f5bad0da9a837935bc1bac1bc10daf15b19b2

commit 8d2f5bad0da9a837935bc1bac1bc10daf15b19b2
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-07-22 19:16:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-07-25 20:04:12 +0000

    dev-libs/kdsingleapplication: drop 1.1.0
    
    Closes: https://bugs.gentoo.org/935012
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../kdsingleapplication-1.1.0.ebuild               | 96 ----------------------
 1 file changed, 96 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2ba8aef245ea39c2a5f7437de78ff1be5a1854a4

commit 2ba8aef245ea39c2a5f7437de78ff1be5a1854a4
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-07-22 18:46:52 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-07-25 20:04:11 +0000

    dev-libs/kdsingleapplication: Drop IUSE qt6 (dropping qt5 "option")
    
    - Fix IUSE doc, examples
    - Use qmake-utils to set QHELPGEN_EXECUTABLE
    - Simplify src_install(), cmake_src_install calls einstalldocs
    - Do not use rm -f (we want to know when sth. breaks)
    - Arrayify HTML_DOCS and make local
    
    Bug: https://bugs.gentoo.org/935012
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../kdsingleapplication-1.1.0-r1.ebuild            | 55 ++++++++++++++++++++++
 1 file changed, 55 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=62acc19089781ee966ba603806cd838d29a9f403

commit 62acc19089781ee966ba603806cd838d29a9f403
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-07-22 18:43:00 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-07-25 20:04:11 +0000

    dev-qt/kdsingleapplication: pkgmove to dev-libs/kdsingleapplication
    
    Bug: https://bugs.gentoo.org/935012
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 {dev-qt => dev-libs}/kdsingleapplication/Manifest                     | 0
 .../kdsingleapplication/kdsingleapplication-1.1.0.ebuild              | 0
 {dev-qt => dev-libs}/kdsingleapplication/metadata.xml                 | 0
 media-sound/strawberry/strawberry-1.0.23-r2.ebuild                    | 4 ++--
 net-misc/owncloud-client/owncloud-client-5.2.1.13040-r1.ebuild        | 2 +-
 profiles/updates/3Q-2024                                              | 1 +
 6 files changed, 4 insertions(+), 3 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=440f30ac5183db2dd54305087010830b88901101

commit 440f30ac5183db2dd54305087010830b88901101
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-07-22 18:30:58 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-07-25 20:04:10 +0000

    net-misc/owncloud-client: Prepare for dev-libs/kdsingleapplication
    
    It will drop IUSE qt6.
    
    Bug: https://bugs.gentoo.org/935012
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 ...-client-5.2.1.13040.ebuild => owncloud-client-5.2.1.13040-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)