Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934767 - net-irc/kvirc: Please review use of +phonon (audio can always be provided via dev-qt/qtmultimedia:5)
Summary: net-irc/kvirc: Please review use of +phonon (audio can always be provided via...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alexey
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-06-23 10:40 UTC by Andreas Sturmlechner
Modified: 2024-10-13 14:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2024-06-23 10:40:21 UTC
Upstream build system has:

> # this is a no-op - not nice i know, but real no point in making it optional...
> if(Qt${QT_VERSION_MAJOR}Multimedia_FOUND)
>	list(APPEND CMAKE_STATUS_AUDIO_BACKENDS "Qt${QT_VERSION_MAJOR}Multimedia")
> endif()

We (and KDE upstream) are trying to get away from media-libs/phonon, this is one of the few external packages depending on in by default, while IUSE=kde is actually off by default - does that still make sense? Seems it only adds an additional audio backend anyway.

Background: cutting down on ~ppc revdeps.
Comment 1 Alexey 2024-07-24 09:15:01 UTC
I think it should be fine to remove it.

One issue I discovered while testing the removal is that while loading existing config, it changes the backend to "null" rather than "qt", which means after the update sound will be gone. Probably need to fix that first
Comment 2 Alexey 2024-08-02 12:20:43 UTC
We can get rid of the phonon dependency in the next version of kvirc
Comment 3 Larry the Git Cow gentoo-dev 2024-09-04 14:55:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=84425ef89603d72cfe36d1ed9528a6d64dc11f4c

commit 84425ef89603d72cfe36d1ed9528a6d64dc11f4c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-06-23 19:25:51 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-09-04 14:52:39 +0000

    profiles: ppc32: Mask media-libs/phonon revdeps in package.use.mask
    
    Bug: https://bugs.gentoo.org/934762
    Bug: https://bugs.gentoo.org/934767
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/arch/powerpc/ppc32/package.use.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2024-09-05 04:08:37 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9de78f1e6fb0e31bb0c93fd0fa9d0b306901fcff

commit 9de78f1e6fb0e31bb0c93fd0fa9d0b306901fcff
Author:     Alexey Sokolov <alexey+gentoo@asokolov.org>
AuthorDate: 2024-09-04 16:13:00 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-09-05 04:07:46 +0000

    net-irc/kvirc: switch 9999 to qt6
    
    drop USE=dcc-video,phonon
    
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Bug: https://bugs.gentoo.org/934767
    Closes: https://github.com/gentoo/gentoo/pull/38435
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 net-irc/kvirc/kvirc-9999.ebuild | 47 ++++++++++++++++++-----------------------
 1 file changed, 21 insertions(+), 26 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2024-10-13 14:00:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6777dce8ca9a8a3bc417fc42b2d559a942c84d4c

commit 6777dce8ca9a8a3bc417fc42b2d559a942c84d4c
Author:     Alexey Sokolov <alexey+gentoo@asokolov.org>
AuthorDate: 2024-10-13 00:03:27 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-10-13 13:59:58 +0000

    net-irc/kvirc: add 5.2.6
    
    Bug: https://bugs.gentoo.org/936931
    Closes: https://bugs.gentoo.org/934767
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Closes: https://github.com/gentoo/gentoo/pull/38964
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 net-irc/kvirc/Manifest           |   1 +
 net-irc/kvirc/kvirc-5.2.6.ebuild | 151 +++++++++++++++++++++++++++++++++++++++
 net-irc/kvirc/kvirc-9999.ebuild  |  30 ++++----
 3 files changed, 166 insertions(+), 16 deletions(-)