Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934751 - media-sound/sidplayfp-2.7.0: requires mpg123 output plugins for playback, but missing from RDEPEND
Summary: media-sound/sidplayfp-2.7.0: requires mpg123 output plugins for playback, but...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-23 00:39 UTC by conflictvegetable
Modified: 2024-07-10 11:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info,6.62 KB, text/plain)
2024-06-23 00:39 UTC, conflictvegetable
Details

Note You need to log in before you can comment on or make changes to this bug.
Description conflictvegetable 2024-06-23 00:39:12 UTC
Created attachment 896272 [details]
emerge --info

media-sound/sidplayfp (2.7.0, but I see no reason why later versions shouldn't also be affected) searches for mpg123 output plugins at runtime to play back audio, but the ebuild does not have mpg123-output-plugins in RDEPEND, which causes it to be unexpectedly silent. Output to WAV (-w) or AU (--au) works fine.

Additionally, it is possible to emerge sidplayfp with USE '-alsa -oss -pulseaudio', with mpg123 output plugins installed, and it plays sound just fine. 

Testing note: sidplayfp requires SID files to work. I suggest grabbing a copy of the High Voltage SID Collection, unpacking it, and running 'sidplayfp <path to a SID>'. Any SID in that collection should work fine, but I tested with MUSICIANS/T/Tjelta_Geir/Echoes.sid.

Trimmed strace without media-plugins/mpg123-output-plugins installed:

openat(AT_FDCWD, "/usr/lib64/mpg123/output_pulse.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/usr/lib64/mpg123/output_alsa.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/usr/lib64/mpg123/output_sdl.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/usr/lib64/mpg123/output_dummy.so", O_RDONLY|O_CLOEXEC) = 3

The program is silent in this case.

With:

newfstatat(AT_FDCWD, "/usr/lib64/mpg123", {st_mode=S_IFDIR|0755, st_size=4096, ...}, 0) = 0
openat(AT_FDCWD, "/usr/lib64/mpg123/output_pulse.so", O_RDONLY|O_CLOEXEC) = 3

The program plays back music.
Comment 1 Miroslav Šulc gentoo-dev 2024-07-10 10:54:46 UTC
thanks for the report and analysis!
Comment 2 Larry the Git Cow gentoo-dev 2024-07-10 10:55:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a241d02156cbe71669f7ed6ed53276b8f6edac1b

commit a241d02156cbe71669f7ed6ed53276b8f6edac1b
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2024-07-10 10:54:57 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-07-10 10:55:08 +0000

    media-sound/sidplayfp: added missing dep
    
    Closes: https://bugs.gentoo.org/934751
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/sidplayfp/sidplayfp-2.7.0.ebuild | 1 +
 media-sound/sidplayfp/sidplayfp-2.8.0.ebuild | 1 +
 2 files changed, 2 insertions(+)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-10 10:56:30 UTC
I think it's an RDEPEND, not DEPEND, and needs a revbump then.
Comment 4 Miroslav Šulc gentoo-dev 2024-07-10 11:01:02 UTC
(In reply to Sam James from comment #3)
> I think it's an RDEPEND, not DEPEND, and needs a revbump then.

oh thanks, will fix it
Comment 5 Larry the Git Cow gentoo-dev 2024-07-10 11:04:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d0ae69b7a8852c8ee5b9668404b1556011d29055

commit d0ae69b7a8852c8ee5b9668404b1556011d29055
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2024-07-10 11:04:22 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-07-10 11:04:22 +0000

    media-sound/sidplayfp: fixed the deps
    
    Bug: https://bugs.gentoo.org/934751
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../{sidplayfp-2.7.0.ebuild => sidplayfp-2.7.0-r1.ebuild}   | 13 +++++++++----
 .../{sidplayfp-2.8.0.ebuild => sidplayfp-2.8.0-r1.ebuild}   | 13 +++++++++----
 2 files changed, 18 insertions(+), 8 deletions(-)