Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934462 - dev-qt/qt-creator ebuild ignores MAKEOPTS
Summary: dev-qt/qt-creator ebuild ignores MAKEOPTS
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: makeopts-ignored
  Show dependency tree
 
Reported: 2024-06-17 13:53 UTC by Eugene Shalygin
Modified: 2024-07-03 04:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Shalygin 2024-06-17 13:53:28 UTC
The build runs with the maximal jobs ignoring what MAKEOPTS is set to.

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2024-06-18 16:24:25 UTC
Can't reproduce at a glance, I have MAKEOPTS=-j6 and while building qt-creator there was 6 compilation jobs:

    $ pgrep cc1plus | wc -l
    6

Not impossible there's a subtask that uses more jobs for a moment, albeit as long as the memory-heavy compilation jobs are respected I doubt I'll look at these even if it exists.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-06-18 16:26:18 UTC
Maybe bug 928346 if any externalproject use as a complete guess.
Comment 3 Ionen Wolkens gentoo-dev 2024-06-18 16:57:09 UTC
(In reply to Sam James from comment #2)
> Maybe bug 928346 if any externalproject use as a complete guess.
Ah, unverified but it's possible the bundled syntax-highlighting:6 did that for a rather small part of the build:

    src/libs/3rdparty/syntax-highlighting/src/indexer/CMakeLists.txt:    include(ExternalProject)

Formerly kept bundled given it needs slot 6, but I guess there's not much blocking that anymore with the mask gone and could try using system's next bump. Well, it would require stabling it alongside kf-env-6:6 and extra-cmake-modules-6.3.0 though, kind of minor but maybe unwanted yet.

If seen makeopts not respected for a big part of the build rather than just syntax-highlighting there may be something else going on. Otherwise figure I'll close this when it's unbundled.
Comment 4 Larry the Git Cow gentoo-dev 2024-06-18 18:14:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8e24128704e3f80016f4e7686be8aedfe31a8fa

commit e8e24128704e3f80016f4e7686be8aedfe31a8fa
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2024-06-18 17:00:00 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2024-06-18 18:13:52 +0000

    dev-qt/qt-creator: update syntax-highlighting comment
    
    Bug: https://bugs.gentoo.org/934462
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 dev-qt/qt-creator/qt-creator-13.0.1.ebuild | 2 +-
 dev-qt/qt-creator/qt-creator-13.0.2.ebuild | 2 +-
 dev-qt/qt-creator/qt-creator-9999.ebuild   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Comment 5 Eugene Shalygin 2024-07-02 07:10:05 UTC
Seems to be OK now, thank you!
Comment 6 Ionen Wolkens gentoo-dev 2024-07-02 09:16:22 UTC
It is? I didn't change anything yet beside a comment.
Comment 7 Ionen Wolkens gentoo-dev 2024-07-02 09:20:41 UTC
Either way I assume something else was going on here, the syntax-highlighting bit is too minor to be noticeable unless doing some automatic usage tracking.
Comment 8 Eugene Shalygin 2024-07-02 09:21:37 UTC
I checked again and now it only spawns unlimited moc processes, but the number of C++ compile processes follows the limit.
Comment 9 Eugene Shalygin 2024-07-02 09:36:59 UTC
Ha-ha, it did it again:
$ pgrep cc1plus | wc -l                                                                                                                                     131

But only for a minute and not for the whole build. Looking up the build processes showed it was compiling various plugins at that time.
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-03 01:24:43 UTC
When staring at CMake's testsuite, I noticed https://cmake.org/cmake/help/latest/variable/CMAKE_AUTOGEN_PARALLEL.html we could try.
Comment 11 Ionen Wolkens gentoo-dev 2024-07-03 04:02:22 UTC
(In reply to Eugene Shalygin from comment #9)
> Ha-ha, it did it again:
> $ pgrep cc1plus | wc -l                                                     
> 131
> 
> But only for a minute and not for the whole build. Looking up the build
> processes showed it was compiling various plugins at that time.
Did figure it'd be something momentary albeit that doesn't sound like syntax-highlighting. Shame qt-creator's cmake usage is wrapped in so many functions (+ qtbase's) that it's hard to track what's going on. Think it may even be *generating* cmake files.

I feel like it, you could try the variable sam mentioned by doing:

   MYCMAKEARGS="-DCMAKE_AUTOGEN_PARALLEL=1" emerge ...

Replace '1' by amount of jobs you want, and see if it helps either for either moc or the plugins

(In reply to Sam James from comment #10)
> When staring at CMake's testsuite, I noticed
> https://cmake.org/cmake/help/latest/variable/CMAKE_AUTOGEN_PARALLEL.html we
> could try.
Interesting, albeit *if* it needs to be set to respect makeopts (would be nice if cmake told us what being unset implies) there's likely little value in doing this in qt-creator ebuild vs cmake.eclass as it's likely affecting a lot of packages.

Anyhow, re-opening given there's likely something to figure out here.