Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934173 - net-misc/sunshine with net-libs/miniupnpc-2.2.8 error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’
Summary: net-misc/sunshine with net-libs/miniupnpc-2.2.8 error: too few arguments to f...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 2 votes (vote)
Assignee: James Le Cuirot
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-13 02:17 UTC by Weikai Kong
Modified: 2024-06-23 15:46 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log from emerge (build.log,309.55 KB, application/octet-stream)
2024-06-13 02:17 UTC, Weikai Kong
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Weikai Kong 2024-06-13 02:17:17 UTC
Created attachment 895719 [details]
build log from emerge

/var/tmp/portage/net-misc/sunshine-0.23.1/work/Sunshine-0.23.1/src/upnp.cpp: In member function ‘bool upnp::deinit_t::create_ipv6_pinholes()’:
/var/tmp/portage/net-misc/sunshine-0.23.1/work/Sunshine-0.23.1/src/upnp.cpp:112:37: error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’
  112 |       auto status = UPNP_GetValidIGD(device.get(), &urls.el, &data, lan_addr.data(), lan_addr.size());
      |                     ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/tmp/portage/net-misc/sunshine-0.23.1/work/Sunshine-0.23.1/src/upnp.cpp:5:
/usr/include/miniupnpc/miniupnpc.h:122:1: note: declared here
  122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
      | ^~~~~~~~~~~~~~~~
/var/tmp/portage/net-misc/sunshine-0.23.1/work/Sunshine-0.23.1/src/upnp.cpp: In member function ‘void upnp::deinit_t::upnp_thread_proc()’:
/var/tmp/portage/net-misc/sunshine-0.23.1/work/Sunshine-0.23.1/src/upnp.cpp:334:39: error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’
  334 |         auto status = UPNP_GetValidIGD(device.get(), &urls.el, &data, lan_addr.data(), lan_addr.size());
      |                       ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/miniupnpc/miniupnpc.h:122:1: note: declared here
  122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
      | ^~~~~~~~~~~~~~~~
/var/tmp/portage/net-misc/sunshine-0.23.1/work/Sunshine-0.23.1/src/upnp.cpp: At global scope:
/var/tmp/portage/net-misc/sunshine-0.23.1/work/Sunshine-0.23.1/src/upnp.cpp:47:3: warning: ‘std::string_view upnp::status_string(int)’ defined but not used [-Wunused-function]
   47 |   status_string(int status) {
      |   ^~~~~~~~~~~~~
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-06-13 02:18:01 UTC
This is actually net-libs/miniupnpc-2.2.8, I think.
Comment 2 Weikai Kong 2024-06-13 20:21:46 UTC
https://github.com/miniupnp/miniupnp/commit/c0a50ce33e3b99ce8a96fd43049bb5b53ffac62f

yeah looks like sunshine should align with this or require <= 2.2.7
Comment 3 Marcin Deranek 2024-06-13 21:36:25 UTC
The same goes for games-strategy/0ad.
Comment 4 Larry the Git Cow gentoo-dev 2024-06-23 15:46:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09eb59d7880d5a499b3890def7989f532715fefe

commit 09eb59d7880d5a499b3890def7989f532715fefe
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2024-06-23 15:45:38 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2024-06-23 15:46:17 +0000

    net-misc/sunshine: Fix 0.23.1 with newer miniupnpc using patch
    
    Closes: https://bugs.gentoo.org/934173
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 net-misc/sunshine/files/sunshine-miniupnpc.patch | 43 ++++++++++++++++++++++++
 net-misc/sunshine/sunshine-0.23.1.ebuild         |  1 +
 2 files changed, 44 insertions(+)