Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 933592 - [guru] games-strategy/gigalomania-1.0.1 does not respect CFLAGS
Summary: [guru] games-strategy/gigalomania-1.0.1 does not respect CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Vitaly Zdanevich
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2024-06-05 06:49 UTC by Agostino Sarubbo
Modified: 2024-07-17 08:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,53.88 KB, text/plain)
2024-06-05 06:49 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-06-05 06:49:00 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-strategy/gigalomania-1.0.1 does not respect CFLAGS.
Discovered on: amd64 (internal ref: guru_ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0017
Comment 1 Agostino Sarubbo gentoo-dev 2024-06-05 06:49:01 UTC
Created attachment 895108 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2024-07-17 08:40:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=96d99c5656ca40fbdb3a4970130cdfe4f9d6e69a

commit 96d99c5656ca40fbdb3a4970130cdfe4f9d6e69a
Author:     Vitaly Zdanevich <zdanevich.vitaly@ya.ru>
AuthorDate: 2024-07-16 07:36:59 +0000
Commit:     Vitaly Zdanevich <zdanevich.vitaly@ya.ru>
CommitDate: 2024-07-16 07:36:59 +0000

    games-strategy/gigalomania: CCFLAGS from hardcode in Makefile
    
    Closes: https://bugs.gentoo.org/933592
    Signed-off-by: Vitaly Zdanevich <zdanevich.vitaly@ya.ru>

 games-strategy/gigalomania/files/Makefile.patch    | 35 ++++++++++++++++++++++
 .../gigalomania/gigalomania-1.0.1.ebuild           | 10 +++++++
 2 files changed, 45 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=96efefb928a718e465e9ece30e4ddd439553e77d

commit 96efefb928a718e465e9ece30e4ddd439553e77d
Author:     Lucio Sauer <watermanpaint@posteo.net>
AuthorDate: 2024-07-16 23:08:43 +0000
Commit:     Lucio Sauer <watermanpaint@posteo.net>
CommitDate: 2024-07-17 01:13:16 +0000

    games-strategy/gigalomania: pass CXXFLAGS instead of CFLAGS to make
    
    This is a cpp program.
    
    Bug: https://bugs.gentoo.org/933592
    Fixes: 96d99c5656ca40fbdb3a4970130cdfe4f9d6e69a
    Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>

 games-strategy/gigalomania/gigalomania-1.0.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)