Bug 933203 – games-emulation/dolphin-5.0_p20220520-r2 fails to compile: IOFile.h:109:18: error: argument 1 null where non-null expected [-Werror=nonnull]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2024-05-30 17:08:57 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-emulation/dolphin-5.0_p20220520-r2 fails to compile.
Discovered on: amd64 (internal ref: gcc14_tinderbox)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014

[Comment 1 Agostino Sarubbo 2024-05-30 17:08:59 UTC]

Created attachment 894666 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2024-05-30 17:08:59 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


-- Could NOT find OpenSLES (missing: OPENSLES_LIBRARY OPENSLES_INCLUDE_DIR) 
-- Could NOT find SYSTEMD (missing: SYSTEMD_LIBRARIES SYSTEMD_INCLUDE_DIRS) 
-- libsystemd not found, disabling traversal server watchdog support
FAILED: Source/Core/Common/CMakeFiles/common.dir/IOFile.cpp.o 
fatal: not a git repository (or any parent up to mount point /var/tmp)
/var/tmp/portage/games-emulation/dolphin-5.0_p20220520-r2/work/dolphin-0f2540a0d1133950467845f20b1e003181147781/Source/Core/Common/IOFile.h:109:18: error: argument 1 null where non-null expected [-Werror=nonnull]

[Comment 3 Kostadin Shishmanov 2024-06-02 14:53:58 UTC]

Upstream PR that should fix the issue: https://github.com/dolphin-emu/dolphin/pull/12575

[Comment 4 Michał Górny 2024-06-02 15:44:20 UTC]

Thanks!

[Comment 5 Michał Górny 2024-06-02 16:09:01 UTC]

Actually, I can't reproduce.

[Comment 6 Kostadin Shishmanov 2024-06-02 16:16:30 UTC]

(In reply to Michał Górny from comment #5)
> Actually, I can't reproduce.

I also couldn't with -O2 but with -O3 it fails.

[Comment 7 Larry the Git Cow 2024-06-02 17:54:11 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1e3866a781cb9f13107b17d346ce03fcbc09e10c

commit 1e3866a781cb9f13107b17d346ce03fcbc09e10c
Author:     Michał Górny <[e-mail]>
AuthorDate: 2024-06-02 17:50:39 +0000
Commit:     Michał Górny <[e-mail]>
CommitDate: 2024-06-02 17:54:06 +0000

    games-emulation/dolphin: Backport gcc-14 build fix
    
    Thanks to Kostadin Shishmanov for finding the pull request.
    
    Closes: https://bugs.gentoo.org/933203
    Signed-off-by: Michał Górny <[e-mail]>

 .../dolphin/dolphin-5.0_p20220520-r2.ebuild        |  6 ++++-
 .../files/dolphin-5.0_p20220520-gcc-14.patch       | 30 ++++++++++++++++++++++
 2 files changed, 35 insertions(+), 1 deletion(-)