/var/tmp/portage/net-misc/freerdp-2.11.7/work/freerdp-2.11.7/client/X11/xf_graphics.c: In function ‘xf_Pointer_New’: /var/tmp/portage/net-misc/freerdp-2.11.7/work/freerdp-2.11.7/client/X11/xf_graphics.c:441:57: error: pointer/integer type mismatch in conditional expression [-Wint-conversion] 441 | WLog_DBG(TAG, "%s: %ld", __func__, rc ? pointer : -1); | ^ /var/tmp/portage/net-misc/freerdp-2.11.7/work/freerdp-2.11.7/winpr/include/winpr/wlog.h:125:57: note: in definition of macro ‘WLog_Print’ 125 | __FUNCTION__, __VA_ARGS__); \ | ^~~~~~~~~~~ /var/tmp/portage/net-misc/freerdp-2.11.7/work/freerdp-2.11.7/winpr/include/winpr/wlog.h:180:28: note: in expansion of macro ‘WLog_Print_tag’ 180 | #define WLog_DBG(tag, ...) WLog_Print_tag(tag, WLOG_DEBUG, __VA_ARGS__) | ^~~~~~~~~~~~~~ /var/tmp/portage/net-misc/freerdp-2.11.7/work/freerdp-2.11.7/client/X11/xf_graphics.c:441:9: note: in expansion of macro ‘WLog_DBG’ 441 | WLog_DBG(TAG, "%s: %ld", __func__, rc ? pointer : -1); | ^~~~~~~~ Reproducible: Always
Created attachment 893704 [details, diff] patch
Please add the full build log. as per https://github.com/FreeRDP/FreeRDP/issues/10177#issuecomment-2106000889 please make a PR upstream. Since this is an oldstable, the best is inject -Wno-int-conversion as done for incompatible-pointer-types here: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=60fc3847889e2aec2dad46dfe47f078a294c3ed8
*** Bug 932461 has been marked as a duplicate of this bug. ***
Created attachment 893848 [details] build log
Upstream replaces -1 with NULL, so my patch is not the best. https://github.com/FreeRDP/FreeRDP/blob/6ebb0889d9f30809afd1ca8ab429be2dcc2425b8/client/X11/xf_graphics.c#L324 in this rather large commit: https://github.com/FreeRDP/FreeRDP/commit/641022b7953bb04e80b5058cd07149d0cf454aee#diff-314ce19398de31e2d44ca1f4e7152f1437079a78ec3c82bcd11c7b18c81dc40eL458
Thanks for looking into this, I sent a patch upstream.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=836bf3fddd54b483b4a68a0ac7b2ec2a2b3d0805 commit 836bf3fddd54b483b4a68a0ac7b2ec2a2b3d0805 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2024-05-22 17:31:07 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2024-05-22 17:33:24 +0000 net-misc/freerdp: fix pointer/integer type mismatch Closes: https://bugs.gentoo.org/932407 Signed-off-by: Mike Gilbert <floppym@gentoo.org> .../files/freerdp-2.11.7-type-mismatch.patch | 24 ++++++++++++++++++++++ net-misc/freerdp/freerdp-2.11.7.ebuild | 1 + 2 files changed, 25 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6343c03ccd88138d77e8c6fb644440e71133272b commit 6343c03ccd88138d77e8c6fb644440e71133272b Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2024-05-22 21:10:07 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2024-05-22 21:10:07 +0000 net-misc/freerdp: fix patch Bug: https://bugs.gentoo.org/932407 Signed-off-by: Mike Gilbert <floppym@gentoo.org> net-misc/freerdp/files/freerdp-2.11.7-type-mismatch.patch | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
