Bug 932091 – dev-vcs/git-2.44.1: git-daemon cannot export repository when running as user nobody (default)

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description Manuel Mommertz 2024-05-17 11:49:07 UTC]

With git version 2.43.4/2.44.1, when trying to access a repository, that is exported via git-daemon running as nobody (default setup), the access failed and git-daemon logs:

git-daemon[6237]: detected dubious ownership in repository at 'xxx.git'
To add an exception for this directory, call:

        git config --global --add safe.directory xxx.git

The suggested solution is no solution, as the user nobody has no home directory to store the global git config in the first place.

Any idea how to get git-daemon running again?

Reproducible: Always

[Comment 1 Sam James 2024-05-17 11:58:07 UTC]

https://lore.kernel.org/git/[e-mail]/ has some discussion.

[Comment 2 Sam James 2024-05-23 23:54:36 UTC]

Please see https://lore.kernel.org/git/xmqqr0dss2qe.fsf@gitster.g/T/#u, specifically:
"""
We unfortunately had serious regressions in 2.45.1 (and below, down
to 2.39 maintenance track are affected), and we are trying to assess
the extent of damage and which changes that went into the release to
revert.  We know about "git lfs" and "git annex" getting affected.
If your workflow is affected, you would want to try out 'seen' that
has proposed reverts to alleviate and report back to us, to make sure
that the next set of maintenance releases will fix the regressions
for you.
"""

[Comment 3 Andy Getz 2024-05-30 03:47:21 UTC]

I was able to work around this by adding the relevant directories to the system config at /etc/gitconfig:

[safe]
        directory = /where/ever
        directory = /et/cetera

[Comment 4 Larry the Git Cow 2024-06-01 00:50:01 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6defb79fbea21f783706928f913c8e724b132a6d

commit 6defb79fbea21f783706928f913c8e724b132a6d
Author:     Sam James <[e-mail]>
AuthorDate: 2024-06-01 00:48:08 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-06-01 00:49:40 +0000

    dev-vcs/git: add 2.45.2
    
    Bug: https://bugs.gentoo.org/932091
    Signed-off-by: Sam James <[e-mail]>

 dev-vcs/git/Manifest          |   3 +
 dev-vcs/git/git-2.45.2.ebuild | 646 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 649 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47ddae0dc0351da70ea31b85b17c8caea4cb8daf

commit 47ddae0dc0351da70ea31b85b17c8caea4cb8daf
Author:     Sam James <[e-mail]>
AuthorDate: 2024-06-01 00:41:44 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-06-01 00:49:39 +0000

    dev-vcs/git: add 2.44.2
    
    Bug: https://bugs.gentoo.org/932091
    Signed-off-by: Sam James <[e-mail]>

 dev-vcs/git/Manifest          |   3 +
 dev-vcs/git/git-2.44.2.ebuild | 647 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 650 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e62524d60b3a79db79111ef029ced357d0661d8e

commit e62524d60b3a79db79111ef029ced357d0661d8e
Author:     Sam James <[e-mail]>
AuthorDate: 2024-06-01 00:33:41 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-06-01 00:49:39 +0000

    dev-vcs/git: add 2.43.5
    
    Bug: https://bugs.gentoo.org/932091
    Signed-off-by: Sam James <[e-mail]>

 dev-vcs/git/Manifest          |   3 +
 dev-vcs/git/git-2.43.5.ebuild | 644 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 647 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6b463d4a95ca0d515aec571f2d8aaa642be0b18

commit f6b463d4a95ca0d515aec571f2d8aaa642be0b18
Author:     Sam James <[e-mail]>
AuthorDate: 2024-06-01 00:27:37 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-06-01 00:49:38 +0000

    dev-vcs/git: add 2.41.2
    
    Bug: https://bugs.gentoo.org/932091
    Signed-off-by: Sam James <[e-mail]>

 dev-vcs/git/Manifest          |   3 +
 dev-vcs/git/git-2.41.2.ebuild | 644 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 647 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a9127a07d80685069d977f4a862ce164b6cad3c8

commit a9127a07d80685069d977f4a862ce164b6cad3c8
Author:     Sam James <[e-mail]>
AuthorDate: 2024-06-01 00:22:15 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-06-01 00:49:38 +0000

    dev-vcs/git: add 2.39.5
    
    Bug: https://bugs.gentoo.org/932091
    Signed-off-by: Sam James <[e-mail]>

 dev-vcs/git/Manifest          |   3 +
 dev-vcs/git/git-2.39.5.ebuild | 644 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 647 insertions(+)

[Comment 5 Sam James 2024-06-01 00:51:31 UTC]

Hopefully these releases sort it.

[Comment 6 Manuel Mommertz 2024-06-04 05:11:57 UTC]

Git 2.44.2 did not change the problem. The error is still the same.

[Comment 7 Sam James 2024-06-24 14:30:05 UTC]

Can you report it upstream on the git ML? Thanks.

[Comment 8 Manuel Mommertz 2024-06-27 07:09:00 UTC]

After reading [1], I don't think that upstream will change it. We have to adjust to it.

I got it working by creating a directory /usr/share/git-daemon, put a file .gitconfig in it, with this content:

[safe]
        directory = *

Then adjusted the start_stop_daemon_args in /etc/init.d/git-daemon from:

start_stop_daemon_args="-e HOME= -e XDG_CONFIG_HOME="

to

start_stop_daemon_args="-e HOME=/usr/share/git-daemon -e XDG_CONFIG_HOME="

This turns off this security protection for git-daemon. Of course it should be possible to list individual repositories instead of '*' (might currently need to add '.', too, as I understand [1]).

I would suggest to adjust the git-ebuilds to provide this configuration for the user. Maybe commenting 'directory = *' initially so the user has to decide if he wants that.

[1] https://lore.kernel.org/all/[e-mail]/T/

[Comment 9 Florian Schmaus 2024-06-27 09:26:23 UTC]

See also https://public-inbox.org/git/[e-mail]/T/#mb88f028156161724e7e6e5f291bf763ad9fd0bc3 where adding these environment variables

  GIT_CONFIG_COUNT=1
  GIT_CONFIG_KEY_0=safe.directory
  GIT_CONFIG_VALUE_0="*"

was pointed out as workaround.

If we decide to merge https://github.com/gentoo/gentoo/pull/37312, then this becomes simply

  GIT_IGNORE_INSECURE_OWNER=true