Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 930119 - meson.eclass changes made "virtx meson_src_test" not die anymore
Summary: meson.eclass changes made "virtx meson_src_test" not die anymore
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-04-16 19:51 UTC by Mart Raudsepp
Modified: 2024-04-19 23:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2024-04-16 19:51:04 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/eclass/meson.eclass?id=4ba5414687d20ba1369e7e2833ba563c1815fcbe interacts badly with common call of

src_test() {
  virtx meson_src_test
}

and a "|| die" at the end doesn't make it fail tests either, so not sure what to do without fixing regression in eclass or tweaking virtualx.eclass instead somehow.
Comment 1 Mike Gilbert gentoo-dev 2024-04-16 19:59:48 UTC
A reduced test case would be helpful here; I would prefer not to install epiphany just to reproduce the failure.
Comment 2 Mike Gilbert gentoo-dev 2024-04-16 20:05:15 UTC
Real culprit is here: https://gitweb.gentoo.org/repo/gentoo.git/commit/eclass/meson.eclass?id=dbeb507f468dcc75095d54b59c165dcc70ef558d

The popd calls will reset $? to 0.
Comment 3 Larry the Git Cow gentoo-dev 2024-04-19 23:11:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=afe0521495aeed0a22a3656e7bad193fba39805e

commit afe0521495aeed0a22a3656e7bad193fba39805e
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2024-04-16 20:50:33 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-04-19 23:10:45 +0000

    meson.eclass: preserve exit status in phase funcs
    
    When the functions are called with nonfatal, we need to ensure 'popd'
    does not clobber the exit status of the called command.
    
    Update meson_src_configure as well just for consistency.
    
    Closes: https://bugs.gentoo.org/930119
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 eclass/meson.eclass | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)