Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 929887 - x11-misc/menumaker: needs upgrade to Python 3.12 (PythonCompatUpdate)
Summary: x11-misc/menumaker: needs upgrade to Python 3.12 (PythonCompatUpdate)
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 921826
  Show dependency tree
 
Reported: 2024-04-13 08:56 UTC by Michał Górny
Modified: 2024-07-31 09:11 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
x11-misc/menumaker-0.99.14-r1 (python 3.12 SyntaxWarning) (file_929887.txt,17.46 KB, text/plain)
2024-06-04 04:42 UTC, David Duchesne
Details
menumaker-0.99.14-python312-syntax-fix.patch (file_929887.txt,3.00 KB, patch)
2024-06-04 05:09 UTC, David Duchesne
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-04-13 08:56:39 UTC
This package does not support Python 3.12.  Please test it with Python 3.12 as a matter of urgency as the default will change in early June, as per message on gentoo-dev: https://www.mail-archive.com/gentoo-dev@lists.gentoo.org/msg99104.html.  Please check the information provided in the tracker.  Ask in #gentoo-python on IRC if need any help.
Comment 1 David Duchesne 2024-06-04 04:42:54 UTC
Created attachment 895031 [details]
x11-misc/menumaker-0.99.14-r1 (python 3.12 SyntaxWarning)

Hello,
I added PYTHON_COMPAT=( python3_{10..12} ) and tried to build it with python3.12, it builds but show several "SyntaxWarning" about invalid escape sequence, see log.

It might be possible to make a patch I think.
https://adamj.eu/tech/2022/11/04/why-does-python-deprecationwarning-invalid-escape-sequence
Comment 2 David Duchesne 2024-06-04 05:09:27 UTC
Created attachment 895032 [details, diff]
menumaker-0.99.14-python312-syntax-fix.patch

With this patch, it builds with python3.12 (and runs) without SyntaxWarning message.
Comment 3 Douglas Paul 2024-07-16 18:03:40 UTC
I can confirm that this patch seems functional based on my limited testing and was able to unblock my Python 3.12 upgrade.
Comment 4 Pacho Ramos gentoo-dev 2024-07-31 09:11:30 UTC
The patch looks to have some issues:
>>> Preparing source in /var/tmp/portage/x11-misc/menumaker-0.99.14/work/menumaker-0.99.14 ...
 * Applying menumaker-0.99.12-AM_PATH_PYTHON.patch ...                                                                                                                                                      [ ok ]
 * Applying menumaker-0.99.12-py3.12.patch ...
(Stripping trailing CRs from patch; use --binary to disable.)
patching file Prophet/Debian/__init__.py
(Stripping trailing CRs from patch; use --binary to disable.)
patching file Prophet/Desktop/__init__.py
(Stripping trailing CRs from patch; use --binary to disable.)
patching file Prophet/Legacy/Development.py
(Stripping trailing CRs from patch; use --binary to disable.)
patching file Prophet/__init__.py
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 123 with fuzz 1.                                                                                                                                                                       [ ok ]
 * Running eautoreconf in '/var/tmp/portage/x11-misc/menumaker-0.99.14/work/menumaker-0.99.14' ...
 * Running 'aclocal --system-acdir=/var/tmp/portage/x11-misc/menumaker-0.99.14/temp/aclocal' ...                                                                                                            [ ok ]
 * Running 'autoconf --force' ...                                                                                                                                                                           [ ok ]
 * Running 'automake --add-missing --copy --force-missing' ...                                                                                                                                              [ ok ]
 * Running elibtoolize in: menumaker-0.99.14/