Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 928869 - sys-apps/portage: install-qa-check.d/60bash-completion warns about git subcommand completion file from dev-vcs/git-machete
Summary: sys-apps/portage: install-qa-check.d/60bash-completion warns about git subcom...
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: PullRequest
: 930585 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-04-07 06:58 UTC by Agostino Sarubbo
Modified: 2024-04-25 02:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,146.68 KB, text/plain)
2024-04-07 06:58 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-04-07 06:58:47 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-vcs/git-machete-3.24.2 problems with installed bash completions.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2024-04-07 06:58:48 UTC
Created attachment 889671 [details]
build.log

build log and emerge --info
Comment 2 Marek Szuba archtester gentoo-dev 2024-04-15 12:00:51 UTC
Reassigning to Portage maintainers because I strongly believe this to be false positive from the QA check. Summary for said maintainers: dev-vcs/git-machete install shell-completion files for the Git subcommand "git machete" rather than for a stand-alone executable. I have confirmed that the bashcomp file it provides *does* work when I try to use in a bash session, however the Portage QA check claims no completions are provided.
Comment 3 Marek Szuba archtester gentoo-dev 2024-04-24 13:59:51 UTC
*** Bug 930585 has been marked as a duplicate of this bug. ***
Comment 4 Mike Gilbert gentoo-dev 2024-04-24 15:50:04 UTC
Just to clarify how this works:

dev-vcs/git-machete installs a completion file that defines a function called "_git_machete". The "complete" command is never called in this file.

The _git_machete function is actually called by a completion file provided by dev-vcs/git.
Comment 5 Larry the Git Cow gentoo-dev 2024-04-25 02:59:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=8bbdc814485d2990630d4217f68830fe1148801c

commit 8bbdc814485d2990630d4217f68830fe1148801c
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2024-04-24 15:35:32 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-04-24 15:35:32 +0000

    Remove QA warning when no bash completions are found
    
    This triggers unwanted warnings in at least two known cases.
    
    Bug: https://bugs.gentoo.org/928599
    Bug: https://bugs.gentoo.org/928869
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 bin/install-qa-check.d/60bash-completion | 3 ---
 1 file changed, 3 deletions(-)