928566 – x11-plugins/wmrecord-1.0.5.3-r2 fails to compile: wmrecord.c:383:17: error: passing argument 2 of snprintf makes integer from pointer without a cast [-Wint-conversion]

Bug 928566 - x11-plugins/wmrecord-1.0.5.3-r2 fails to compile: wmrecord.c:383:17: error: passing argument 2 of snprintf makes integer from pointer without a cast [-Wint-conversion]

Summary: x11-plugins/wmrecord-1.0.5.3-r2 fails to compile: wmrecord.c:383:17: error: p...

Status:	RESOLVED PKGREMOVED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Bernard Cafarelli

URL:
Whiteboard:	removed
Keywords:

Depends on:
Blocks:	c99-porting
	Show dependency tree

Reported:	2024-04-04 06:48 UTC by Agostino Sarubbo
Modified:	2024-11-01 15:36 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
build.log (build.log,44.50 KB, text/plain) 2024-04-04 06:48 UTC, Agostino Sarubbo	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Agostino Sarubbo gentoo-dev

2024-04-04 06:48:53 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-plugins/wmrecord-1.0.5.3-r2 fails to compile.
Discovered on: x86 (internal ref: tinderbox_x86)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0004

Comment 1 Agostino Sarubbo gentoo-dev

2024-04-04 06:48:54 UTC

Created attachment 889389 [details]
build.log

build log and emerge --info

Comment 2 NHO 2024-05-11 11:14:18 UTC

I dunno what's this program tries to do, my minimal test program segfaults. As it ought to, trying to take a pointer to address "3" as a format string and using string "000" as a size. Someone may be swapped order of operations?
But it's also wrong because string "000" is length 4, due to null terminator.

It's also for WindowMaker/AfterStep WMs and unlikely to work anywhere else, was written 20 years ago and is untouched since, with any upstream dead, and there's better audio recording software out there.
Let's just drop this.

Comment 3 Bernard Cafarelli gentoo-dev

2024-05-12 22:19:45 UTC

Thanks for the analysis! I agree with the conclusion, let's last rite this one

Comment 4 Larry the Git Cow gentoo-dev

2024-09-13 12:00:46 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b79fa39482c753c0ed241c3b1fadab6f15be8529

commit b79fa39482c753c0ed241c3b1fadab6f15be8529
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2024-09-13 10:42:41 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2024-09-13 11:56:24 +0000

    x11-plugins/wmrecord: treeclean
    
    Closes: https://bugs.gentoo.org/928566 (pkgremoved)
    Closes: https://bugs.gentoo.org/931764 (pkgremoved)
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 profiles/package.mask                              |  7 ----
 x11-plugins/wmrecord/Manifest                      |  1 -
 .../files/wmrecord-1.0.5.3-fno-common.patch        | 29 -------------
 x11-plugins/wmrecord/files/wmrecord.desktop        |  8 ----
 x11-plugins/wmrecord/metadata.xml                  |  9 ----
 x11-plugins/wmrecord/wmrecord-1.0.5.3-r2.ebuild    | 48 ----------------------
 6 files changed, 102 deletions(-)