Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 92853 - beep-media-player (bmp) volume 0% mute fix
Summary: beep-media-player (bmp) volume 0% mute fix
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Tony Vroon
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-16 18:18 UTC by CBke -Left- bye
Modified: 2005-05-21 02:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Mute fix in bmp 0.9.7 (bmp_0.9.7_mute.patch,854 bytes, patch)
2005-05-16 18:19 UTC, CBke -Left- bye
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description CBke -Left- bye 2005-05-16 18:18:05 UTC
When setting the volume to 0%, the alsa output plugin in hw mode doens't
completely mute the device.

Reproducible: Always
Steps to Reproduce:
1) In BMP: select ALSA plugin under Preferences - Plugins - Output
2) Click the Preferences button for ALSA Driver configuration and uncheck the
"Use software volume control" checkbox under the Device settings tab and select
Mixer device PCM
3) Click OK on the ALSA Driver configuration window and close the BMP
Preferences window
4) use an external mixer to set the Master and PCM channels to 0% (but don't
mute them!)
5) play a song in BMP
6) scroll the volume in BMP up a little and then back to 0%
7) in an external mixer now increase the master volume to about 60%
8) listen to the music playing softly, even though the volume is 0% according to BMP



media-sound/alsa-headers 1.0.9_rc2
media-libs/alsa-lib 1.0.9_rc2-r1
kernel  2.6.12-rc4 (manually)
Comment 1 CBke -Left- bye 2005-05-16 18:19:00 UTC
Created attachment 59073 [details, diff]
Mute fix in bmp 0.9.7

applied to native souce
Comment 2 Tony Vroon gentoo-dev 2005-05-17 16:05:05 UTC
Have you submitted your bug upstream?
If so, what is the bug number there?
Comment 3 CBke -Left- bye 2005-05-17 16:20:41 UTC
(In reply to comment #2)
> Have you submitted your bug upstream?
> If so, what is the bug number there?

No, is it a feature of alsa not to completely mute with a zero value, or rather
a bug in beep-media-player?

In gklellm Volume Plugin 2.1.13 they expl. mute with a 0, but alsa-mixer doesn't
just like bmp.
Comment 4 CBke -Left- bye 2005-05-17 16:32:29 UTC
But then again in

I found in alsa-lib-1.0.9rc3/src/mixer/simple.c th following code:


<code>
void snd_mixer_selem_set_playback_volume_range(snd_mixer_elem_t *elem,
                                               long min, long max)
{
        selem_t *s;
        assert(elem);
        assert(elem->type == SND_MIXER_ELEM_SIMPLE);
        assert(min < max);
        s = elem->private_data;
        s->str[PLAY].range = 1;
        s->str[PLAY].min = min;
        s->str[PLAY].max = max;
        selem_read(elem);
}
</code>

On line 7 assert(min < max) with a 0 will not compute so i'll go for alsa ;)
Comment 5 CBke -Left- bye 2005-05-17 16:34:28 UTC
nvm wrong piece of code
Comment 6 Tony Vroon gentoo-dev 2005-05-21 02:45:06 UTC
This needs to be reported upstream to have them decide.
You are changing the behaviour of the mixer, while the current behaviour is
exactly what ALSA itself does. This may have been a conscious design decision.