Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 928373 - app-shells/bash: "optimise SRC_URI generation" commit missed adding '.sig' in mirror URI
Summary: app-shells/bash: "optimise SRC_URI generation" commit missed adding '.sig' in...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-01 08:39 UTC by konsolebox
Modified: 2024-04-23 14:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description konsolebox 2024-04-01 08:39:11 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/app-shells/bash?id=d9278cc22a2e84f19bb758b569870470c69562e2

Commit line:

+			SRC_URI+=" verify-sig? ( ${patch_url/${upstream_url_base}/${mirror_url_base}} )"

It's still in bash-5.2_p26.ebuild (https://gitweb.gentoo.org/repo/gentoo.git/tree/app-shells/bash/bash-5.2_p26.ebuild#n68).
Comment 1 konsolebox 2024-04-01 09:05:35 UTC
I also noticed the base URI assignments are interchanged.

>		upstream_url_base="mirror://gnu/bash"
>		mirror_url_base="ftp://ftp.cwru.edu/pub/bash"
Comment 2 Larry the Git Cow gentoo-dev 2024-04-23 13:56:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a4c8143b201ad2e042d64d1129b87747bb4b461

commit 0a4c8143b201ad2e042d64d1129b87747bb4b461
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-04-23 13:53:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-23 13:55:39 +0000

    app-shells/bash: add verify-sig to mirror URL too
    
    Closes: https://bugs.gentoo.org/928373
    Signed-off-by: Sam James <sam@gentoo.org>

 app-shells/bash/bash-5.1_p16-r6.ebuild | 4 ++--
 app-shells/bash/bash-5.1_p16-r7.ebuild | 4 ++--
 app-shells/bash/bash-5.1_p16-r8.ebuild | 4 ++--
 app-shells/bash/bash-5.2_p26-r1.ebuild | 2 +-
 app-shells/bash/bash-5.2_p26.ebuild    | 2 +-
 app-shells/bash/bash-5.3_alpha.ebuild  | 2 +-
 app-shells/bash/bash-9999.ebuild       | 2 +-
 7 files changed, 10 insertions(+), 10 deletions(-)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-04-23 13:56:13 UTC
(In reply to konsolebox from comment #1)
> I also noticed the base URI assignments are interchanged.
> 
> >		upstream_url_base="mirror://gnu/bash"
> >		mirror_url_base="ftp://ftp.cwru.edu/pub/bash"

This part isn't a bug, as we originally had mirror://gnu/bash first, and the GNU servers I considered the official place for Bash.

Just that maybe the variable name is confusing.
Comment 4 Larry the Git Cow gentoo-dev 2024-04-23 14:02:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=14f7c0d35495d4c2a26b6edb199dbaa53a2aec7b

commit 14f7c0d35495d4c2a26b6edb199dbaa53a2aec7b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-04-23 14:01:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-23 14:02:12 +0000

    sys-libs/readline: add verify-sig to mirror URL too
    
    As done for bash in 0a4c8143b201ad2e042d64d1129b87747bb4b461.
    
    Bug: https://bugs.gentoo.org/928373
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/readline/readline-8.1_p2-r1.ebuild | 2 +-
 sys-libs/readline/readline-8.1_p2-r2.ebuild | 2 +-
 sys-libs/readline/readline-8.2_p10.ebuild   | 2 +-
 sys-libs/readline/readline-8.3_alpha.ebuild | 2 +-
 sys-libs/readline/readline-9999.ebuild      | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)