Created attachment 889087 [details] full build log After upgraging my kernel to 6.8.1, building the r8125 module fails with the following error: # cmd_gen_objtooldep /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_firmware.o { echo ; echo '/tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_firmware.o: $(wildcard ./tools/objtool/objtool)' ; } >> /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/.r8125_firmware.o.cmd /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.c: In function ‘rtl8125_get_rss_hash_opts’: /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.c:59:27: warning: this statement may fall through [-Wimplicit-fallthrough=] 59 | cmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3; /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.c:61:9: note: here 61 | case UDP_V4_FLOW: | ^~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.c:62:20: warning: this statement may fall through [-Wimplicit-fallthrough=] 62 | if (tp->rss_flags & RTL_8125_RSS_FLAG_HASH_UDP_IPV4) | ^ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.c:65:9: note: here 65 | case IPV4_FLOW: | ^~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.c:69:27: warning: this statement may fall through [-Wimplicit-fallthrough=] 69 | cmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3; /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.c:71:9: note: here 71 | case UDP_V6_FLOW: | ^~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.c:72:20: warning: this statement may fall through [-Wimplicit-fallthrough=] 72 | if (tp->rss_flags & RTL_8125_RSS_FLAG_HASH_UDP_IPV6) | ^ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.c:75:9: note: here 75 | case IPV6_FLOW: | ^~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:2396:6: warning: no previous prototype for ‘ClearEthPhyOcpBit’ [-Wmissing-prototypes] 2396 | void ClearEthPhyOcpBit(struct rtl8125_private *tp, u16 addr, u16 mask) | ^~~~~~~~~~~~~~~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:2405:6: warning: no previous prototype for ‘SetEthPhyOcpBit’ [-Wmissing-prototypes] 2405 | void SetEthPhyOcpBit(struct rtl8125_private *tp, u16 addr, u16 mask) | ^~~~~~~~~~~~~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/rtl_eeprom.c:96:5: warning: no previous prototype for ‘rtl8125_eeprom_cmd_done’ [-Wmissing-prototypes] 96 | int rtl8125_eeprom_cmd_done(struct rtl8125_private *tp) | ^~~~~~~~~~~~~~~~~~~~~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c: In function ‘rtl8125_get_drvinfo’: /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:4794:17: error: implicit declaration of function ‘strlcpy’; did you mean ‘strscpy’? [-Werror=implicit-function-declaration] 4794 | strlcpy(info->fw_version, rtl_fw->version, | ^~~~~~~ | strscpy # cmd_gen_objtooldep /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/rtltool.o { echo ; echo '/tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/rtltool.o: $(wildcard ./tools/objtool/objtool)' ; } >> /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/.rtltool.o.cmd /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c: At top level: /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:6243:35: error: initialization of ‘int (*)(struct net_device *, struct ethtool_rxfh_param *)’ from incompatible pointer type ‘int (*)(struct net_device *, u32 *, u8 *, u8 *)’ {aka ‘int (*)(struct net_device *, unsigned int *, unsigned char *, unsigned char *)’} [-Werror=incompatible-pointer-types] 6243 | .get_rxfh = rtl8125_get_rxfh, | ^~~~~~~~~~~~~~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:6243:35: note: (near initialization for ‘rtl8125_ethtool_ops.get_rxfh’) /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:6244:35: error: initialization of ‘int (*)(struct net_device *, struct ethtool_rxfh_param *, struct netlink_ext_ack *)’ from incompatible pointer type ‘int (*)(struct net_device *, const u32 *, const u8 *, const u8)’ {aka ‘int (*)(struct net_device *, const unsigned int *, const unsigned char *, const unsigned char)’} [-Werror=incompatible-pointer-types] 6244 | .set_rxfh = rtl8125_set_rxfh, | ^~~~~~~~~~~~~~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:6244:35: note: (near initialization for ‘rtl8125_ethtool_ops.set_rxfh’) /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:6902:6: warning: no previous prototype for ‘rtl8125_apply_firmware’ [-Wmissing-prototypes] 6902 | void rtl8125_apply_firmware(struct rtl8125_private *tp) | ^~~~~~~~~~~~~~~~~~~~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:13349:1: warning: no previous prototype for ‘rtl8125_enable_msix’ [-Wmissing-prototypes] 13349 | rtl8125_enable_msix(struct rtl8125_private *tp) | ^~~~~~~~~~~~~~~~~~~ /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.c:13377:6: warning: no previous prototype for ‘rtl8125_dump_msix_tbl’ [-Wmissing-prototypes] 13377 | void rtl8125_dump_msix_tbl(struct rtl8125_private *tp) | ^~~~~~~~~~~~~~~~~~~~~ # cmd_gen_objtooldep /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.o { echo ; echo '/tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_rss.o: $(wildcard ./tools/objtool/objtool)' ; } >> /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/.r8125_rss.o.cmd # cmd_gen_objtooldep /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/rtl_eeprom.o { echo ; echo '/tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/rtl_eeprom.o: $(wildcard ./tools/objtool/objtool)' ; } >> /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/.rtl_eeprom.o.cmd # cmd_gen_objtooldep /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_ptp.o { echo ; echo '/tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_ptp.o: $(wildcard ./tools/objtool/objtool)' ; } >> /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/.r8125_ptp.o.cmd cc1: some warnings being treated as errors make[3]: *** [scripts/Makefile.build:243: /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src/r8125_n.o] Error 1 make[2]: *** [/usr/src/linux-6.8.1-gentoo/Makefile:1921: /tmp/portage/net-misc/r8125-9.011.01-r1/work/r8125-9.011.01/src] Error 2 make[1]: *** [Makefile:240: __sub-make] Error 2 make[1]: Leaving directory '/usr/src/linux-6.8.1-gentoo' make: *** [Makefile:188: modules] Error 2 Full build log and emerge --info in the attachments. Iade
Created attachment 889088 [details] emerge --ìinfo net-misc/r8125
*** Bug 928303 has been marked as a duplicate of this bug. ***
Hi, same issue in kernel 6.8.6. Iade
UPDATE: Newest 9.013.02 version builds fine. I downloaded it from Realtek website and I built it directly from sources. Iade
*** Bug 928983 has been marked as a duplicate of this bug. ***
The PR for version 9.013.02 has been published.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82798ecb788646dabc394df2c6066c257cb3a826 commit 82798ecb788646dabc394df2c6066c257cb3a826 Author: Karlson2k (Evgeny Grin) <k2k@narod.ru> AuthorDate: 2024-04-16 16:54:32 +0000 Commit: Yixun Lan <dlan@gentoo.org> CommitDate: 2024-04-18 10:48:30 +0000 net-misc/r8125: new upstream version 9.013.02 Bug: https://bugs.gentoo.org/928293 Bug: https://bugs.gentoo.org/928303 Closes: https://github.com/gentoo/gentoo/pull/36281 Signed-off-by: Karlson2k (Evgeny Grin) <k2k@narod.ru> Signed-off-by: Yixun Lan <dlan@gentoo.org> net-misc/r8125/Manifest | 1 + net-misc/r8125/r8125-9.013.02.ebuild | 37 ++++++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+)
Could you please check with the newest version in gentoo repo?
(In reply to Karlson2k from comment #8) > Could you please check with the newest version in gentoo repo? Hi, now it builds fine... I will test it to check if it causes some issues during boot, because when I built it directly from official .tar.bz2 it causes my kernel hanging after rebootin the system. I will update you soon! Thanks, Iade
Closing this bug as it was about broken build, which is fixed now. If the driver causes run-time problems, please open another bug.
