Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 928091 - app-crypt/eid-mw: (almost) automagic gui-libs/gtk:4 dep
Summary: app-crypt/eid-mw: (almost) automagic gui-libs/gtk:4 dep
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Vincent Hardy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-29 07:53 UTC by Sam James
Modified: 2024-05-18 16:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-29 07:53:22 UTC
configure.ac has:
```
[...]
AC_ARG_WITH([gtkvers],
        [AS_HELP_STRING([--with-gtkvers],[select GTK version to use [default: 3 if available, falls back to 4 if not; note that GTK4 support is incomplete].
--without-gtkvers disables GTK altogether [note: this implies --disable-dialogs].])],
        [gtkvers=$withval],[gtkvers=detect])
have_gtk=no
AC_MSG_CHECKING([for wanted GTK version])
AC_MSG_RESULT($gtkvers)
if test "$gtkvers" = "detect" -o "$gtkvers" = 3
then
        AC_MSG_CHECKING([for gtk3])
        PKG_CHECK_MODULES(GTK, [gtk+-3.0], [have_gtk=3], [have_gtk=no])
fi
if test "$have_gtk" = "no"
then
        if test "$gtkvers" = "detect" -o "$gtkvers" = 4
        then
                AC_MSG_CHECKING([for gtk4])
                PKG_CHECK_MODULES(GTK, [gtk4], [have_gtk=4],[have_gtk=no])
        fi
fi
if test "$have_gtk" = "no"
then
        if test "$gtkvers" = 2
        then
                AC_MSG_ERROR([GTK 2 is no longer supported, sorry])
        fi
fi
[...]
```

And the ebuild currently does:
                $(use_with gtk gtkvers 'detect') \

Given that the ebuild depends on gtk+:3, this is actually fine for now, but it's a timebomb for when upstream change to prefer gtk4. Just set it explicitly and add a comment.
Comment 1 Vincent Hardy 2024-04-20 16:14:16 UTC
(In reply to Sam James from comment #0)

I replaced 'detect' by '3'. Yes it's better like this.

The fix is recently applied to the current live ebuild in portage tree.
Can i close this bug or should i wait the commit of new mainstream version ?
Comment 2 Larry the Git Cow gentoo-dev 2024-05-18 16:46:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7b2484619fb6e0388a144086bd7ba5ca615f288

commit d7b2484619fb6e0388a144086bd7ba5ca615f288
Author:     Vincent Hardy <vincent.hardy.be@gmail.com>
AuthorDate: 2024-05-18 16:42:31 +0000
Commit:     Amy Liffey <amynka@gentoo.org>
CommitDate: 2024-05-18 16:45:56 +0000

    app-crypt/eid-mw: drop 5.1.15
    
    Closes: https://bugs.gentoo.org/928091
    Signed-off-by: Amy Liffey <amynka@gentoo.org>

 app-crypt/eid-mw/Manifest                          |   1 -
 app-crypt/eid-mw/eid-mw-5.1.15.ebuild              | 129 ---------------------
 .../eid-mw/files/use-printf-in-Makefile.patch      |  21 ----
 3 files changed, 151 deletions(-)