Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927823 - app-portage/elt-patches-20240324 - [slibtool] Portage patch failed to apply (ltmain.sh version 0)!
Summary: app-portage/elt-patches-20240324 - [slibtool] Portage patch failed to apply (...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://github.com/gentoo/elt-patches...
Whiteboard:
Keywords:
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2024-03-25 15:43 UTC by orbea
Modified: 2024-05-12 15:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-libs/trio-1.17.1 build log (The ebuild is modified to use eautoreconf) (trio-1.17.1-build.log,2.01 KB, text/x-log)
2024-03-25 15:43 UTC, orbea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description orbea 2024-03-25 15:43:13 UTC
Created attachment 888557 [details]
dev-libs/trio-1.17.1 build log (The ebuild is modified to use eautoreconf)

With dev-build/slibtool-9999 slibtoolize has been implemented which replaces the GNU libtoolize script and it can be used by default by setting LIBTOOLIZE in the environment for any ebuild that uses eautoreconf.

However using slibtoolize causes elt-patches to fail during the eautoreconf process.

 * Portage patch failed to apply (ltmain.sh version 0)!

This is because ltmain.sh is not required for slibtoolize and has been reduced to this simple script:

 #!/dev/null
 # << this script should never be invoked >>

Would it be possible to update elt-patches to not require patching these files when its not required to do so?

To reproduce this:

1. Build slibtool-9999.
2. export LIBTOOLIZE=slibtoolize
3. Build any package that uses eautoreconf.

slibtoolize can also be tested outside of an ebuild by setting LIBTOOLIZE in the environment for autoreconf.
Comment 1 orbea 2024-03-27 21:46:47 UTC
In make.conf AT_M4DIR='/usr/share/slibtool' also needs to be set to use slibtoolize correctly.
Comment 2 Larry the Git Cow gentoo-dev 2024-05-12 15:38:37 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/elt-patches.git/commit/?id=bc356deb703c7f5352470ccc2aa647d9a17a804d

commit bc356deb703c7f5352470ccc2aa647d9a17a804d
Author:     orbea <orbea@riseup.net>
AuthorDate: 2024-03-27 21:36:41 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-12 15:38:28 +0000

    eltpatch.in: support slibtoolize
    
    Patching ltmain.sh is not applicable when LIBTOOLIZE=slibtoolize which
    copies a ltmain.sh script with #!/dev/null in the shebang.
    
    Bug: https://bugs.gentoo.org/927823
    Signed-off-by: orbea <orbea@riseup.net>
    Closes: https://github.com/gentoo/elt-patches/pull/1
    Signed-off-by: Sam James <sam@gentoo.org>

 eltpatch.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Larry the Git Cow gentoo-dev 2024-05-12 15:41:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a667cb874b1e59d2ee77d0cf2d983b1755a0559

commit 7a667cb874b1e59d2ee77d0cf2d983b1755a0559
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-12 15:40:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-12 15:40:08 +0000

    app-portage/elt-patches: add 20240512
    
    Bug: https://bugs.gentoo.org/927823
    Signed-off-by: Sam James <sam@gentoo.org>

 app-portage/elt-patches/Manifest                   |  1 +
 .../elt-patches/elt-patches-20240512.ebuild        | 39 ++++++++++++++++++++++
 2 files changed, 40 insertions(+)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-12 15:57:29 UTC
Done, I think? please feel free to ropen if not