Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927345 - sci-astronomy/siril-1.2.1 fails to compile: estimate_kernel.hpp:59:8: error: type struct options violates the C++ One Definition Rule [-Werror=odr]
Summary: sci-astronomy/siril-1.2.1 fails to compile: estimate_kernel.hpp:59:8: error: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: mario.haustein
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2024-03-20 10:04 UTC by Agostino Sarubbo
Modified: 2024-06-02 08:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,353.70 KB, text/plain)
2024-03-20 10:04 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-03-20 10:04:18 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-astronomy/siril-1.2.1 fails to compile.
Discovered on: amd64 (internal ref: lto_tinderbox)
System: LTO-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#LTO)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Comment 1 Agostino Sarubbo gentoo-dev 2024-03-20 10:04:20 UTC
Created attachment 887984 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-03-20 10:04:21 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: src/siril 
FAILED: src/siril-cli 
FAILED: src/tests/sorting_perf 
Run-time dependency htmesh found: NO (tried pkgconfig and cmake)
Run-time dependency kplot found: NO (tried pkgconfig and cmake)
../siril-1.2.1/src/filters/deconvolution/estimate_kernel.hpp:59:8: error: type ‘struct options’ violates the C++ One Definition Rule [-Werror=odr]
Comment 3 Larry the Git Cow gentoo-dev 2024-06-02 08:28:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15f91123ccce8cb1dd2953c18d13edf22c034164

commit 15f91123ccce8cb1dd2953c18d13edf22c034164
Author:     Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
AuthorDate: 2024-04-28 12:31:39 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-06-02 08:28:03 +0000

    sci-astronomy/siril: fix one definition rule violation
    
    Closes: https://bugs.gentoo.org/927345
    Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
    Closes: https://github.com/gentoo/gentoo/pull/36467
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../siril/files/siril-1.2.1-options.patch          | 101 +++++++++++++++++++++
 sci-astronomy/siril/siril-1.2.1-r1.ebuild          |  93 +++++++++++++++++++
 2 files changed, 194 insertions(+)