Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927241 - emerge --sync uses ipv6 for rsync even if it is disabled
Summary: emerge --sync uses ipv6 for rsync even if it is disabled
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS, PullRequest
Depends on: 930802
Blocks:
  Show dependency tree
 
Reported: 2024-03-18 12:18 UTC by Pavel Balaev
Modified: 2024-06-04 01:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Balaev 2024-03-18 12:18:21 UTC
socket.has_ipv6 gives a false result:
    
$ sysctl net.ipv6.conf.all.disable_ipv6=1
net.ipv6.conf.all.disable_ipv6 = 1
$ python
Python 3.11.8 (main, Feb 24 2024, 17:10:38) [GCC 13.2.1 20240210] on linux
>>> import socket
>>> socket.has_ipv6
True

Reproducible: Always

Steps to Reproduce:
1.disable ipv6
2.emerge --sync

Actual Results:  
emerge --sync use ipv6 on ipv6 disabled system configuration

Expected Results:  
emerge --sync use ipv4 if ipv6 is disabled
Comment 1 Pavel Balaev 2024-03-18 12:20:12 UTC
PR: https://github.com/gentoo/portage/pull/1309
Comment 2 Larry the Git Cow gentoo-dev 2024-05-26 23:27:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=a671334b7c7b64bc779f1c2bfb4ed659d97c0d19

commit a671334b7c7b64bc779f1c2bfb4ed659d97c0d19
Author:     Pavel Balaev <mail@void.so>
AuthorDate: 2024-03-18 11:29:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-26 23:27:08 +0000

    sync: don't use ipv6 for rsync when it's disabled
    
    socket.has_ipv6 gives a false result:
    
    $ sysctl net.ipv6.conf.all.disable_ipv6=1
    net.ipv6.conf.all.disable_ipv6 = 1
    $ python
    Python 3.11.8 (main, Feb 24 2024, 17:10:38) [GCC 13.2.1 20240210] on linux
    >>> import socket
    >>> socket.has_ipv6
    True
    
    This patch uses the portage.process.has_ipv6() function,
    which returns the correct result.
    
    Bug: https://bugs.gentoo.org/927241
    Signed-off-by: Pavel Balaev <mail@void.so>
    Closes: https://github.com/gentoo/portage/pull/1309
    Signed-off-by: Sam James <sam@gentoo.org>

 lib/portage/sync/modules/rsync/rsync.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2024-06-04 01:31:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1dd08f05355b14c7594d0e0ccf46cdb2b1486cbe

commit 1dd08f05355b14c7594d0e0ccf46cdb2b1486cbe
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-06-04 01:31:07 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-04 01:31:07 +0000

    sys-apps/portage: add 3.0.65
    
    Closes: https://bugs.gentoo.org/930802
    Closes: https://bugs.gentoo.org/787623
    Closes: https://bugs.gentoo.org/922629
    Closes: https://bugs.gentoo.org/927241
    Closes: https://bugs.gentoo.org/930992
    Closes: https://bugs.gentoo.org/932739
    Closes: https://bugs.gentoo.org/932804
    Closes: https://bugs.gentoo.org/933297
    Closes: https://bugs.gentoo.org/933385
    Closes: https://bugs.gentoo.org/933442
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.65.ebuild | 242 +++++++++++++++++++++++++++++++++
 2 files changed, 243 insertions(+)