https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: net-ftp/filezilla-3.66.5 fails to compile. Discovered on: amd64 (internal ref: lto_tinderbox) System: LTO-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#LTO) Info about the issue: https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Created attachment 887800 [details] build.log build log and emerge --info
lto_tinderbox has reproduced this issue with version 3.67.0 - Updating summary.
While I can reproduce the ODR violation, I cannot report a bug on upstream's trac installation. Account registration is broken: Configuration Error Cannot find implementation(s) of the IAccountRegistrationInspector interface named RegistrationFilterAdapter. Please check that the Component is enabled or update the option [account-manager] register_check in trac.ini. ... I have sent an email to the contact address, we shall see how that goes.
Their trac configuration has been fixed, and also a fix for the LTO has been committed: https://svn.filezilla-project.org/filezilla?view=revision&revision=11167
(In reply to Eli Schwartz from comment #4) > Their trac configuration has been fixed, and also a fix for the LTO has been > committed: > > https://svn.filezilla-project.org/filezilla?view=revision&revision=11167 I'm not sure which approach should we take? wait for new release, or just pull in the fix
Created attachment 897385 [details, diff] net-ftp/filezilla: backport patch to fix ODR violations The backport was trivial as it happens. I was thinking to commit this. What do you think?
(In reply to Eli Schwartz from comment #6) > Created attachment 897385 [details, diff] [details, diff] > net-ftp/filezilla: backport patch to fix ODR violations > > The backport was trivial as it happens. I was thinking to commit this. What > do you think? indeed it's quite trivial, should be safe to commit, feel free to push it, thanks
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6c33a435474c05703d8f93eed28d639b8269616e commit 6c33a435474c05703d8f93eed28d639b8269616e Author: Eli Schwartz <eschwartz@gentoo.org> AuthorDate: 2024-07-10 03:15:12 +0000 Commit: Yixun Lan <dlan@gentoo.org> CommitDate: 2024-07-10 07:55:49 +0000 net-ftp/filezilla: backport patch to fix ODR violations Closes: https://bugs.gentoo.org/927178 Signed-off-by: Eli Schwartz <eschwartz@gentoo.org> Signed-off-by: Yixun Lan <dlan@gentoo.org> net-ftp/filezilla/files/filezilla-3.67.0-odr.patch | 670 +++++++++++++++++++++ net-ftp/filezilla/filezilla-3.67.0-r1.ebuild | 77 +++ 2 files changed, 747 insertions(+)
