Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 925100 - sys-devel/bison: Add --without-libtextstyle option
Summary: sys-devel/bison: Add --without-libtextstyle option
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
Depends on:
Reported: 2024-02-20 18:52 UTC by Raul Rangel
Modified: 2024-02-22 16:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

My failed attempt at adding the flag. (with-libtextstyle.patch,1.38 KB, patch)
2024-02-20 18:54 UTC, Raul Rangel
Details | Diff
Working patch! (with-libtextstyle.patch,1.37 KB, patch)
2024-02-20 23:50 UTC, Raul Rangel
Details | Diff
gnulib libtextstyle patch (0001-libtextstyle-Add-with-libtextstyle-option.patch,2.36 KB, patch)
2024-02-21 21:02 UTC, Raul Rangel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raul Rangel 2024-02-20 18:52:42 UTC

`libtextstyle` is optional for bison. The configure script probes for it and links to the library if available, or doesn't if it's not. Ideally we would guard this behavior behind the `gettext` USE flag so we can conditionally control the `gettext` dependency.

Reproducible: Always
Comment 1 Raul Rangel 2024-02-20 18:54:02 UTC
Created attachment 885534 [details, diff]
My failed attempt at adding the flag.

I think we need to add the flag to `libtextstyle-optional.m4` instead of the ``. I'm not sure where `libtextstyle-optional.m4` came from though.
Comment 2 Raul Rangel 2024-02-20 23:50:39 UTC
Created attachment 885556 [details, diff]
Working patch!

I had to modify the file in the `m4` directory, not sure if that's allowed or if those are auto generated.
Comment 3 Raul Rangel 2024-02-21 21:02:48 UTC
Created attachment 885658 [details, diff]
gnulib libtextstyle patch

I sent the following patch to gnulib upstream. The email hasn't shown up in the list archive though:

Unfortunately I don't think there is a patch to send to upstream to bison. I think they just need to cut a new release that pulls in the latest gnulib. I'll send a PR for the bison ebuild.
Comment 4 Raul Rangel 2024-02-22 16:28:23 UTC
Just FYI, here is the PR: