Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 923804 - sys-devel/gcc-14: broken handling of constant expressions for C (was: dev-db/postgresql: build failure with gcc 14)
Summary: sys-devel/gcc-14: broken handling of constant expressions for C (was: dev-db/...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
: 924052 (view as bug list)
Depends on:
Blocks: gcc-14
  Show dependency tree
 
Reported: 2024-02-05 02:32 UTC by Sam James
Modified: 2024-02-08 11:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_923804.txt,893.28 KB, text/plain)
2024-02-05 02:32 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-05 02:32:24 UTC
Created attachment 884250 [details]
build.log

This started recently, I think. Not looked into it yet.

```
pg_collation.c:46:1: error: conflicting types for ‘CollationCreate’; have ‘Oid(const char *, Oid,  Oid,  char,  _Bool,  int32,  const char *, const char *, const char *, const char *, const char *, _Bool,  _Bool)’ {aka ‘unsigned int(const char *, unsigned int,  unsigned int,  char,  _Bool,  int,  const char *, const char *, const char *, const char *, const char *, _Bool,  _Bool)’}
   46 | CollationCreate(const char *collname, Oid collnamespace,
      | ^~~~~~~~~~~~~~~
In file included from pg_collation.c:25:
../../../src/include/catalog/pg_collation.h:88:17: note: previous declaration of ‘CollationCreate’ with type ‘Oid(const char *, Oid,  Oid,  char,  bool,  int32,  const char *, const char *, const char *, const char *, const char *, bool,  bool)’ {aka ‘unsigned int(const char *, unsigned int,  unsigned int,  char,  unsigned char,  int,  const char *, const char *, const char *, const char *, const char *, unsigned char,  unsigned char)’}
   88 | extern Oid      CollationCreate(const char *collname, Oid collnamespace,
      |                 ^~~~~~~~~~~~~~~
pg_collation.c: In function ‘CollationCreate’:
pg_collation.c:207:48: error: passing argument 3 of ‘heap_form_tuple’ from incompatible pointer type [-Wincompatible-pointer-types]
  207 |         tup = heap_form_tuple(tupDesc, values, nulls);
      |                                                ^~~~~
      |                                                |
      |                                                _Bool *
In file included from pg_collation.c:18:
../../../src/include/access/htup_details.h:715:87: note: expected ‘bool *’ {aka ‘unsigned char *’} but argument is of type ‘_Bool *’
  715 |                                                                  Datum *values, bool *isnull);
      |                                                                                 ~~~~~~^~~~~~
make[3]: *** [<builtin>: pg_collation.o] Error 1
make[3]: Leaving directory '/var/tmp/portage/dev-db/postgresql-16.1-r2/work/postgresql-16.1/src/backend/catalog'
make[2]: *** [common.mk:37: catalog-recursive] Error 2
```

----

# emerge --info
Portage 3.0.61_p29_p1707099977 (python 3.12.1-final-0, default/linux/amd64/17.1/hardened, gcc-14, glibc-2.39, 6.6.15 x86_64)
=================================================================
System uname: Linux-6.6.15-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.39
KiB Mem:    65758024 total,    482116 free
KiB Swap:   16662520 total,  16587512 free
Timestamp of repository gentoo: Mon, 05 Feb 2024 00:33:36 +0000
Head commit of repository gentoo: 28e7a78cbfe305f064ca27bd45f61be15337240a

Timestamp of repository kde: Sat, 03 Feb 2024 21:48:22 +0000
Head commit of repository kde: a057be35665d902efeae61bd706f3d98df2bf55b

Timestamp of repository qt: Sat, 27 Jan 2024 17:35:04 +0000
Head commit of repository qt: 3ec1bd7414a4e420bdbf11b1077bba1d4c329b46

Timestamp of repository sam_c: Tue, 30 Jan 2024 11:18:03 +0000
Head commit of repository sam_c: 5647fc75aeaa97d8f09207c129aee51a15cfa56a

sh dash 0.5.12
ld GNU ld (Gentoo 2.42 p2) 2.42.0
ccache version 4.9 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p26::gentoo
dev-build/autoconf:        2.13-r8::gentoo, 2.69-r9::gentoo, 2.72-r1::gentoo
dev-build/automake:        1.16.5-r2::gentoo
dev-build/cmake:           3.28.2::gentoo
dev-build/libtool:         2.4.7-r2::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.3.1-r1::gentoo
dev-java/java-config:      2.3.3-r1::gentoo
dev-lang/perl:             5.38.2-r1::gentoo
dev-lang/python:           3.10.13::gentoo, 3.11.7::gentoo, 3.12.1_p1::gentoo
dev-lang/rust:             1.74.1::gentoo
dev-util/ccache:           4.9::gentoo
sys-apps/baselayout:       2.14-r1::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-apps/systemd:          255.3::gentoo
sys-devel/binutils:        2.38-r2::gentoo, 2.39-r5::gentoo, 2.40-r9::gentoo, 2.42::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           17.0.6::gentoo
sys-devel/gcc:             10.5.0::gentoo, 11.4.1_p20240201::gentoo, 12.3.1_p20240202::gentoo, 13.2.1_p20240203::gentoo, 14.0.9999::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/lld:             17.0.6::gentoo
sys-devel/llvm:            17.0.6::gentoo
sys-kernel/linux-headers:  6.7::gentoo (virtual/os-headers)
sys-libs/glibc:            2.39::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: sam_c
    volatile: False
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now
    sync-git-verify-commit-signature: yes

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

Installed sets: @sam-emacs, @sam-fonts, @sam-fortune
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O3 -march=native -mtls-dialect=gnu2 -fno-semantic-interposition -pipe -Wa,-O2 -Wa,-mtune=znver2 -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches  -Wreturn-type -Walloc-size -Wfree-nonheap-object -Wstrict-aliasing=2 -Wbuiltin-declaration-mismatch"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.3/ext-active/ /etc/php/cgi-php8.3/ext-active/ /etc/php/cli-php8.3/ext-active/ /etc/php/fpm-php8.3/ext-active/ /etc/php/phpdbg-php8.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O3 -march=native -mtls-dialect=gnu2 -fno-semantic-interposition -pipe -Wa,-O2 -Wa,-mtune=znver2 -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches "
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg=y --implicit-system-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --jobs=4 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O3 -march=native -mtls-dialect=gnu2 -fno-semantic-interposition -pipe -Wa,-O2 -Wa,-mtune=znver2 -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches "
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg clean-logs config-protect-if-modified distlocks fixlafiles ipc-sandbox merge-wait mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O3 -march=native -mtls-dialect=gnu2 -fno-semantic-interposition -pipe -Wa,-O2 -Wa,-mtune=znver2 -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches "
GENTOO_MIRRORS="https://www.mirrorservice.org/sites/distfiles.gentoo.org/ https://mirror.bytemark.co.uk/gentoo/ https://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,-z,pack-relative-relocs"
LEX="reflex"
LINGUAS="en en_GB"
MAKEOPTS="-j32 -l32"
PKGDIR="/var/cache/binpkgs"
PORTAGE_BUNZIP2_COMMAND="lbunzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs"
SHELL="/bin/bash"
USE="X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr clang cli crypt dbus declarative dist-kernel dri dts dvd dvdr editorconfig emacs encode exif f16c filecaps firewalld flac fma3 fortran freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kf6compat kwallet lcms libnotify libtirpc lto mad mmx mmxext mng modules-compress mp3 mp4 mpeg multilib ncurses nftables nls ogg opengl openmp pam pango pclmul pcre pdf pgo pic pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha sound spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test-rust tiff truetype udev udisks unicode upower usb valgrind verify-sig vorbis vulkan wayland widgets x264 xattr xcb xft xml xtpax xv xvid zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11 pypy3 python3_10 python3_12" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa i386 m68k ppc ppc64 ppc64le sparc sparc64 x86_64" RUBY_TARGETS="ruby31 ruby32" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
YACC="byacc"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, SIZE, STRINGS, STRIP, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-05 03:36:32 UTC
an old similar bug: https://trac.macports.org/ticket/66060
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-05 03:46:16 UTC
or it's glibc-2.39, which feels unlikely too.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-05 18:38:12 UTC
OK, I see what's happening now: the configure check for a conformant stdbool.h fails w/ gcc-14 because pg injects -Werror=vla.

See https://godbolt.org/z/h93TWsb89.

Clang and GCC 13 don't warn on it. Not sure if d+f are guaranteed to be constant expressions in C or not yet
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-08 08:24:23 UTC
*** Bug 924052 has been marked as a duplicate of this bug. ***
Comment 5 Larry the Git Cow gentoo-dev 2024-02-08 11:02:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=29fc9edc64e0e00a0ade3065238365a4aa46ec59

commit 29fc9edc64e0e00a0ade3065238365a4aa46ec59
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-02-08 10:48:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-02-08 10:53:06 +0000

    14.0.0: backport more vectorisation fixes & postgres const expression fix
    
    Bug: https://gcc.gnu.org/PR113808
    Bug: https://gcc.gnu.org/PR113750
    Bug: https://gcc.gnu.org/PR113731
    Bug: https://gcc.gnu.org/PR113734 (should be same as PR113808)
    Bug: https://gcc.gnu.org/PR113776
    Bug: https://bugs.gentoo.org/923804
    Bug: https://bugs.gentoo.org/923936
    Signed-off-by: Sam James <sam@gentoo.org>

 ...fix-ICE-when-moving-statements-to-empty-B.patch | 129 +++++++++++
 ...fix-ICE-when-destination-BB-for-stores-st.patch | 250 +++++++++++++++++++++
 ...-don-t-cache-restart_loop-in-vectorizable.patch |  93 ++++++++
 .../78_all_PR113776-c-boolean-conversion.patch     | 117 ++++++++++
 14.0.0/gentoo/README.history                       |   7 +
 5 files changed, 596 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2024-02-08 11:02:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b56417a1eb97d1b94d1f22ec87e76f2b47891ae4

commit b56417a1eb97d1b94d1f22ec87e76f2b47891ae4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-02-08 11:01:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-02-08 11:02:16 +0000

    sys-devel/gcc: backport more vectorisation fixes & postgres const expression fix
    
    Bug: https://gcc.gnu.org/PR113808
    Bug: https://gcc.gnu.org/PR113750
    Bug: https://gcc.gnu.org/PR113731
    Bug: https://gcc.gnu.org/PR113734 (should be same as PR113808)
    Bug: https://gcc.gnu.org/PR113776
    Closes: https://bugs.gentoo.org/923804
    Closes: https://bugs.gentoo.org/923936
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/gcc/Manifest                         |  1 +
 sys-devel/gcc/gcc-14.0.1_pre20240204-r1.ebuild | 64 ++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)