Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 922679 - dev-cpp/scitokens-cpp-1.1.0 fails tests (MUSL-SYSTEM): unit (Subprocess aborted)
Summary: dev-cpp/scitokens-cpp-1.1.0 fails tests (MUSL-SYSTEM): unit (Subprocess aborted)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Oliver Freyermuth
URL:
Whiteboard:
Keywords: PullRequest, TESTFAILURE
Depends on:
Blocks: 884417
  Show dependency tree
 
Reported: 2024-01-22 08:28 UTC by Agostino Sarubbo
Modified: 2024-01-30 08:24 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,51.24 KB, text/plain)
2024-01-22 08:28 UTC, Agostino Sarubbo
Details
1-LastTest.log (1-LastTest.log,20.74 KB, text/plain)
2024-01-22 08:28 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-01-22 08:28:36 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-cpp/scitokens-cpp-1.1.0 fails tests (MUSL-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc but this bug MAY or MAY NOT BE related to musl.
Comment 1 Agostino Sarubbo gentoo-dev 2024-01-22 08:28:39 UTC
Created attachment 882825 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-01-22 08:28:40 UTC
Created attachment 882826 [details]
1-LastTest.log

1-LastTest.log
Comment 3 Oliver Freyermuth 2024-01-23 15:17:38 UTC
Thanks for the report! 

Sadly, trying to reproduce with the latest Gentoo Docker images (stage3:musl and portage), I can't reproduce the test failures (tested via GitHub Actions at https://github.com/olifre/gentoo-musl-test ). I'll try to find whether there's a clean-cut difference between the Docker containers and the Tinderbox (one difference, for example, is that the Docker containers use stable versions which means a slightly older patchset of gcc 13.2.1). 

@Guilherme: Du you have an unstable musl system at hand on which it may be easier to reproduce?
Comment 4 Oliver Freyermuth 2024-01-23 19:25:21 UTC
Got it — this is not MUSL specific, and even hits the current stable version in tree, i.e. =dev-cpp/scitokens-cpp-1.0.2-r1. 

It appears on all hardened systems, and is very likely fixed via:
https://github.com/scitokens/scitokens-cpp/pull/126
(which has not been reviewed by upstream in the past half year, likely due to upstream developer overload). 

I'll validate that this does indeed fix it and prepare a backport / downstream patch shortly (and also bump upstream). 

Thanks again!
Comment 5 Larry the Git Cow gentoo-dev 2024-01-30 08:24:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6402e212219a2e9faa61f02099c0455e84817b7e

commit 6402e212219a2e9faa61f02099c0455e84817b7e
Author:     Oliver Freyermuth <o.freyermuth@googlemail.com>
AuthorDate: 2024-01-23 19:57:35 +0000
Commit:     Guilherme Amadio <amadio@gentoo.org>
CommitDate: 2024-01-30 08:23:58 +0000

    dev-cpp/scitokens-cpp: backport fix for invalid vector access
    
    Fixes tests on hardened systems and potential runtime errors.
    
    Closes: https://bugs.gentoo.org/922679
    Closes: https://github.com/gentoo/gentoo/pull/34980
    Signed-off-by: Oliver Freyermuth <o.freyermuth@googlemail.com>
    Signed-off-by: Guilherme Amadio <amadio@gentoo.org>

 ...scitokens-cpp-1.1.0-invalid-vector-access.patch | 24 +++++++++
 .../scitokens-cpp/scitokens-cpp-1.0.2-r2.ebuild    | 61 ++++++++++++++++++++++
 .../scitokens-cpp/scitokens-cpp-1.1.0-r1.ebuild    | 61 ++++++++++++++++++++++
 3 files changed, 146 insertions(+)