Bug 922633 – app-office/abiword-3.0.5-r1 - In function 'itex2MML_html_filter': itex2MML.y:1809:10: error: implicit declaration of function 'itex2MML_do_html_filter'; did you mean 'itex2MML_html_filter'? [-Wimplicit-function-declaration]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description ernsteiswuerfel 2024-01-21 16:44:27 UTC]

Created attachment 882792 [details]
build.log.xz (ppc, 3.0.5)

[...]
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../.. -Wall -Wextra -Wsign-compare -Wpointer-arith -Wchar-subscripts -Wwrite-strings -Wmissing-noreturn -Wformat-overflow=2 -Wunused -Wpointer-arith -Wshadow -O2 -mcpu=7450 -mtune=7450 -pipe -c y.tab.c  -fPIC -DPIC -o .libs/y.tab.o
itex2MML.y: In function 'itex2MML_yyerror':
itex2MML.y:32:30: warning: unused parameter 'ret_str' [-Wunused-parameter]
   32 |  static void yyerror (char **ret_str, char * s)
      |                       ~~~~~~~^~~~~~~
itex2MML.y: At top level:
itex2MML.y:126:33: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  126 |  char * itex2MML_empty_string = "";
      |                                 ^~
y.tab.c: In function 'itex2MML_yyparse':
y.tab.c:5794:29: warning: passing argument 2 of 'itex2MML_yyerror' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
 5794 |       yyerror (ret_str, YY_("syntax error"));
      |                             ^~~~~~~~~~~~~~
y.tab.c:1134:22: note: in definition of macro 'YY_'
 1134 | #  define YY_(Msgid) Msgid
      |                      ^~~~~
itex2MML.y:32:46: note: expected 'char *' but argument is of type 'const char *'
   32 |  static void yyerror (char **ret_str, char * s)
      |                                       ~~~~~~~^
y.tab.c:5905:25: warning: passing argument 2 of 'itex2MML_yyerror' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
 5905 |   yyerror (ret_str, YY_("memory exhausted"));
      |                         ^~~~~~~~~~~~~~~~~~
y.tab.c:1134:22: note: in definition of macro 'YY_'
 1134 | #  define YY_(Msgid) Msgid
      |                      ^~~~~
itex2MML.y:32:46: note: expected 'char *' but argument is of type 'const char *'
   32 |  static void yyerror (char **ret_str, char * s)
      |                                       ~~~~~~~^
itex2MML.y: In function 'itex2MML_html_filter':
itex2MML.y:1809:10: error: implicit declaration of function 'itex2MML_do_html_filter'; did you mean 'itex2MML_html_filter'? [-Wimplicit-function-declaration]
 1809 |   return itex2MML_do_html_filter (buffer, length, 0);
      |          ^~~~~~~~~~~~~~~~~~~~~~~
      |          itex2MML_html_filter
itex2MML.y: In function 'itex2MML_do_html_filter':
itex2MML.y:1853:2: warning: label '_until_html' defined but not used [-Wunused-label]
 1853 |  _until_html:
      |  ^~~~~~~~~~~
make[5]: *** [Makefile:598: y.tab.lo] Error 1
make[5]: Leaving directory '/var/tmp/portage/app-office/abiword-3.0.5/work/abiword-3.0.5/plugins/mathview/itex2mml'
make[4]: *** [Makefile:516: all] Error 2
make[4]: Leaving directory '/var/tmp/portage/app-office/abiword-3.0.5/work/abiword-3.0.5/plugins/mathview/itex2mml'
make[3]: *** [Makefile:698: all-recursive] Error 1
make[3]: Leaving directory '/var/tmp/portage/app-office/abiword-3.0.5/work/abiword-3.0.5/plugins/mathview'
make[2]: *** [Makefile:542: all-recursive] Error 1
make[2]: Leaving directory '/var/tmp/portage/app-office/abiword-3.0.5/work/abiword-3.0.5/plugins'
make[1]: *** [Makefile:813: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/app-office/abiword-3.0.5/work/abiword-3.0.5'
make: *** [Makefile:612: all] Error 2
 * ERROR: app-office/abiword-3.0.5::gentoo failed (compile phase):

[Comment 1 ernsteiswuerfel 2024-01-21 16:45:01 UTC]

Created attachment 882793 [details]
emerge --info

[Comment 2 ernsteiswuerfel 2024-07-28 21:16:42 UTC]

Reported the issue upstream: https://gitlab.gnome.org/World/AbiWord/-/issues/27

[Comment 3 ernsteiswuerfel 2024-07-28 21:17:22 UTC]

Created attachment 898477 [details]
build.log.xz (amd64, 3.0.5-r1)

[Comment 4 Michał Górny 2024-08-21 19:39:57 UTC]

Created attachment 900898 [details, diff]
Trivial patch

As noted on the upstream bug, the problem is misordered functions.  Here's a trivial patch for Gentoo that adds prototype (smaller than if we were to move them).

[Comment 5 ernsteiswuerfel 2024-08-21 22:09:57 UTC]

(In reply to Michał Górny from comment #4)
> As noted on the upstream bug, the problem is misordered functions.  Here's a
> trivial patch for Gentoo that adds prototype (smaller than if we were to
> move them).
Thanks for the patch! It applies fine and fixes the issue.

[Comment 6 Larry the Git Cow 2024-08-22 05:01:59 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02452a18f95e91923de3fbc01ca8e4ae2a2ad268

commit 02452a18f95e91923de3fbc01ca8e4ae2a2ad268
Author:     Michał Górny <[e-mail]>
AuthorDate: 2024-08-22 04:08:10 +0000
Commit:     Michał Górny <[e-mail]>
CommitDate: 2024-08-22 05:01:54 +0000

    app-office/abiword: Patch a build failure with gcc-14
    
    Closes: https://bugs.gentoo.org/922633
    Signed-off-by: Michał Górny <[e-mail]>

 app-office/abiword/abiword-3.0.5-r1.ebuild         |  2 ++
 app-office/abiword/files/abiword-3.0.5-gcc14.patch | 12 ++++++++++++
 2 files changed, 14 insertions(+)