Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 922630 - gnome-base/gnome-keyring-42.1-r2 - In function 'test_sign_verify': pkcs11/gkm/test-sexp.c:231:92: error: passing argument 6 of 'gkm_crypto_sign_xsa' from incompatible pointer type [-Wincompatible-pointer-types]
Summary: gnome-base/gnome-keyring-42.1-r2 - In function 'test_sign_verify': pkcs11/gkm...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2024-01-21 15:43 UTC by ernsteiswuerfel
Modified: 2024-03-17 03:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (ppc, 42.1-r2) (gnome-keyring-42.1-r2:20240121-143434.log,514.87 KB, text/plain)
2024-01-21 15:43 UTC, ernsteiswuerfel 		Details
emerge --info (file_922630.txt,6.47 KB, text/plain)
2024-01-21 15:43 UTC, ernsteiswuerfel 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ernsteiswuerfel archtester 2024-01-21 15:43:12 UTC 
Created attachment 882782 [details]
build.log (ppc, 42.1-r2)

[...]
powerpc-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I.  -DPREFIX=\""/usr"\" -DBINDIR=\""/usr/bin"\" -DLIBEXECDIR=\""/usr/libexec"\" -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DSRCDIR="\"/var/tmp/portage/gnome-base/gnome-keyring-42.1-r2/work/gnome-keyring-42.1\"" -DBUILDDIR="\"/var/tmp/portage/gnome-base/gnome-keyring-42.1-r2/work/gnome-keyring-42.1\"" -I. -I. -I./pkcs11 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_44 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_44   -Wall 	-Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes 	-Wnested-externs -Wpointer-arith 	-Wcast-align -Wsign-compare 	-Os -mcpu=7450 -mtune=7450 -pipe -Wno-strict-aliasing -Wno-sign-compare -c -o pkcs11/gkm/test-sexp.o pkcs11/gkm/test-sexp.c
pkcs11/gkm/test-sexp.c: In function 'test_sign_verify':
pkcs11/gkm/test-sexp.c:231:92: error: passing argument 6 of 'gkm_crypto_sign_xsa' from incompatible pointer type [-Wincompatible-pointer-types]
  231 | m_crypto_sign_xsa (test->rsakey, CKM_RSA_PKCS, data, data_size, signature, &signature_size);
      |                                                                            ^~~~~~~~~~~~~~~
      |                                                                            |
      |                                                                            gsize * {aka unsigned int *}

In file included from pkcs11/gkm/test-sexp.c:31:
./pkcs11/gkm/gkm-crypto.h:92:86: note: expected 'CK_ULONG_PTR' {aka 'long unsigned int *'} but argument is of type 'gsize *' {aka 'unsigned int *'}
   92 |                                                               CK_ULONG_PTR n_signature);
      |                                                               ~~~~~~~~~~~~~^~~~~~~~~~~

pkcs11/gkm/test-sexp.c:251:87: error: passing argument 6 of 'gkm_crypto_sign_xsa' from incompatible pointer type [-Wincompatible-pointer-types]
  251 |  = gkm_crypto_sign_xsa (test->dsakey, CKM_DSA, data, data_size, signature, &signature_size);
      |                                                                            ^~~~~~~~~~~~~~~
      |                                                                            |
      |                                                                            gsize * {aka unsigned int *}

./pkcs11/gkm/gkm-crypto.h:92:86: note: expected 'CK_ULONG_PTR' {aka 'long unsigned int *'} but argument is of type 'gsize *' {aka 'unsigned int *'}
   92 |                                                               CK_ULONG_PTR n_signature);
      |                                                               ~~~~~~~~~~~~~^~~~~~~~~~~

pkcs11/gkm/test-sexp.c:271:91: error: passing argument 6 of 'gkm_crypto_sign_xsa' from incompatible pointer type [-Wincompatible-pointer-types]
  271 | km_crypto_sign_xsa (test->ecdsakey, CKM_ECDSA, data, data_size, signature, &signature_size);
      |                                                                            ^~~~~~~~~~~~~~~
      |                                                                            |
      |                                                                            gsize * {aka unsigned int *}

./pkcs11/gkm/gkm-crypto.h:92:86: note: expected 'CK_ULONG_PTR' {aka 'long unsigned int *'} but argument is of type 'gsize *' {aka 'unsigned int *'}
   92 |                                                               CK_ULONG_PTR n_signature);
      |                                                               ~~~~~~~~~~~~~^~~~~~~~~~~

make[2]: *** [Makefile:4880: pkcs11/gkm/test-sexp.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/gnome-base/gnome-keyring-42.1-r2/work/gnome-keyring-42.1'
make[1]: *** [Makefile:6390: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/gnome-base/gnome-keyring-42.1-r2/work/gnome-keyring-42.1'
make: *** [Makefile:3215: all] Error 2
 * ERROR: gnome-base/gnome-keyring-42.1-r2::gentoo failed (compile phase):
Comment 1 ernsteiswuerfel archtester 2024-01-21 15:43:46 UTC 
Created attachment 882783 [details]
emerge --info
Comment 3 Larry the Git Cow gentoo-dev 2024-03-17 03:16:04 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da33ef820a414ac3f3aba54fd9099cc4494d13fe

commit da33ef820a414ac3f3aba54fd9099cc4494d13fe
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-17 03:10:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-17 03:10:06 +0000

    gnome-base/gnome-keyring: fix modern C issue in tests
    
    Closes: https://bugs.gentoo.org/922630
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/gnome-keyring-42.1-c99.patch             | 40 ++++++++++++++++++++++
 .../gnome-keyring/gnome-keyring-42.1-r2.ebuild     |  4 +++
 2 files changed, 44 insertions(+)