Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 922455 - app-portage/gentoolkit-0.6.4: backtrace in eclean-dist when $DISTDIR/git3-src doesn't exist
Summary: app-portage/gentoolkit-0.6.4: backtrace in eclean-dist when $DISTDIR/git3-src...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 622938
  Show dependency tree
 
Reported: 2024-01-19 04:23 UTC by Greg Kubaryk
Modified: 2024-01-19 07:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Kubaryk 2024-01-19 04:23:08 UTC
# eclean-dist -d
 * Building file list for distfiles cleaning...
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.11/eclean-dist", line 41, in <module>
    main()
  File "/usr/lib/python3.11/site-packages/gentoolkit/eclean/cli.py", line 737, in main
    doAction(action, options, exclude=exclude, output=output)
  File "/usr/lib/python3.11/site-packages/gentoolkit/eclean/cli.py", line 582, in doAction
    clean_me, saved, deprecated, vcs = engine.findDistfiles(
                                       ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/gentoolkit/eclean/search.py", line 139, in findDistfiles
    vcs = self.vcs_check(_distdir)
          ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/gentoolkit/eclean/search.py", line 359, in vcs_check
    actual_dirs = {os.path.join(vcs_src, i) for i in os.listdir(vcs_src)}
                                                     ^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/var/cache/distfiles/git3-src'



# emerge --info
Portage 3.0.61 (python 3.11.7-final-0, default/linux/amd64/17.1/hardened, gcc-13, glibc-2.38-r9, 5.10.186 x86_64)
=================================================================
System uname: Linux-5.10.186-x86_64-AMD_Phenom-tm-_II_X6_1045T_Processor-with-glibc2.38
KiB Mem:    16143108 total,   3140584 free
KiB Swap:   23246548 total,  23241428 free
Timestamp of repository gentoo: Fri, 19 Jan 2024 02:30:01 +0000
Head commit of repository gentoo: b937b6c90a9f028eb71fcb1d75a6fdb1f8377961
Head commit of repository meow: d1aa3cf83fcd7a75c419ebe31527adb14b89aa00

sh bash 5.2_p26
ld GNU ld (Gentoo 2.41 p4) 2.41.0
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p26::gentoo
dev-build/autoconf:        2.72-r1::gentoo
dev-build/automake:        1.16.5-r1::gentoo
dev-build/cmake:           3.28.1-r1::gentoo
dev-build/libtool:         2.4.7-r2::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.3.1-r1::gentoo
dev-lang/perl:             5.38.2-r1::gentoo
dev-lang/python:           3.11.7::gentoo, 3.12.1_p1::gentoo
dev-lang/rust-bin:         1.74.1::gentoo
sys-apps/baselayout:       2.14-r1::gentoo
sys-apps/openrc:           0.53::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-devel/binutils:        2.41-r4::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           17.0.6::gentoo
sys-devel/gcc:             13.2.1_p20240113-r1::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/llvm:            17.0.6::gentoo
sys-kernel/linux-headers:  6.6::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r9::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    volatile: False
    sync-rsync-verify-jobs: 3
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 3

hex
    location: /var/db/repos/hex
    masters: gentoo
    volatile: True

meow
    location: /var/db/repos/meow
    sync-type: git
    sync-uri: https://github.com/gkubaryk/meow
    masters: gentoo
    volatile: False

Binary Repositories:

purr
    sync-uri: http://192.168.5.55:8079

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--verbose-slot-rebuilds=n --usepkg-exclude 'sys-kernel/* virtual/* */*-bin x11-base/xorg-drivers sys-firmware/* www-plugins/*' --buildpkg-exclude 'sys-kernel/* virtual/* */*-bin x11-base/xorg-drivers sys-firmware/* www-plugins/*'"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance binpkg-request-signature binpkg-signing buildpkg buildpkg-live config-protect-if-modified distlocks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://gentoo.osuosl.org/ http://mirrors.rit.edu/gentoo/ http://mirror.csclub.uwaterloo.ca/gentoo-distfiles/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
MAKEOPTS="-j6"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="acl amd64 bzip2 cet cli crypt dist-kernel dri fortran gdbm hardened iconv ipv6 libtirpc multilib ncurses nls openmp pam pcre pic pie readline seccomp split-usr ssl ssp test-rust unicode xattr xtpax zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="3dnow 3dnowext mmx mmxext popcnt sse sse2 sse3 sse4a" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" GRUB_PLATFORMS="pc" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby31" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Greg Kubaryk 2024-01-19 05:25:07 UTC
adding
        if not os.path.exists(vcs_src):
          return {}

near the top of vcs_check in pym/gentoolkit/eclean/search.py seemed to fix it locally, perhaps there is a cleaner way
Comment 2 Larry the Git Cow gentoo-dev 2024-01-19 06:15:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=c584d83705a2ca08961e4f0b541442fdf9a75947

commit c584d83705a2ca08961e4f0b541442fdf9a75947
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-19 06:14:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-19 06:15:12 +0000

    eclean: fix eclean-dist with no git3-src dir
    
    Bug: https://bugs.gentoo.org/922455
    Signed-off-by: Sam James <sam@gentoo.org>

 pym/gentoolkit/eclean/search.py | 3 +++
 1 file changed, 3 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2024-01-19 06:38:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=45be97b4062ce6c22dd88e10f7349857ac7369a5

commit 45be97b4062ce6c22dd88e10f7349857ac7369a5
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-19 06:38:07 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-19 06:38:07 +0000

    app-portage/gentoolkit: add 0.6.5, drop 0.6.4
    
    Closes: https://bugs.gentoo.org/922455
    Signed-off-by: Sam James <sam@gentoo.org>

 app-portage/gentoolkit/Manifest                                         | 2 +-
 .../gentoolkit/{gentoolkit-0.6.4.ebuild => gentoolkit-0.6.5.ebuild}     | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2024-01-19 07:03:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=bd9c485781584e951e703ee191308db23506af9a

commit bd9c485781584e951e703ee191308db23506af9a
Author:     Siddhanth Rathod <xsiddhanthrathod@gmail.com>
AuthorDate: 2024-01-19 06:59:55 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-19 07:03:39 +0000

    eclean: handle when git3-src doesn't exist (port to Pathlib)
    
    Followup to c584d83705a2ca08961e4f0b541442fdf9a75947.
    
    Bug: https://bugs.gentoo.org/922455
    Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com>
    Closes: https://github.com/gentoo/gentoolkit/pull/41
    Signed-off-by: Sam James <sam@gentoo.org>

 pym/gentoolkit/eclean/search.py | 50 ++++++++++++++++++++---------------------
 1 file changed, 25 insertions(+), 25 deletions(-)