Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 921649 - kde-apps/gwenview-23.08.4: error: type ‘Gwenview::Sorting::Enum’ violates the C++ One Definition Rule [-Werror=odr]
Summary: kde-apps/gwenview-23.08.4: error: type ‘Gwenview::Sorting::Enum’ violates the...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 921687 (view as bug list)
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2024-01-09 10:28 UTC by Viorel Munteanu
Modified: 2024-10-12 15:19 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log.bz2,10.96 KB, application/x-bzip)
2024-01-09 10:28 UTC, Viorel Munteanu
Details
emerge --info (emerge-info.txt,25.52 KB, text/plain)
2024-01-09 10:29 UTC, Viorel Munteanu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Viorel Munteanu gentoo-dev 2024-01-09 10:28:30 UTC
Created attachment 881741 [details]
build.log

/mnt/tmp/portage/kde-apps/gwenview-23.08.4/work/gwenview-23.08.4/lib/../lib/sorting.h:37:6: error: type ‘Gwenview::Sorting::Enum’ violates the C++ One Definition Rule [-Werror=odr]
   37 | enum Enum {
      |      ^
/mnt/tmp/portage/kde-apps/gwenview-23.08.4/work/gwenview-23.08.4/lib/../lib/sorting.h:37:6: note: an enum with different number of values is defined in another translation unit
   37 | enum Enum {
      |      ^
lto1: some warnings being treated as errors
lto-wrapper: fatal error: /usr/bin/x86_64-pc-linux-gnu-g++ returned 1 exit status
compilation terminated.
/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
Comment 1 Viorel Munteanu gentoo-dev 2024-01-09 10:29:01 UTC
Created attachment 881742 [details]
emerge --info
Comment 2 Leonardo Hernández Hernández 2024-01-10 05:23:06 UTC
*** Bug 921687 has been marked as a duplicate of this bug. ***
Comment 3 Paolo Pedroni 2024-03-11 10:50:05 UTC
Same for kde-apps/gwenview-24.02.0:6
Comment 4 Eli Schwartz gentoo-dev 2024-09-03 04:41:09 UTC
Analyzed and fixed.
Comment 5 Larry the Git Cow gentoo-dev 2024-09-03 05:29:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02627a66a2883017dc5888ce730e9d4f63e9ed86

commit 02627a66a2883017dc5888ce730e9d4f63e9ed86
Author:     Eli Schwartz <eschwartz@gentoo.org>
AuthorDate: 2024-09-03 04:58:42 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-09-03 05:29:23 +0000

    kde-apps/gwenview: apply patch to fix UB due to ODR violations
    
    Closes: https://bugs.gentoo.org/921649
    Acked-by: Sam James <sam@gentoo.org>
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 kde-apps/gwenview/files/gwenview-24.08.0-odr.patch |  58 +++++++++++
 kde-apps/gwenview/gwenview-24.05.2-r2.ebuild       | 113 +++++++++++++++++++++
 ...w-24.08.0.ebuild => gwenview-24.08.0-r1.ebuild} |   4 +
 3 files changed, 175 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2024-10-12 15:19:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=64d366374215e5e33932d51b5e4d28f0d568fa82

commit 64d366374215e5e33932d51b5e4d28f0d568fa82
Author:     Eli Schwartz <eschwartz@gentoo.org>
AuthorDate: 2024-09-03 04:58:42 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-10-12 15:18:29 +0000

    kde-apps/gwenview: apply patch to fix UB due to ODR violations
    
    Bug: https://bugs.gentoo.org/921649
    Closes: https://bugs.gentoo.org/941274
    Acked-by: Sam James <sam@gentoo.org>
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/gwenview/gwenview-24.08.2.ebuild | 3 +++
 1 file changed, 3 insertions(+)