Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 921090 - sci-libs/datasets: blocks on old <=dev-python/fsspec-2023.10.0, =dev-python/sqlalchemy-1*
Summary: sci-libs/datasets: blocks on old <=dev-python/fsspec-2023.10.0, =dev-python/s...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tupone Alfredo
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 722500
  Show dependency tree
 
Reported: 2023-12-30 14:34 UTC by Michał Górny
Modified: 2024-03-06 11:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-12-30 14:34:30 UTC
NonsolvableDepsInStable: version 2.14.7: nonsolvable depset(rdepend) keyword(~amd64) stable profile (default/linux/amd64/17.1) (18 total): solutions: [ <=dev-python/fsspec-2023.10.0[python_targets_python3_10(-)], <=dev-python/fsspec-2023.10.0[python_targets_python3_11(-)] ]


Btw I'm pretty sure <= is the wrong operator to use.
Comment 1 Tupone Alfredo gentoo-dev 2023-12-30 15:09:54 UTC
from datasets/setup.py:

REQUIRED_PKGS = [
....
"fsspec[http]>=2023.1.0,<=2023.10.0",
...
]

Any hint on how to proceed ?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-12-30 16:06:34 UTC
Figure out if the new version really doesn't work.  Strip the restriction if it does, fix it upstream if it doesn't.
Comment 3 Tupone Alfredo gentoo-dev 2023-12-30 16:15:10 UTC
A lot of tests are not working with a newer version of fsspec.

So the restriction should remain.

When I have time I will see if some patch on datasets can work it
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-27 11:10:57 UTC
Please make sure there's at least an upstream bug for it.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-27 11:11:25 UTC
https://github.com/huggingface/datasets/commit/129b9e0565e7a2ceaca64b99dcbf39504661cfa9 unpins sqlalchemy at least
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-02-20 09:02:17 UTC
Ping.  FWICS it's only used by libs, no non-lib revdeps.
Comment 7 Larry the Git Cow gentoo-dev 2024-02-22 07:27:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=05e867ed4f4ffc6bcbf57160225dcce103062057

commit 05e867ed4f4ffc6bcbf57160225dcce103062057
Author:     Alfredo Tupone <tupone@gentoo.org>
AuthorDate: 2024-02-22 07:26:13 +0000
Commit:     Alfredo Tupone <tupone@gentoo.org>
CommitDate: 2024-02-22 07:26:40 +0000

    sci-libs/datasets: add 2.17.1, drop 2.16.0
    
    Bug: https://bugs.gentoo.org/921090
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 sci-libs/datasets/Manifest                         |  2 +-
 ...tasets-2.16.0.ebuild => datasets-2.17.1.ebuild} |  8 ++++--
 .../datasets/files/datasets-2.14.4-tests.patch     | 10 --------
 ...6.0-tests.patch => datasets-2.17.1-tests.patch} | 29 ++++++++--------------
 4 files changed, 17 insertions(+), 32 deletions(-)
Comment 8 Tupone Alfredo gentoo-dev 2024-02-23 19:55:11 UTC
last commit dropped pin on sqlalchemy
Comment 9 Larry the Git Cow gentoo-dev 2024-03-06 11:15:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b2d1e80c67cfdd58b4526f71442e66ad38c92f2e

commit b2d1e80c67cfdd58b4526f71442e66ad38c92f2e
Author:     Alfredo Tupone <tupone@gentoo.org>
AuthorDate: 2024-03-06 11:14:44 +0000
Commit:     Alfredo Tupone <tupone@gentoo.org>
CommitDate: 2024-03-06 11:15:18 +0000

    sci-libs/datasets: add 2.18.0, drop 2.17.1
    
    Closes: https://bugs.gentoo.org/921090
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 sci-libs/datasets/Manifest                                           | 2 +-
 sci-libs/datasets/{datasets-2.17.1.ebuild => datasets-2.18.0.ebuild} | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)