too long lines were shrinked: [45/77] x86_64-pc-linux-gnu-gcc -Ilibflashrom.so.1.0.0.p -I. -I../flashrom-v1.3.0 -I../flashrom-v1.3.0/include -I/usr/include/libusb-1.0 -I/usr/include/libftdi1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c99 -Wshadow -Wmissing-prototypes -Wwrite-strings -Wno-u [46/77] x86_64-pc-linux-gnu-gcc -Ilibflashrom.so.1.0.0.p -I. -I../flashrom-v1.3.0 -I../flashrom-v1.3.0/include -I/usr/include/libusb-1.0 -I/usr/include/libftdi1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c99 -Wshadow -Wmissing-prototypes -Wwrite-strings -Wno-u [47/77] x86_64-pc-linux-gnu-gcc -Ilibflashrom.so.1.0.0.p -I. -I../flashrom-v1.3.0 -I../flashrom-v1.3.0/include -I/usr/include/libusb-1.0 -I/usr/include/libftdi1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c99 -Wshadow -Wmissing-prototypes -Wwrite-strings -Wno-u [48/77] x86_64-pc-linux-gnu-gcc -Ilibflashrom.so.1.0.0.p -I. -I../flashrom-v1.3.0 -I../flashrom-v1.3.0/include -I/usr/include/libusb-1.0 -I/usr/include/libftdi1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c99 -Wshadow -Wmissing-prototypes -Wwrite-strings -Wno-u FAILED: libflashrom.so.1.0.0.p/dummyflasher.c.o x86_64-pc-linux-gnu-gcc -Ilibflashrom.so.1.0.0.p -I. -I../flashrom-v1.3.0 -I../flashrom-v1.3.0/include -I/usr/include/libusb-1.0 -I/usr/include/libftdi1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c99 -Wshadow -Wmissing-prototypes -Wwrite-strings -Wno-unused-pa ../flashrom-v1.3.0/dummyflasher.c:933:27: error: initialization of _Bool (*)(const struct flashrom_flashctx *, uint8_t) {aka _Bool (*)(const struct flashrom_flashctx *, unsigned char)} from incompatible pointer type _Bool (*)(struct flashrom_flashctx *, uint8_t) {aka _Bool (*)(struct flashrom_flashc 933 | .probe_opcode = dummy_spi_probe_opcode, | ^~~~~~~~~~~~~~~~~~~~~~ ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_desktop_gnome_systemd-20231123-162118 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-10 [2] x86_64-pc-linux-gnu-14 * clang/llvm (if any): clang version 17.0.6 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm/17/bin Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg /usr/lib/llvm/17 17.0.6 Python 3.11.7 Available Ruby profiles: [1] ruby31 (with Rubygems) * Available Rust versions: [1] rust-bin-1.73.0 * The following VMs are available for generation-2: 1) Eclipse Temurin JDK 11.0.20.1_p1 [openjdk-bin-11] 2) Eclipse Temurin JDK 17.0.8.1_p1 [openjdk-bin-17] *) Eclipse Temurin JDK 21.0.1_p12 [openjdk-bin-21] 4) Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8] Available Java Virtual Machines: [1] openjdk-bin-8 [2] openjdk-bin-11 [3] openjdk-bin-17 [4] openjdk-bin-21 system-vm The Glorious Glasgow Haskell Compilation System, version 9.2.8 php cli (if any): [1] php8.1 [2] php8.2 * go version go1.21.4 linux/amd64 HEAD of ::gentoo commit e28fc074ef5b9bf6fdac3f2a057ac0dba04b6695 Author: Repository mirror & CI <repomirrorci@gentoo.org> Date: Tue Dec 5 10:02:04 2023 +0000 2023-12-05 10:02:03 UTC emerge -qpvO sys-apps/flashrom [ebuild N ] sys-apps/flashrom-1.3.0-r1 USE="atapromise atavia buspirate-spi ch341a-spi developerbox-spi drkaiser dummy ft2232-spi internal-dmi it8212 linux-mtd linux-spi mstarddc-spi nic3com nicintel nicintel-eeprom nicintel-spi nicrealtek ogp-spi pickit2-spi raiden-debug-spi rayer-spi realtek-mst-i2c-spi satamv serprog stlinkv3-spi usbblaster-spi -atahpt -dediprog -digilent-spi -dirtyjtag-spi -gfxnvidia -internal -jlink-spi -mediatek-i2c-spi -nicnatsemi -parade-lspcon -pony-spi -satasii -test -tools"
Created attachment 877391 [details] emerge-info.txt
Created attachment 877392 [details] emerge-history.txt.xz
Created attachment 877393 [details] environment
Created attachment 877394 [details] etc.clang.tar.xz
Created attachment 877395 [details] etc.portage.tar.xz
Created attachment 877396 [details] logs.tar.xz
Created attachment 877397 [details] qlist-info.txt.xz
Created attachment 877398 [details] sys-apps:flashrom-1.3.0-r1:20231205-111514.log
Created attachment 877399 [details] temp.tar.xz
https://github.com/flashrom/flashrom/commit/e31d721469a37bd5784b86ffcd2318108a796616 probably fixes it
i'd guess so, will test soon
yes, the patch fixes it after dropping some hunks that are apparently in the existing patchset already
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=40a676f1eaff2df0d3c2d95a7694f0696ed19b00 commit 40a676f1eaff2df0d3c2d95a7694f0696ed19b00 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-03-13 04:37:48 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-13 04:37:48 +0000 sys-apps/flashrom: fix modern C issue Closes: https://bugs.gentoo.org/919266 Signed-off-by: Sam James <sam@gentoo.org> sys-apps/flashrom/files/flashrom-1.3.0-c99.patch | 59 ++++++++++ sys-apps/flashrom/flashrom-1.3.0-r2.ebuild | 133 +++++++++++++++++++++++ 2 files changed, 192 insertions(+)
