Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 919100 - sys-apps/dbus-broker: test failures with -fno-semantic-interposition (aliasing issue?)
Summary: sys-apps/dbus-broker: test failures with -fno-semantic-interposition (aliasin...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 915000
  Show dependency tree
 
Reported: 2023-12-03 04:36 UTC by Sam James
Modified: 2023-12-03 09:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_919100.txt,199.75 KB, text/plain)
2023-12-03 04:36 UTC, Sam James
Details
testlog.txt (file_919100.txt,46.01 KB, text/plain)
2023-12-03 04:38 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-03 04:36:23 UTC
Created attachment 876503 [details]
build.log

25/46 dbus-broker / Name Registry                        OK              0.04s
26/46 libcdvar-1 / Basic API Behavior                    FAIL            0.25s   killed by signal 6 SIGABRT
>>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 MALLOC_PERTURB_=216 /var/tmp/portage/sys-apps/dbus-broker-33/work/dbus-broker-33-build/subprojects/libcdvar-1/src/test-basic
 ✀
stderr:
test-basic: ../dbus-broker-33/subprojects/libcdvar-1/src/test-basic.c:81: test_basic_serialization: Assertion `false && "!strcmp(str1, \"foo\")"' failed.

[...]
----

$ emerge --info
Portage 3.0.56 (python 3.12.0-final-0, default/linux/amd64/17.1/hardened, gcc-14, glibc-2.38-r7, 6.6.3 x86_64)
=================================================================
System uname: Linux-6.6.3-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.38
KiB Mem:    65758032 total,  11552224 free
KiB Swap:   16662520 total,  16662520 free
Timestamp of repository gentoo: Sun, 03 Dec 2023 02:32:01 +0000
Head commit of repository gentoo: fdfd3a14f32bf12623212bfb5fd848c6c5cd71d6

Timestamp of repository kde: Sat, 02 Dec 2023 21:46:53 +0000
Head commit of repository kde: d34eb57b73244ce1070405a3f28deede7a16539c

Timestamp of repository qt: Mon, 27 Nov 2023 11:01:53 +0000
Head commit of repository qt: 7071b523f771b82452e8aa7a5cf4603f2a47ef77

Timestamp of repository sam_c: Tue, 21 Nov 2023 21:03:38 +0000
Head commit of repository sam_c: 825751d17304603dd900cc0dfe2c9e405b562c31

Timestamp of repository steam-overlay: Mon, 27 Nov 2023 11:16:58 +0000
Head commit of repository steam-overlay: f0f7b42613f9bf45b2772ae50d0c0faeeb7a6ccb

sh dash 0.5.12
ld GNU ld (Gentoo 2.41 p2) 2.41.0
ccache version 4.8.3 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p21-r1::gentoo
dev-java/java-config:      2.3.3-r1::gentoo
dev-lang/perl:             5.38.2::gentoo
dev-lang/python:           3.10.13::gentoo, 3.11.6::gentoo, 3.12.0_p1::gentoo
dev-lang/rust:             1.73.0::gentoo
dev-util/ccache:           4.8.3::gentoo
dev-util/cmake:            3.27.9::gentoo
dev-util/meson:            1.3.0-r1::gentoo
sys-apps/baselayout:       2.14-r1::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-apps/systemd:          255_rc4::gentoo
sys-devel/autoconf:        2.13-r8::gentoo, 2.69-r9::gentoo, 2.71-r7::gentoo, 9999::gentoo
sys-devel/automake:        1.16.5-r1::gentoo
sys-devel/binutils:        2.38-r2::gentoo, 2.39-r5::gentoo, 2.40-r9::gentoo, 2.41-r2::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           17.0.6::gentoo
sys-devel/gcc:             10.5.0::gentoo, 11.4.1_p20231130::gentoo, 12.3.1_p20231201::gentoo, 13.2.1_p20231125::gentoo, 14.0.0.9999::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             17.0.6::gentoo
sys-devel/llvm:            17.0.6::gentoo
sys-devel/make:            4.4.1-r1::gentoo
sys-kernel/linux-headers:  6.6::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: sam_c
    volatile: False
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now
    sync-git-verify-commit-signature: yes

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

Installed sets: @sam-emacs, @sam-fonts, @sam-fortune
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O3 -march=native -fno-semantic-interposition -pipe -Wa,-O2 -Wa,-mtune=znver2 -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches  "
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.2/ext-active/ /etc/php/cgi-php8.2/ext-active/ /etc/php/cli-php8.2/ext-active/ /etc/php/fpm-php8.2/ext-active/ /etc/php/phpdbg-php8.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O3 -march=native -fno-semantic-interposition -pipe -Wa,-O2 -Wa,-mtune=znver2 -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches  "
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg=y --implicit-system-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --jobs=4 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O3 -march=native -fno-semantic-interposition -pipe -Wa,-O2 -Wa,-mtune=znver2 -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches  "
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg clean-logs compress-build-logs config-protect-if-modified distlocks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O3 -march=native -fno-semantic-interposition -pipe -Wa,-O2 -Wa,-mtune=znver2 -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches  "
GENTOO_MIRRORS="https://mirrors.gethosted.online/gentoo/ https://www.mirrorservice.org/sites/distfiles.gentoo.org/ https://mirror.bytemark.co.uk/gentoo/ https://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,-z,pack-relative-relocs"
LEX="reflex"
LINGUAS="en en_GB"
MAKEOPTS="-j32 --output-sync=line"
PKGDIR="/var/cache/binpkgs"
PORTAGE_BUNZIP2_COMMAND="lbunzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs"
SHELL="/bin/bash"
USE="X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr cet clang cli crypt dbus declarative dist-kernel dri dts dvd dvdr editorconfig emacs encode exif f16c filecaps firewalld flac fma3 fortran freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libnotify libtirpc lto mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses nftables nls nptl ogg opengl openmp pam pango pclmul pcre pdf pgo pic pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha sound spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test-rust tiff truetype udev udisks unicode upower usb valgrind verify-sig vorbis vulkan wayland widgets x264 xattr xcb xft xml xtpax xv xvid zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11 pypy3 python3_10 python3_12" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa i386 m68k ppc ppc64 ppc64le sparc sparc64 x86_64" RUBY_TARGETS="ruby31 ruby32" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
YACC="byacc"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, SIZE, STRINGS, STRIP, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-03 04:38:42 UTC
Created attachment 876504 [details]
testlog.txt
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-03 04:39:24 UTC
This happens w/ gcc-13 + -O2 as well, it just needs -fno-semantic-interposition. It stops happening with -fno-strict-aliasing.

I applied this for now:

commit ac0bc46eaa27105ea7ca3d854ecaeaa3b99e9880
Author: Sam James <sam@gentoo.org>
Date:   Sun Dec 3 00:20:00 2023 +0000

    sys-apps/dbus-broker: filter -fno-semantic-interposition

    Causes test failures.

    (Not going to revbump as this isn't anything new and anyone who hits it
    would notice immediately.)

    Signed-off-by: Sam James <sam@gentoo.org>


Just filed the bug here so I remember to come back to it and dig in more.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-03 04:40:32 UTC
The issue is in the libcdvar subproject (https://github.com/c-util/c-dvar).

I can reproduce it w/ this from a libcdvar clone:
CFLAGS="-Og -ggdb3 -fno-semantic-interposition" meson setup build --wipe ; meson test -C build
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-03 04:41:57 UTC
sorry, you need -O2, not -Og.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-03 04:42:17 UTC
test-basic: ../src/test-basic.c:81: test_basic_serialization: Assertion `false && "!strcmp(str1, \"foo\")"' failed.

Program received signal SIGABRT, Aborted.
0x00007ffff7e4d21c in ?? () from /usr/lib64/libc.so.6
(gdb) frame 5
#5  0x000055555555621e in test_basic_serialization (big_endian=big_endian@entry=true) at ../src/test-basic.c:81
81              c_assert(!strcmp(str1, "foo"));
(gdb) p str1
$1 = 0x55555555a0b9 ""
(gdb)
Comment 6 Larry the Git Cow gentoo-dev 2023-12-03 04:45:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9541f03613b3824f83a26dd1f0654f1e031a6050

commit 9541f03613b3824f83a26dd1f0654f1e031a6050
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-12-03 04:43:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-03 04:45:00 +0000

    sys-apps/dbus-broker: filter-lto & -fno-strict-aliasing
    
    Initially hit a test failure w/ -fno-semantic-interposition and hadn't yet
    had a chance to dig in more, but it looks like it's really an aliasing issue
    exposed by it (dbus-broker doesn't rely on LD_PRELOAD at all).
    
    So, follow up to ac0bc46eaa27105ea7ca3d854ecaeaa3b99e9880, filter-lto and pass
    -fno-strict-aliasing with a new revision as this may well break in other cases
    even w/o -fno-semantic-interposition.
    
    Bug: https://bugs.gentoo.org/919100
    Signed-off-by: Sam James <sam@gentoo.org>

 .../dbus-broker/{dbus-broker-33.ebuild => dbus-broker-33-r1.ebuild}  | 5 +++--
 sys-apps/dbus-broker/dbus-broker-9999.ebuild                         | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-03 08:54:13 UTC
I figured I'd try -Werror=strict-aliasing -Wstrict-aliasing=2 on a punt first before spending more time on it.

I'm glad I did, because it wasn't in the serialisation code like I expected, but a submodule of it.

Long story short: https://github.com/c-util/c-utf8/commit/4b7cb9f940e45d3c68bf427cdeeaf5da47b03b41. I'll pull that in now.
Comment 8 Larry the Git Cow gentoo-dev 2023-12-03 09:02:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=345f98126f9d9d6abbd7fa89868f2c4edfed6001

commit 345f98126f9d9d6abbd7fa89868f2c4edfed6001
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-12-03 09:00:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-03 09:02:04 +0000

    sys-apps/dbus-broker: backport strict aliasing fix
    
    Closes: https://bugs.gentoo.org/919100
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/dbus-broker/dbus-broker-33-r2.ebuild      |  65 +++++++
 sys-apps/dbus-broker/dbus-broker-9999.ebuild       |  10 +-
 .../files/dbus-broker-33-strict-aliasing.patch     | 207 +++++++++++++++++++++
 3 files changed, 277 insertions(+), 5 deletions(-)