Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916788 - dev-util/android-tools-34.0.1 - /.../incremental_utils.cpp: error: remove_if is not a member of std
Summary: dev-util/android-tools-34.0.1 - /.../incremental_utils.cpp: error: remove_if ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Zac Medico
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: gcc-14
  Show dependency tree
 
Reported: 2023-11-04 08:51 UTC by Toralf Förster
Modified: 2023-12-09 21:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.99 KB, text/plain)
2023-11-04 08:51 UTC, Toralf Förster
Details
dev-util:android-tools-34.0.1:20231104-065452.log.xz (dev-util:android-tools-34.0.1:20231104-065452.log.xz,11.47 KB, application/x-xz)
2023-11-04 08:51 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,94.84 KB, text/plain)
2023-11-04 08:51 UTC, Toralf Förster
Details
environment (environment,135.60 KB, text/plain)
2023-11-04 08:51 UTC, Toralf Förster
Details
etc.clang.tar.xz (etc.clang.tar.xz,1.05 KB, application/x-xz)
2023-11-04 08:51 UTC, Toralf Förster
Details
etc.portage.tar.xz (etc.portage.tar.xz,34.07 KB, application/x-xz)
2023-11-04 08:51 UTC, Toralf Förster
Details
logs.tar.xz (logs.tar.xz,2.05 KB, application/x-xz)
2023-11-04 08:51 UTC, Toralf Förster
Details
qlist-info.txt (qlist-info.txt,169.59 KB, text/plain)
2023-11-04 08:51 UTC, Toralf Förster
Details
temp.tar.xz (temp.tar.xz,40.49 KB, application/x-xz)
2023-11-04 08:51 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2023-11-04 08:51:31 UTC
too long lines were shrinked:

  172 |     }
      |     ^
[277/677] /usr/bin/x86_64-pc-linux-gnu-g++ -DADB_HOST=1 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -I/var/tmp/portage/dev-util/android-tools-34.0.1/work/android-tools-34.0.1_build/vendor -I/var/tmp/portage/dev-util/android-tools-34.0.1/work/android-tools-34.0.1/vendor/base/libs/androidfw/include -I/var/tm
FAILED: vendor/CMakeFiles/libadb.dir/adb/client/incremental_utils.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -DADB_HOST=1 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -I/var/tmp/portage/dev-util/android-tools-34.0.1/work/android-tools-34.0.1_build/vendor -I/var/tmp/portage/dev-util/android-tools-34.0.1/work/android-tools-34.0.1/vendor/base/libs/androidfw/include -I/var/tmp/portage/
/var/tmp/portage/dev-util/android-tools-34.0.1/work/android-tools-34.0.1/vendor/adb/client/incremental_utils.cpp: In function void incremental::unduplicate(std::vector<T>&):
/var/tmp/portage/dev-util/android-tools-34.0.1/work/android-tools-34.0.1/vendor/adb/client/incremental_utils.cpp:159:18: error: remove_if is not a member of std; did you mean remove_cv?
  159 |     v.erase(std::remove_if(v.begin(), v.end(),
      |                  ^~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1-20231102-160004

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10
 [2] x86_64-pc-linux-gnu-14 *
clang/llvm (if any):
clang version 17.0.4
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/17/bin
Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg
/usr/lib/llvm/17
17.0.4
Python 3.11.6
Available Ruby profiles:
  [1]   ruby31 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.73.0 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 17.0.8.1_p1 [openjdk-bin-17]
2)	Eclipse Temurin JDK 21.0.1_p12 [openjdk-bin-21]
*)	Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm
  [2]   openjdk-bin-17 
  [3]   openjdk-bin-21 

php cli (if any):
  [1]   php8.2 *
go version go1.21.3 linux/amd64

  HEAD of ::gentoo
commit 06ced47e02e5d68d5265c28ec977a323621d8bd6
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Sat Nov 4 00:31:59 2023 +0000

    2023-11-04 00:31:58 UTC

emerge -qpvO dev-util/android-tools
[ebuild  N    ] dev-util/android-tools-34.0.1  USE="-python -udev" PYTHON_TARGETS="python3_11 -python3_10"
Comment 1 Toralf Förster gentoo-dev 2023-11-04 08:51:32 UTC
Created attachment 874033 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-11-04 08:51:32 UTC
Created attachment 874034 [details]
dev-util:android-tools-34.0.1:20231104-065452.log.xz
Comment 3 Toralf Förster gentoo-dev 2023-11-04 08:51:34 UTC
Created attachment 874035 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2023-11-04 08:51:35 UTC
Created attachment 874036 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2023-11-04 08:51:36 UTC
Created attachment 874037 [details]
etc.clang.tar.xz
Comment 6 Toralf Förster gentoo-dev 2023-11-04 08:51:37 UTC
Created attachment 874038 [details]
etc.portage.tar.xz
Comment 7 Toralf Förster gentoo-dev 2023-11-04 08:51:38 UTC
Created attachment 874039 [details]
logs.tar.xz
Comment 8 Toralf Förster gentoo-dev 2023-11-04 08:51:39 UTC
Created attachment 874040 [details]
qlist-info.txt
Comment 9 Toralf Förster gentoo-dev 2023-11-04 08:51:40 UTC
Created attachment 874041 [details]
temp.tar.xz
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-04 15:24:35 UTC
Missing <algorithm> inlcude.
Comment 11 Larry the Git Cow gentoo-dev 2023-12-09 21:43:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ea1752bdffb228b31f045b17c6603afcf18ed192

commit ea1752bdffb228b31f045b17c6603afcf18ed192
Author:     Christopher Fore <csfore@posteo.net>
AuthorDate: 2023-12-09 20:07:12 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2023-12-09 21:43:31 +0000

    dev-util/android-tools: Add patch to fix compilation on GCC 14
    
    <algorithm> is no longer included by default in GCC 14 so explicitly
    including it is now required.
    
    Upstream: https://github.com/nmeum/android-tools/pull/129
    AOSP CR: https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2838578
    AOSP CR: https://android-review.googlesource.com/c/platform/system/core/+/2839495
    
    Both CRs to AOSP have been merged and upstream has merged the PR as
    well, all that is needed is a version bump from AOSP.
    
    Closes: https://bugs.gentoo.org/916788
    Signed-off-by: Christopher Fore <csfore@posteo.net>
    Closes: https://github.com/gentoo/gentoo/pull/34201
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 dev-util/android-tools/android-tools-34.0.1.ebuild |  1 +
 .../android-tools-34.0.1-include-algorithm.patch   | 45 ++++++++++++++++++++++
 2 files changed, 46 insertions(+)