Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916582 - dev-libs/liborcus-0.17.2-r1 fails to build with gcc 14
Summary: dev-libs/liborcus-0.17.2-r1 fails to build with gcc 14
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: gcc-14
  Show dependency tree
 
Reported: 2023-10-31 16:29 UTC by Kostadin Shishmanov
Modified: 2023-11-03 23:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,193.30 KB, text/x-log)
2023-10-31 16:29 UTC, Kostadin Shishmanov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kostadin Shishmanov 2023-10-31 16:29:31 UTC
Created attachment 873790 [details]
build log

dev-libs/liborcus-0.17.2-r1 fails to build with gcc 14, built fine with gcc 13, 

Fix is as simple as including <algorithm>


document.cpp: In member function 'orcus::spreadsheet::col_t orcus::spreadsheet::{anonymous}::table_handler::find_column(const orcus::spreadsheet::table_t&, std::string_view, size_t) const':
document.cpp:190:18: error: 'find_if' is not a member of 'std'; did you mean 'find'?
  190 |             std::find_if(it_beg, it_end, find_column_by_name(name));
      |                  ^~~~~~~
      |                  find
document.cpp: In member function 'void orcus::spreadsheet::document::finalize()':
document.cpp:403:10: error: 'for_each' is not a member of 'std'
  403 |     std::for_each(mp_impl->m_sheets.begin(), mp_impl->m_sheets.end(),
      |          ^~~~~~~~
document.cpp: In member function 'const orcus::spreadsheet::sheet* orcus::spreadsheet::document::get_sheet(std::string_view) const':
document.cpp:432:20: error: 'find_if' is not a member of 'std'; did you mean 'find'?
  432 |     auto it = std::find_if(
      |                    ^~~~~~~
      |                    find
document.cpp: In member function 'orcus::spreadsheet::sheet_t orcus::spreadsheet::document::get_sheet_index(std::string_view) const':
document.cpp:622:20: error: 'find_if' is not a member of 'std'; did you mean 'find'?
  622 |     auto it = std::find_if(
      |                    ^~~~~~~
      |                    find
make[3]: *** [Makefile:667: liborcus_spreadsheet_model_0.17_la-document.lo] Error 1
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-31 16:30:59 UTC
Fancy doing a PR to backport https://gitlab.com/orcus/orcus/-/commit/f5dca3b4f7c6ffda4b71e0ba9f7081ab2eec3405? (no revbump required)
Comment 2 Larry the Git Cow gentoo-dev 2023-11-03 23:58:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f0e7fbdb25bc731c4b9d769c0bcb21e33aff004

commit 6f0e7fbdb25bc731c4b9d769c0bcb21e33aff004
Author:     Kostadin Shishmanov <kocelfc@tutanota.com>
AuthorDate: 2023-10-31 16:56:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-03 23:51:21 +0000

    dev-libs/liborcus: fix build with gcc 14
    
    Closes: https://bugs.gentoo.org/916582
    Signed-off-by: Kostadin Shishmanov <kocelfc@tutanota.com>
    Closes: https://github.com/gentoo/gentoo/pull/33609
    Signed-off-by: Sam James <sam@gentoo.org>

 .../liborcus/files/liborcus-0.17.2-gcc-14.patch     | 21 +++++++++++++++++++++
 dev-libs/liborcus/liborcus-0.17.2-r1.ebuild         |  1 +
 2 files changed, 22 insertions(+)